From: Piyush Srivastava <piyushsriva@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Org-info-js folding is broken in 8.3 releases
Date: Sat, 5 Sep 2015 20:20:53 -0700 [thread overview]
Message-ID: <CAOcBitRNW7WQbzQ7ZJRUEJx9Xx+SE-uPW=OofkZTd7GdXQtDpg@mail.gmail.com> (raw)
In-Reply-To: <CAOcBitTXjPHLZ1oojVKDaM9CXfE3quGXJzRD6wiXrjT4gpK3BA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2301 bytes --]
I think I have finally isolated a fix. org-info.js uses the magic number
"4" (i.e. the length of the string "sec-") to substring DOM ids in order to
fin section numbers (this is on line number 97 in the source code of
org-info-src.js). However the changes to org-export-get-reference mean
that instead of using the string "sec-" before the section heading, ox-html
now used the string "orgheadline". Thus, the fix is to replace "4" by
"orgheadline".length in the source code of org-info-src.js.
This seems to be the simplest way to fix this error. However, as it is, it
will break those people's code who are using the online version of the
script. We will probably need to detect what string the html file is using
in the DOM id for headlines and used the length of that string. I will try
to write a patch in the next few days if this strategy sounds good.
-- Piyush.
On Sat, Sep 5, 2015 at 5:20 PM, Piyush Srivastava <piyushsriva@gmail.com>
wrote:
> In fact, further investigation shows that the first commit that actually
> breaks org-info-js is the replacement of `org-export-get-headline-id' by
> `org-export-get-reference' in commit id 459033 on April 13. These problems
> are temporarily fixed by commit cf7d64, and then reintroduced by commit
> 4ee8f4 which reverted the changes made to org-export-get-reference in
> cf7d64.
>
> -- Piyush.
>
>
> On Sat, Sep 5, 2015 at 4:20 PM, Piyush Srivastava <piyushsriva@gmail.com>
> wrote:
>
>> Hi,
>>
>>
>> In the current 8.3.1 release of org-mode the f/F keybinding that
>> org-info-js provides for folding headings in plain mode (of exported html
>> files) fails to work. Further, the 's' and 'o' keys for search and occur
>> respectively also fail to work. Both of these work with the 8.2.10 release.
>>
>> I have attached a minimal org-mode file with which I can reproduce this
>> error. By bisecting the commit history, I find that the breaking change is
>> introduced by commit 4ee8f4 which has the following commit message:
>>
>> Author: Rasmus <rasmus@gmx.us>
>> Date: Sun Apr 19 16:00:06 2015 +0200
>>
>> Revert "ox: Change label naming scheme"
>>
>> This reverts commit cf7d64f1e456cad281674fc81a8074f969b7911c.
>>
>> The log produced by git bisect is also attached.
>>
>>
>> Thanks,
>> -- Piyush.
>>
>>
>>
>>
>>
>
[-- Attachment #2: Type: text/html, Size: 3364 bytes --]
next prev parent reply other threads:[~2015-09-06 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 23:20 Org-info-js folding is broken in 8.3 releases Piyush Srivastava
2015-09-06 0:20 ` Piyush Srivastava
2015-09-06 3:20 ` Piyush Srivastava [this message]
2015-09-06 3:32 ` Piyush Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOcBitRNW7WQbzQ7ZJRUEJx9Xx+SE-uPW=OofkZTd7GdXQtDpg@mail.gmail.com' \
--to=piyushsriva@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).