emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "András Simonyi" <andras.simonyi@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] oc-csl: Improve LaTeX bibliography formatting
Date: Mon, 7 Nov 2022 12:15:12 +0100	[thread overview]
Message-ID: <CAOWRwxAoayy_d-Ax-nv+KPgR7gLqpuSBFCLFBES+sgGcPv-EPA@mail.gmail.com> (raw)
In-Reply-To: <87o7tja3ag.fsf@localhost>

Dear All,

On Mon, 7 Nov 2022 at 03:47, Ihor Radchenko <yantar92@posteo.net> wrote:

>  Please, document the new customization in ORG-NEWS.

Dear Ihor, thanks for the comments! I'm going to update the NEWS file
shortly in a new version of the patch.

> Also, it would be nice to describe CSL usage and tweaks in the manual.

Time permitting I may try to add something, but wouldn't it be a
problem if the CSL export processor was discussed in much more detail
than the others?
I was also thinking about providing a list of available citation
substyles but I do not want to make the manual very unbalanced.

> I have two comments here:
> 1. Where are all these new commands coming from? They are not used
>    directly in the code. Are you tweaking citeproc.el output this way? May
>    it be better to use customizations provided by citeproc.el itself?

Yes, the citeproc org-latex formatter, which I added specifically for
Org, uses these commands in the LaTeX code produced for the
bibliography. As citeproc doesn't have customizable variables by
design (if I recall correctly, the only exception is 2 hooks), and
oc-csl already had some variables concerned with very similar
formatting settings (org-cite-csl-latex-hanging-indent,
org-cite-csl-html-hanging-indent,
org-cite-csl-html-label-width-per-char) I think it is more consistent
to have the new ones also in Org.

> 2. You are declaring this variable as defcustom, but it is not clear
>    what is going to happen if the user changes it. It is not how to
>    change this template in meaningful ways either.

Right, I can try to detail a bit in the docstring what type of
commands and environments have to be provided by the preamble (are
expected by citeproc). I tried to follow Timothy's handling of the
ox-latex engraved preamble, but a simpler alternative would be to
treat it simply as a constant template, at least for the time being --
WDYT?

best wishes,
András

> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2022-11-07 11:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06  9:42 [PATCH] oc-csl: Improve LaTeX bibliography formatting András Simonyi
2022-11-07  2:47 ` Ihor Radchenko
2022-11-07 11:15   ` András Simonyi [this message]
2022-11-08  5:26     ` Ihor Radchenko
2022-12-11 19:00       ` András Simonyi
2022-12-12  9:07         ` Ihor Radchenko
2022-12-12 11:15           ` András Simonyi
2022-12-12 11:24             ` Ihor Radchenko
2022-12-29 15:40               ` Bastien Guerry
2022-12-31 12:22                 ` Screenshots in ORG-NEWS (was: [PATCH] oc-csl: Improve LaTeX bibliography formatting) Ihor Radchenko
2023-01-02 15:11                   ` Screenshots in ORG-NEWS Bastien
2023-01-03 10:34                     ` Ihor Radchenko
2023-01-03 12:36                       ` Bastien
2022-12-13 16:05           ` [PATCH] oc-csl: Improve LaTeX bibliography formatting Timothy
2022-12-13 19:03             ` András Simonyi
2022-12-27 22:32               ` András Simonyi
2022-12-29 10:14                 ` Ihor Radchenko
2022-12-29 21:51                   ` András Simonyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOWRwxAoayy_d-Ax-nv+KPgR7gLqpuSBFCLFBES+sgGcPv-EPA@mail.gmail.com \
    --to=andras.simonyi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).