emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Henning Redestig <henning.red@googlemail.com>
To: Bastien <bzg@gnu.org>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: org-mode fontification error [6 times]
Date: Wed, 4 Apr 2012 19:46:46 +0200	[thread overview]
Message-ID: <CAO8D54y4Xusfrb2nwodtXWWobC3kMD0+D4j+PW8zZB9prxFyPA@mail.gmail.com> (raw)
In-Reply-To: <87fwckm2l1.fsf@gnu.org>

Better now but still some issues here, now if I start a new org buffer and type

<s [TAB]

to complete the source block, I get org-mode fontification error again.

2012/4/4 Bastien <bzg@gnu.org>:
> Hi Nick,
>
> Nick Dokos <nicholas.dokos@hp.com> writes:
>
>> Confirmed. It only happens when you start typing into an empty buffer.
>> Looks like an off-by-one error in org.el:org-fontify-meta-lines-and-blocks-1,
>> aroung line 5487:
>>
>> ,----
>> |         ;; just any other in-buffer setting, but not indented
>> |         (add-text-properties
>> |          beg (1+ (match-end 0))
>> |          '(font-lock-fontified t face org-meta-line))
>> `----
>>
>> The second arg should probably be just (match-end 0).
>
> That's correct.  I first thought (min (point-max) (1+ (match-end 0)))
> would have been safer, but I really don't see why the 1+.
>
> Please confirm this is fixed.
>
> Thanks,
>
> --
>  Bastien



-- 
/Henning

  reply	other threads:[~2012-04-04 17:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 13:17 org-mode fontification error [6 times] Leo
2011-08-18  7:22 ` Bastien
2011-08-18  8:01   ` Leo
2012-04-03 19:43     ` Henning Redestig
2012-04-03 21:23       ` Nick Dokos
2012-04-04  6:30         ` Bastien
2012-04-04 17:46           ` Henning Redestig [this message]
2012-04-04 18:41             ` Nick Dokos
2012-04-09 17:21             ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO8D54y4Xusfrb2nwodtXWWobC3kMD0+D4j+PW8zZB9prxFyPA@mail.gmail.com \
    --to=henning.red@googlemail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=nicholas.dokos@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).