From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ULXWNxYU+182VgAA0tVLHw (envelope-from ) for ; Sun, 10 Jan 2021 14:49:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wGyBMxYU+18cZQAAbx9fmQ (envelope-from ) for ; Sun, 10 Jan 2021 14:49:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F3CD9401C0 for ; Sun, 10 Jan 2021 14:49:55 +0000 (UTC) Received: from localhost ([::1]:45628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyc2T-0006Ha-Lu for larch@yhetil.org; Sun, 10 Jan 2021 09:49:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kybfH-0001JA-Lg for emacs-orgmode@gnu.org; Sun, 10 Jan 2021 09:25:55 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:34531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kybfE-0008Nh-Ni for emacs-orgmode@gnu.org; Sun, 10 Jan 2021 09:25:54 -0500 Received: by mail-wr1-x42a.google.com with SMTP id q18so13750480wrn.1 for ; Sun, 10 Jan 2021 06:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=SHRZuTP/l6I6TMeI96TNgNkgcA0aUXlQn/an8OTkfh4=; b=laT+ZHYWwc02ohsLGHLPrUPSSqjoLSrYy7pBQCzDlZ1vWPF0VwCVjpQt3+EcWqa6m8 SRNlITso5+GbfpNGVFRGQM/OSNjUt1ezvsSiQtTeztouXqnJu2G6lDlZXQaGDQeUD/Pz nuTj+s88K3ytWy7j4jGB8QyGH9ZZwj8Ufx3HUZB2E5QCfV7krfwWxKiBKOn9jTU9UHCd +fbqW6OtGQXbaQ/J1sA4NXZn0vhBjYIbMtjC33QbMpX/oItjThzVQzqpnx1Y1IXK2YUH YFh3riZ9HgCEkpuJA+gPy4CtwdRLeSRuxMRmc5Z9QZpcP1Z9HY9TQV4DgGNiCsglQtlT FwMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=SHRZuTP/l6I6TMeI96TNgNkgcA0aUXlQn/an8OTkfh4=; b=FdaeqfyEzXmloyBQsB6I4jHJOUAjFcGWhyeVN1K4GM1kwTdBRJpTkxGPlPJBdWjwNj vEjPYRR6JSVUAWrn84Mdu403CbQWw8+709UmBeRBaXRAJNPFUoOMkItog2RCj8cXTbT5 IgfKfAeDvo0ngzKHhewWs/ixKrCX3oUKLedacvOsNyW9IC6yQl82QLj04AQUdihT35sa ld9ILLJq1auYC45SO70NKI8QB09367qo5gZLgBH3qc9BDgsYHput8F9ChgHYkMwik7VZ Ca3AoRdX1wNH840dOQsAXm2psUXe3t9nclN5hK6m40+xrlQ4Ncd3RyAa/zwLvK/kF48T 7C3w== X-Gm-Message-State: AOAM532zEIumimqk0HjO30+5R9fFgqDl0XID5nwzcKaDtHn0t9gdzwm1 J+a6+ebTqNSWo9CIz8S9rS6TEdd0589/GQTu6+aN9JAep2g= X-Google-Smtp-Source: ABdhPJw5lAWiIIDbDNtcNEQ2E9O4mCbCT0zlUuheH0Rvej0RY2YyeE7aIPco+XRPOASYGY478fWkg4tvJuNrIn8rNeg= X-Received: by 2002:adf:8503:: with SMTP id 3mr12508930wrh.56.1610288748333; Sun, 10 Jan 2021 06:25:48 -0800 (PST) MIME-Version: 1.0 From: Jamie Bayne Date: Sun, 10 Jan 2021 14:25:40 +0000 Message-ID: Subject: [PATCH] ob-lilypond: allow user configuration of header-args To: emacs-orgmode@gnu.org Content-Type: multipart/mixed; boundary="000000000000d5878305b88c9055" Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=jtbayne@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 10 Jan 2021 09:49:19 -0500 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.15 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=laT+ZHYW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 4F3CD9401C0 X-Spam-Score: -0.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: xibMhl3oDB5V --000000000000d5878305b88c9055 Content-Type: multipart/alternative; boundary="000000000000d5878005b88c9053" --000000000000d5878005b88c9053 Content-Type: text/plain; charset="UTF-8" Hi all, I hit the problem described in https://www.mail-archive.com/emacs-orgmode@gnu.org/msg127317.html - I couldn't see that anyone else had fixed it so I had a go. The problem is that, unusually, ob-lilypond has some conditional logic on its header-args. Its solution is to set the header-args internally when required, which overrides any user-specified value. The quickest way I could see to preserve the conditional logic was to add a new variable to hold the user configuration, which I called ob-lilypond-header-args. Now the conditional logic sets org-babel-header-args:lilypond to the new variable's value when appropriate. Another way would be to create a context which sets the variable when needed and then resets it. I opted against this as I'm not sure it would have the same behaviour in all cases. Happy to have a go if it would be preferable, though. Cheers, Jamie --000000000000d5878005b88c9053 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,

I hit the problem de= scribed in https://www.mail-archive.com/emacs-orgmode@gnu.org/msg127317.= html - I couldn't see that anyone else had fixed it so I had a go.<= /div>

The problem is that, unusually, ob-lilypond has so= me conditional logic on its header-args. Its solution is to set the header-= args internally when required, which overrides any user-specified value.

The quickest way I could see to preserve the conditi= onal logic was to add a new variable to hold the user configuration, which = I called ob-lilypond-header-args. Now the conditional logic sets org-babel-= header-args:lilypond to the new variable's value when appropriate.

Another way would be to create a context which sets th= e variable when needed and then resets it. I opted against this as I'm = not sure it would have the same behaviour in all cases. Happy to have a go = if it would be preferable, though.

Cheers,
Jamie
--000000000000d5878005b88c9053-- --000000000000d5878305b88c9055 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Allow-user-to-set-ob-lilypond-header-arguments.patch" Content-Disposition: attachment; filename="0001-Allow-user-to-set-ob-lilypond-header-arguments.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjr82bml0 RnJvbSBmNDEzYTM2YWM5YjdjYTdjOTkwZWUxYWI2NDU2Y2MyMzdlYmNjZjNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW1pZSBCYXluZSA8amFtaWViYXluZUBob3RtYWlsLmNvbT4K RGF0ZTogU2F0LCAyIEphbiAyMDIxIDAyOjE4OjM3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gQWxs b3cgdXNlciB0byBzZXQgb2ItbGlseXBvbmQgaGVhZGVyIGFyZ3VtZW50cwoKKiBvYi1saWx5cG9u ZC5lbCAob3JnLWJhYmVsLWxpbHlwb25kLXNldC1oZWFkZXItYXJncyk6IFJlcGxhY2UKaGFyZC1j b2RlZCBzZXR0aW5ncyB3aXRoIHVzZXItY29uZmlndXJhYmxlIHZhcmlhYmxlLgoob3JnLWJhYmVs LWhlYWRlci1hcmdzOmxpbHlwb25kKTogTW9kaWZ5IGRvY3VtZW50YXRpb24uCihvYi1saWx5cG9u ZC1oZWFkZXItYXJncyk6IE5ldyB2YXJpYWJsZS4KClRJTllDSEFOR0UKLS0tCiBsaXNwL29iLWxp bHlwb25kLmVsIHwgMTQgKysrKysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb2ItbGlseXBvbmQuZWwg Yi9saXNwL29iLWxpbHlwb25kLmVsCmluZGV4IGZiZGQ5MDVhNS4uMTFhZTlhZTg4IDEwMDY0NAot LS0gYS9saXNwL29iLWxpbHlwb25kLmVsCisrKyBiL2xpc3Avb2ItbGlseXBvbmQuZWwKQEAgLTQz LDYgKzQzLDE1IEBACiAoZGVmdmFyIG9yZy1iYWJlbC1kZWZhdWx0LWhlYWRlci1hcmdzOmxpbHlw b25kICcoKQogICAiRGVmYXVsdCBoZWFkZXIgYXJndW1lbnRzIGZvciBsaWx5cG9uZCBjb2RlIGJs b2Nrcy4KIE5PVEU6IFRoZSBhcmd1bWVudHMgYXJlIGRldGVybWluZWQgYXQgbGlseXBvbmQgY29t cGlsZSB0aW1lLgorU2VlIGBvcmctYmFiZWwtbGlseXBvbmQtc2V0LWhlYWRlci1hcmdzJworVG8g Y29uZmlndXJlLCBzZWUgYG9iLWxpbHlwb25kLWhlYWRlci1hcmdzJworLiIpCisKKyhkZWZ2YXIg b2ItbGlseXBvbmQtaGVhZGVyLWFyZ3MKKyAgJygoOnJlc3VsdHMgLiAiZmlsZSIpICg6ZXhwb3J0 cyAuICJyZXN1bHRzIikpCisgICJVc2VyLWNvbmZpZ3VyYWJsZSBoZWFkZXIgYXJndW1lbnRzIGZv ciBsaWx5cG9uZCBjb2RlIGJsb2Nrcy4KK05PVEU6IFRoZSBmaW5hbCB2YWx1ZSB1c2VkIGJ5IG9y Zy1iYWJlbCBpcyBjb21wdXRlZCBhdCBjb21waWxlLXRpbWUKK2FuZCBzdG9yZWQgaW4gIGBvcmct YmFiZWwtZGVmYXVsdC1oZWFkZXItYXJnczpsaWx5cG9uZCcKIFNlZSBgb3JnLWJhYmVsLWxpbHlw b25kLXNldC1oZWFkZXItYXJncycuIikKIAogKGRlZnZhciBvcmctYmFiZWwtbGlseXBvbmQtY29t cGlsZS1wb3N0LXRhbmdsZSB0CkBAIC00MDMsOSArNDEyLDggQEAgVGhlc2UgZGVwZW5kIHVwb24g d2hldGhlciB3ZSBhcmUgaW4gQXJyYW5nZSBtb2RlIGkuZS4gTU9ERSBpcyB0LiIKICAgICAgICAg ICAgKDpyZXN1bHRzIC4gInNpbGVudCIpCiAgICAgICAgICAgICg6Y2FjaGUgLiAieWVzIikKICAg ICAgICAgICAgKDpjb21tZW50cyAuICJ5ZXMiKSkpCi0gICAgICAgICh0Ci0gICAgICAgICAnKCg6 cmVzdWx0cyAuICJmaWxlIikKLSAgICAgICAgICAgKDpleHBvcnRzIC4gInJlc3VsdHMiKSkpKSkK KyAgICAgICAgKHQgCisgICAgICAgICAgb2ItbGlseXBvbmQtaGVhZGVyLWFyZ3MpKSkKIAogKGRl ZnVuIG9yZy1iYWJlbC1saWx5cG9uZC1zZXQtaGVhZGVyLWFyZ3MgKG1vZGUpCiAgICJTZXQgb3Jn LWJhYmVsLWRlZmF1bHQtaGVhZGVyLWFyZ3M6bGlseXBvbmQKLS0gCjIuMjkuMgoK --000000000000d5878305b88c9055--