From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Price Subject: extra paragraph in image export? Date: Sat, 21 Jan 2017 11:26:29 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c05b79090a46005469d3a2a Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUyUu-0000eU-Rp for emacs-orgmode@gnu.org; Sat, 21 Jan 2017 11:26:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUyUq-0002dn-Gd for emacs-orgmode@gnu.org; Sat, 21 Jan 2017 11:26:36 -0500 Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]:36943) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cUyUq-0002bf-BB for emacs-orgmode@gnu.org; Sat, 21 Jan 2017 11:26:32 -0500 Received: by mail-it0-x232.google.com with SMTP id r185so40725596ita.0 for ; Sat, 21 Jan 2017 08:26:30 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode --94eb2c05b79090a46005469d3a2a Content-Type: text/plain; charset=UTF-8 with org-html-html5-fancy is non-nil, images are exported with something like this code:

proof_2x.png

At least in ox-reveal, this makes it quite difficult to address images separately from text (e.g., to set the text-align property appropriately. You can try this if you have ox-reveal installed with any simple image: ---------- * Test [[https://imgs.xkcd.com/comics/proof_2x.png]] -------- At least on my machine, the image won't be centered in the resultant slide, and it will be hard to construct CSS to fix the issue. Is there a strong reason to include the

tag? I've removed it from org-html--wrap-image and haven't noticed any ill effects so far, but haven't done much testing. --94eb2c05b79090a46005469d3a2a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

with org-html-html5-fancy is non-= nil, images are exported with something like this code:

<figure&g= t;
<p><img src=3D"https://imgs.xkcd.com/comics/proof_2x.png" alt=3D&qu= ot;proof_2x.png" class=3D"fragment (appear) visible current-fragm= ent" data-fragment-index=3D"0"></p>
</figure&= gt;


At least in ox-reveal, this makes it quite difficult t= o address images separately from text (e.g., to set the text-align property= appropriately.=C2=A0 You can try this if you have ox-reveal installed with= any simple image:
----------
* Test
[[https://imgs.xkcd.com/comics/proof_2= x.png]]

--------
At least on my machine, the image won&= #39;t be centered in the resultant slide, and it will be hard to construct = CSS to fix the issue.=C2=A0

Is there a strong reason to inclu= de the <p> tag? I've removed it from org-html--wrap-image and hav= en't noticed any ill effects so far, but haven't done much testing.= =C2=A0

--94eb2c05b79090a46005469d3a2a-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Price Subject: Re: extra paragraph in image export? Date: Sat, 21 Jan 2017 18:09:08 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11448be2923b580546a2daf9 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cV4mV-0000GO-F5 for emacs-orgmode@gnu.org; Sat, 21 Jan 2017 18:09:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cV4mU-0004Ih-6f for emacs-orgmode@gnu.org; Sat, 21 Jan 2017 18:09:11 -0500 Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]:35611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cV4mU-0004IV-1N for emacs-orgmode@gnu.org; Sat, 21 Jan 2017 18:09:10 -0500 Received: by mail-it0-x22b.google.com with SMTP id 203so42423077ith.0 for ; Sat, 21 Jan 2017 15:09:10 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode --001a11448be2923b580546a2daf9 Content-Type: text/plain; charset=UTF-8 On Sat, Jan 21, 2017 at 11:26 AM, Matt Price wrote: > with org-html-html5-fancy is non-nil, images are exported with something > like this code: > >
>

alt="proof_2x.png" class="fragment (appear) visible current-fragment" > data-fragment-index="0">

>
> > There is some cruft in here -- I hastily copied from `inspect element` instead of from the code itself, and also included some ox-reveal-specific markup. This is a more representative output:

proof_2x.png

The following's still true: > > At least in ox-reveal, this makes it quite difficult to address images > separately from text (e.g., to set the text-align property appropriately). > You can try this if you have ox-reveal installed with any simple image: > ---------- > * Test > [[https://imgs.xkcd.com/comics/proof_2x.png]] > > -------- > At least on my machine, the image won't be centered in the resultant > slide, and it will be hard to construct CSS to fix the issue. > > Is there a strong reason to include the

tag? I've removed it from > org-html--wrap-image and haven't noticed any ill effects so far, but > haven't done much testing. > > --001a11448be2923b580546a2daf9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



On Sat, Jan 21, 2017 at 11:26 AM, Matt Price <moptop99@gmail.com&= gt; wrote:
The following's still true:

At least in ox-reveal, this makes it quite difficult to addres= s images separately from text (e.g., to set the text-align property appropr= iately).=C2=A0 You can try this if you have ox-reveal installed with any si= mple image:
----------
* Test
[[https://imgs.xkcd.com/comics/proof_2x.png]]

--------
At least on my machine= , the image won't be centered in the resultant slide, and it will be ha= rd to construct CSS to fix the issue.=C2=A0

Is there a strong= reason to include the <p> tag? I've removed it from org-html--wr= ap-image and haven't noticed any ill effects so far, but haven't do= ne much testing.=C2=A0


--001a11448be2923b580546a2daf9-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: extra paragraph in image export? Date: Sun, 22 Jan 2017 14:18:47 +0100 Message-ID: <87lgu3b5c8.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVI2q-00073F-6d for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 08:18:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVI2p-0002z1-1k for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 08:18:56 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:44291) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVI2o-0002yw-Rf for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 08:18:54 -0500 In-Reply-To: (Matt Price's message of "Sat, 21 Jan 2017 11:26:29 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Matt Price Cc: Org Mode Hello, Matt Price writes: > with org-html-html5-fancy is non-nil, images are exported with something > like this code: > >
>

proof_2x.png class="fragment (appear) visible current-fragment" > data-fragment-index="0">

>
> > > At least in ox-reveal, this makes it quite difficult to address images > separately from text (e.g., to set the text-align property appropriately. > You can try this if you have ox-reveal installed with any simple image: > ---------- > * Test > [[https://imgs.xkcd.com/comics/proof_2x.png]] > > -------- > At least on my machine, the image won't be centered in the resultant slide, > and it will be hard to construct CSS to fix the issue. > > Is there a strong reason to include the

tag? I've removed it from > org-html--wrap-image and haven't noticed any ill effects so far, but > haven't done much testing. I'm not well-versed enough in HTML to answer this, but, from Org POV, there should be a difference between A paragraph #+caption: foo [[block-image.png]] Another paragraph and A paragraph with an [[inline-image.png]] and some text following. Would removing the

tag blur the difference between the two examples above ? Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: extra paragraph in image export? Date: Tue, 24 Jan 2017 10:40:32 +0100 Message-ID: <87sho8ztgv.fsf@gmx.us> References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVxbV-0007Iu-Q6 for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 04:41:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVxbR-0001EL-2G for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 04:41:29 -0500 Received: from [195.159.176.226] (port=33340 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cVxbQ-0001Dt-RU for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 04:41:24 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cVxav-0001V0-EF for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 10:40:53 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi, >> with org-html-html5-fancy is non-nil, images are exported with something >> like this code: >> >>

>>

proof_2x.png> class="fragment (appear) visible current-fragment" >> data-fragment-index="0">

>>
I'm not an expert of HTML either. However, the "p" tag inside the "figure" is uncommon looking a bit on the example usages online. Thus, I agree with Matt that it should probably not be there. > I'm not well-versed enough in HTML to answer this, but, from Org POV, > there should be a difference between > > A paragraph > > #+caption: foo > [[block-image.png]] > > Another paragraph > > > and > > A paragraph with an [[inline-image.png]] and some text following. > > Would removing the

tag blur the difference between the two examples > above ? (I hope I understand your concern correctly). AFAIK, the CSS selector still differs so on the output side they are not alike. I.e. the former is "figure>img" the other is a "p>img". Aside: If anything, removing the "p" tag inside the figure would make it easier to handle images. Rasmus -- Vote for proprietary math! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: extra paragraph in image export? Date: Tue, 24 Jan 2017 22:27:39 +0100 Message-ID: <87fuk86tdg.fsf@nicolasgoaziou.fr> References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cW8cz-0005O8-Pf for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 16:27:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cW8cw-0003dk-Mp for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 16:27:45 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47297) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cW8cw-0003dN-Fq for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 16:27:42 -0500 In-Reply-To: <87sho8ztgv.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 24 Jan 2017 10:40:32 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Hello, Rasmus writes: > I'm not an expert of HTML either. However, the "p" tag inside the > "figure" is uncommon looking a bit on the example usages online. Thus, I > agree with Matt that it should probably not be there. OK. > AFAIK, the CSS selector still differs so on the output side they are not > alike. I.e. the former is "figure>img" the other is a "p>img". Aside: If > anything, removing the "p" tag inside the figure would make it easier to > handle images. So would the following patch fix the issue? Regards, -- Nicolas Goaziou --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ox-html-Remove-p-tag-around-block-images-when-using-.patch >From 49ebd5a8406bdee0c0a94b83f7135d94e35bb6ba Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Tue, 24 Jan 2017 22:22:47 +0100 Subject: [PATCH] ox-html: Remove

tag around block images when using HTML5 * lisp/ox-html.el (org-html--wrap-image): Do not add a spurious

tag when using

to mark images. --- lisp/ox-html.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/ox-html.el b/lisp/ox-html.el index d3c1b2eb1..fa8476a05 100644 --- a/lisp/ox-html.el +++ b/lisp/ox-html.el @@ -1607,7 +1607,7 @@ arguments CAPTION and LABEL are given, use them for caption and ;; ID. (if (org-string-nw-p label) (format " id=\"%s\"" label) "") ;; Contents. - (format "\n

%s

" contents) + (if html5-fancy contents (format "\n

%s

" contents)) ;; Caption. (if (not (org-string-nw-p caption)) "" (format (if html5-fancy "\n
%s
" -- 2.11.0 --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Price Subject: Re: extra paragraph in image export? Date: Tue, 24 Jan 2017 22:57:18 -0500 Message-ID: References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> <87fuk86tdg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c089ecca3d64a0546e33a54 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWEi2-0007XF-73 for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 22:57:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWEi1-0002hr-Ch for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 22:57:22 -0500 Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]:37745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWEi1-0002ha-6B for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 22:57:21 -0500 Received: by mail-it0-x22b.google.com with SMTP id r185so4462821ita.0 for ; Tue, 24 Jan 2017 19:57:19 -0800 (PST) In-Reply-To: <87fuk86tdg.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org Mode , Rasmus --94eb2c089ecca3d64a0546e33a54 Content-Type: text/plain; charset=UTF-8 On Tue, Jan 24, 2017 at 4:27 PM, Nicolas Goaziou wrote: > Hello, > > Rasmus writes: > > > I'm not an expert of HTML either. However, the "p" tag inside the > > "figure" is uncommon looking a bit on the example usages online. Thus, I > > agree with Matt that it should probably not be there. > > OK. > > > AFAIK, the CSS selector still differs so on the output side they are not > > alike. I.e. the former is "figure>img" the other is a "p>img". Aside: > If > > anything, removing the "p" tag inside the figure would make it easier to > > handle images. > > So would the following patch fix the issue? > > Regards, > > -- > Nicolas Goaziou > --94eb2c089ecca3d64a0546e33a54 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Tue, Jan 24, 2017 at 4:27 PM, Nicolas Goaziou <= mail@nicolasgoa= ziou.fr> wrote:
Hello,

Rasmus <rasmus@gmx.us> writes:
> I'm not an expert of HTML either.=C2=A0 However, the "p"= tag inside the
> "figure" is uncommon looking a bit on the example usages onl= ine.=C2=A0 Thus, I
> agree with Matt that it should probably not be there.

OK.

> AFAIK, the CSS selector still differs so on the output side they are n= ot
> alike.=C2=A0 I.e. the former is "figure>img" the other is= a "p>img".=C2=A0 Aside: If
> anything, removing the "p" tag inside the figure would make = it easier to
> handle images.

So would the following patch fix the issue?

Regards,

--
Nicolas Goaziou

--94eb2c089ecca3d64a0546e33a54-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Price Subject: Re: extra paragraph in image export? Date: Tue, 24 Jan 2017 23:04:48 -0500 Message-ID: References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> <87fuk86tdg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113ff00c78039c0546e35511 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWEpG-0000lo-LS for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 23:04:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWEpF-0004k2-Ou for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 23:04:50 -0500 Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]:35613) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWEpF-0004ju-Kg for emacs-orgmode@gnu.org; Tue, 24 Jan 2017 23:04:49 -0500 Received: by mail-io0-x229.google.com with SMTP id j18so4999858ioe.2 for ; Tue, 24 Jan 2017 20:04:49 -0800 (PST) In-Reply-To: <87fuk86tdg.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org Mode , Rasmus --001a113ff00c78039c0546e35511 Content-Type: text/plain; charset=UTF-8 On Tue, Jan 24, 2017 at 4:27 PM, Nicolas Goaziou wrote: > Hello, > > Rasmus writes: > > > I'm not an expert of HTML either. However, the "p" tag inside the > > "figure" is uncommon looking a bit on the example usages online. Thus, I > > agree with Matt that it should probably not be there. > > OK. > > > AFAIK, the CSS selector still differs so on the output side they are not > > alike. I.e. the former is "figure>img" the other is a "p>img". Aside: > If > > anything, removing the "p" tag inside the figure would make it easier to > > handle images. > > So would the following patch fix the issue? > > I'm not sure. Doesn't look like it to me -- I would instead have put: - (format "\n

%s

" contents) + (format "\n%s" contents) Because we never want the

tag inside the figure. Isn't that right? --001a113ff00c78039c0546e35511 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



On Tue, Jan 24, 2017 at 4:27 PM, Nicolas Goaziou <= mail@nicolasgoa= ziou.fr> wrote:
Hello,

Rasmus <rasmus@gmx.us> writes:
> I'm not an expert of HTML either.=C2=A0 However, the "p"= tag inside the
> "figure" is uncommon looking a bit on the example usages onl= ine.=C2=A0 Thus, I
> agree with Matt that it should probably not be there.

OK.

> AFAIK, the CSS selector still differs so on the output side they are n= ot
> alike.=C2=A0 I.e. the former is "figure>img" the other is= a "p>img".=C2=A0 Aside: If
> anything, removing the "p" tag inside the figure would make = it easier to
> handle images.

So would the following patch fix the issue?


I'm not sure. Doesn't look lik= e it to me -- I would instead have put:

-=C2=A0=C2=A0 =C2=A0=C2=A0= =C2=A0=C2=A0 (format "\n<p>%s</p>" contents)
+=C2= =A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 (format "\n%s" contents)
Because we never want the <p> tag inside the figure. Isn= 't that right?=C2=A0

--001a113ff00c78039c0546e35511-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: extra paragraph in image export? Date: Wed, 25 Jan 2017 14:13:09 +0100 Message-ID: <877f5jcmfu.fsf@nicolasgoaziou.fr> References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> <87fuk86tdg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWNO2-0006Xj-49 for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 08:13:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWNO1-0003kb-7s for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 08:13:18 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:56088) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWNO1-0003jU-2H for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 08:13:17 -0500 In-Reply-To: (Matt Price's message of "Tue, 24 Jan 2017 23:04:48 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Matt Price Cc: Org Mode , Rasmus Hello, Matt Price writes: > I'm not sure. Doesn't look like it to me -- I would instead have put: > > - (format "\n

%s

" contents) > + (format "\n%s" contents) > > Because we never want the

tag inside the figure. Isn't that right? I don't think so. When `org-html-html5-fancy' is non-nil, "ox-html.el" uses

tags to separate image and caption. Moreover, there is no

in that case, but a
. Can't this contain a

block element? Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: extra paragraph in image export? Date: Wed, 25 Jan 2017 16:01:19 +0100 Message-ID: <87o9yvb2v4.fsf@gmx.us> References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> <87fuk86tdg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWP8P-0001iU-Qu for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 10:05:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWP8L-0004Uh-U3 for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 10:05:17 -0500 Received: from [195.159.176.226] (port=45728 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWP8L-0004UP-Mr for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 10:05:13 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cWP8D-0005tF-Qs for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 16:05:05 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org > So would the following patch fix the issue? Looks fine to me. Thanks! Rasmus -- The second rule of Fight Club is: You do not talk about Fight Club From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: extra paragraph in image export? Date: Wed, 25 Jan 2017 15:59:47 +0100 Message-ID: <87sho7b2xo.fsf@gmx.us> References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> <87fuk86tdg.fsf@nicolasgoaziou.fr> <877f5jcmfu.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWP3m-0007Th-DK for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 10:00:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWP3h-0002u4-IS for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 10:00:30 -0500 Received: from [195.159.176.226] (port=35079 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWP3h-0002u0-9n for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 10:00:25 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cWP37-0008TP-42 for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 15:59:49 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi, >> I'm not sure. Doesn't look like it to me -- I would instead have put: >> >> - (format "\n

%s

" contents) >> + (format "\n%s" contents) >> >> Because we never want the

tag inside the figure. Isn't that right? > > I don't think so. When `org-html-html5-fancy' is non-nil, "ox-html.el" > uses

tags to separate image and caption. I agree that the

could be retained in the non-HTML5 case. That corresponds to the W3 example below. Note, strictly speaking I guess the non-HTML5 org html output is not necessarily "HTML4", so the example may not apply. https://www.w3.org/Style/Examples/007/figures.en.html#Illustrati > Moreover, there is no

in that case, but a
class=\"figure\">. Can't this contain a

block element? Yes. HTML5 "figure" can hold "p" as well, but it's not necessary, and it seems to be uncommon. Rasmus -- Human: An animal that complicates things more than strictly necessary From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: extra paragraph in image export? Date: Wed, 25 Jan 2017 17:59:20 +0100 Message-ID: <87y3xzaxef.fsf@nicolasgoaziou.fr> References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> <87fuk86tdg.fsf@nicolasgoaziou.fr> <87o9yvb2v4.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWQuu-0007Tk-K0 for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 11:59:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWQup-00089s-Vn for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 11:59:28 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:32775) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWQup-00089c-PE for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 11:59:23 -0500 In-Reply-To: <87o9yvb2v4.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 25 Jan 2017 16:01:19 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: emacs-orgmode@gnu.org Hello, Rasmus writes: >> So would the following patch fix the issue? > > Looks fine to me. > > Thanks! Applied. Thank you. Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Price Subject: Re: extra paragraph in image export? Date: Wed, 25 Jan 2017 13:02:58 -0500 Message-ID: References: <87lgu3b5c8.fsf@nicolasgoaziou.fr> <87sho8ztgv.fsf@gmx.us> <87fuk86tdg.fsf@nicolasgoaziou.fr> <87o9yvb2v4.fsf@gmx.us> <87y3xzaxef.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113ff00cfabaf40546ef0a11 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWRuO-00079d-Fo for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 13:03:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWRuN-0004xw-Mh for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 13:03:00 -0500 Received: from mail-io0-x233.google.com ([2607:f8b0:4001:c06::233]:35258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWRuN-0004ws-IH for emacs-orgmode@gnu.org; Wed, 25 Jan 2017 13:02:59 -0500 Received: by mail-io0-x233.google.com with SMTP id j18so19879196ioe.2 for ; Wed, 25 Jan 2017 10:02:59 -0800 (PST) In-Reply-To: <87y3xzaxef.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org Mode , Rasmus --001a113ff00cfabaf40546ef0a11 Content-Type: text/plain; charset=UTF-8 (I totally misread the patch, sorry. duh.) On Wed, Jan 25, 2017 at 11:59 AM, Nicolas Goaziou wrote: > Hello, > > Rasmus writes: > > >> So would the following patch fix the issue? > > > > Looks fine to me. > > > > Thanks! > > Applied. Thank you. > > Regards, > > -- > Nicolas Goaziou > > --001a113ff00cfabaf40546ef0a11 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

(I totally misread the patch, sorry. duh.)

On Wed, Jan 25, 2017 a= t 11:59 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wr= ote:
Hello,

Rasmus <rasmus@gmx.us> writes:
>> So would the following patch fix the issue?
>
> Looks fine to me.
>
> Thanks!

Applied. Thank you.

Regards,

--
Nicolas Goaziou


--001a113ff00cfabaf40546ef0a11--