emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Price <moptop99@gmail.com>
To: Carsten Dominik <dominik@uva.nl>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: org-fast-todo-selection window behaviour?
Date: Wed, 23 Oct 2019 14:10:33 -0400	[thread overview]
Message-ID: <CAN_Dec8nY2fJT0jC0oTMmv2L4pXR7=R=YZd87nd8bC4tC=5R4w@mail.gmail.com> (raw)
In-Reply-To: <CADn3Z2KN0RemVWOLwoNgMYmojqOPyUUX9VKxDs7Wj6uc856Ygw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

Ah well. I find the new way jarring, but it doesn't seem to bother anyone
else, and as it's a one-line (2 character!) change for me I think I can
carry the diff in my init file for now. In any case it's a small issue I
think.An honour to find myself in disagreement with the org-founder!

On Mon, Oct 21, 2019 at 5:47 AM Carsten Dominik <dominik@uva.nl> wrote:

> Hi Matt,
>
> I made this change, because I found the previous way jarring.  The window
> with the selection information showed up in different places depending on
> what the current window setup is. With the new implementation, the info
> window is always in the same predictable place.  After the selection is
> done, the old window setup is restored to exactly what it was....
>
> Carsten
>
> On Sun, Oct 20, 2019 at 8:46 PM Matt Price <moptop99@gmail.com> wrote:
>
>> I've recently noticed a slightly frustrating behavour on the part of
>> org-todo that I think is new and maybe was introduced in mid-August with
>>
>> f1c030bed54737319aeb1d592e3340d6a48cea3a
>>
>> In a split frame,calling org-todo with org-use-fast-todo-selection
>> enabled, ~C-c C-t~ now calls ~delete-other-windows~ before popping up the
>> org-todo keywords window.  Is this necessary? I find this behaviour
>> visually confusing and distracting, and a slowdown to my workflow.  Would
>> it make sense to introduce some kind of defcustom for this? For now I'm
>> just commenting out line 10614 of org.el, but if others want to be able to
>> customize the behaviour I will submit a patch.
>>
>> Maybe there's a reason delete-other-window is necessary, but i don't see
>> it in the commit message nor immediately in the other parts of this
>> otherwise very well-documented commit
>>
>> Thanks!
>>
>>

[-- Attachment #2: Type: text/html, Size: 2466 bytes --]

  reply	other threads:[~2019-10-23 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20 18:43 org-fast-todo-selection window behaviour? Matt Price
2019-10-21  9:46 ` Carsten Dominik
2019-10-23 18:10   ` Matt Price [this message]
2019-10-24  9:03     ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN_Dec8nY2fJT0jC0oTMmv2L4pXR7=R=YZd87nd8bC4tC=5R4w@mail.gmail.com' \
    --to=moptop99@gmail.com \
    --cc=dominik@uva.nl \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).