From: Xi Shen <davidshen84@gmail.com>
To: "Emacs-orgmode@gnu.org" <Emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-sql.el: Support sqlcmd and cygwin environment
Date: Sun, 12 Jun 2016 10:37:36 +0000 [thread overview]
Message-ID: <CANO68EOwu6KDkJbtSVT+u_7MK4VzsChSaq0dq0o9crKk-Fa6AA@mail.gmail.com> (raw)
In-Reply-To: <CANO68EN_USJx1qcGkXUMgPKo2ucOUxkdURy8vZKiPvJDD-2FnA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3125 bytes --]
Hi Nicolas,
So I will:
- add "org-babel-sql-convert-filename", so another name...I am thinking
- remove `msosql` support. I am been playing with the options for a while,
and I could not find a way the make osql output the same format as sqlcmd
Thanks,
David
On Sun, Jun 12, 2016 at 10:12 AM Xi Shen <davidshen84@gmail.com> wrote:
> Yes, I think it is better to let upstream function to resolve the path for
> org-mode.
>
> But I have never contacted Emacs developers before. Should I go through
> the bug-gnu-emacs@gnu.org mail list? Or there's a more effective channel?
>
>
> On Sat, Jun 11, 2016 at 4:41 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
>
>> Hello,
>>
>> Xi Shen <davidshen84@gmail.com> writes:
>>
>> > According to
>> >
>> https://www.gnu.org/software/emacs/manual/html_node/elisp/Standard-File-Names.html
>> ,
>> > the `convert-standard-filename` works for *nix and MS-DOS, but not
>> Cygwin
>> > environment. And I tested, it does not work. For the prefix, please
>> advice
>> > me a better one. Maybe we should path this function first? How can I
>> > patch/update a Emacs native function?
>>
>> Since there is no module in Emacs, you need to prefix functions and
>> variables according to the package, or, even better, the library they
>> belong to.
>>
>> Hence, functions and variables in "ob-sql.el" are prefixed with
>> "org-babel-sql-".
>>
>> Do you mind discussing it upstream on emacs-devel ML first? I don't
>> think this kind of function belongs to Org. If upstream has no
>> equivalent and doesn't want to add one, we might consider adding it to
>> the library.
>>
>> WDYT?
>>
>> >> > The `osql` command line tool was last updated in 2004,
>> >> > https://technet.microsoft.com/en-us/library/aa214012(v=sql.80).aspx,
>> >> > and could not output the query result in a way that morden
>> >> > `org-table.el` expects. The `sqlcmd` is the preferred command line
>> >> > tool to connect the Microsoft SQL Server and it also has a Linux
>> >> > version,
>> >> > https://msdn.microsoft.com/en-us/library/hh568447(v=sql.110).aspx.
>> >>
>> >> Would it make sense to remove the msosql support then?
>> >>
>> > Yes, but I am also thinking about backward compatibility. Do you want
>> > me to create a patch to remove `msosql` support?
>>
>> AFAIU, according to your comment, "osql" output is barely usable. If you
>> think it is still usable and even used by some users, then I do not mind
>> keeping it. I just wanted to be sure we're not keeping something that is
>> not reasonable to keep.
>>
>> >> #'identity
>> >>
>> >>
>> >>> OK, but what's the difference? Care to give me a short lesson?
>> >>>Thanks!
>>
>> Not much difference, hence the "nitpick" tag.
>>
>> 'identity is a generic symbol, #'identity clearly indicates we (the
>> user, the compiler) are interested in the symbol function cell.
>>
>> In this case, it is obvious, but it is not always the case in other
>> parts of the code base, and more consistency in the right direction
>> doesn't hurt.
>>
>>
>> Regards,
>>
>> --
>> Nicolas Goaziou
>>
>>
>
> Thanks,
> David
>
> --
>
> Thanks,
> David S.
>
--
Thanks,
David S.
[-- Attachment #2: Type: text/html, Size: 5193 bytes --]
next prev parent reply other threads:[~2016-06-12 10:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 10:24 [PATCH] ob-sql.el: Support sqlcmd and cygwin environment Xi Shen
2016-06-10 22:06 ` Nicolas Goaziou
2016-06-11 2:17 ` Xi Shen
2016-06-11 8:40 ` Nicolas Goaziou
2016-06-12 2:12 ` Xi Shen
2016-06-12 10:37 ` Xi Shen [this message]
2016-06-13 5:36 ` Xi Shen
2016-06-13 6:30 ` Xi Shen
2016-06-14 11:52 ` Nicolas Goaziou
2016-06-14 13:02 ` Xi Shen
2016-06-15 4:01 ` Xi Shen
2016-06-15 16:49 ` Nicolas Goaziou
2016-06-16 6:04 ` Xi Shen
2016-06-16 8:56 ` tumashu
2016-06-16 22:29 ` Nicolas Goaziou
2016-06-20 12:34 ` Xi Shen
2016-07-04 8:11 ` Xi Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANO68EOwu6KDkJbtSVT+u_7MK4VzsChSaq0dq0o9crKk-Fa6AA@mail.gmail.com \
--to=davidshen84@gmail.com \
--cc=Emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).