emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: No Wayman <iarchivedmywholelife@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: org-highest-priority not defined [9.3.6 (release_9.3.6-399-ge6df03 @ /home/n/.emacs.d/straight/build/org/)]
Date: Tue, 10 Mar 2020 13:46:53 -0400	[thread overview]
Message-ID: <CANKwjwV+wE5XA18yPHLQhc5hyoOAauOg1g5yW-BmZ9Cm21ZwEg@mail.gmail.com> (raw)
In-Reply-To: <CANKwjwVQ9gF3EKoiieetSB+SFM+sYbWsKqRNKO6k_-fkAy2Jbg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 20652 bytes --]

Proposed patch:
diff --git a/lisp/org.el b/lisp/org.el
index 31133c554..7b7e4c80a 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2383,7 +2383,7 @@ set a priority."
   :group 'org-priorities
   :type 'boolean)

-(defalias 'org-highest-priority 'org-priority-highest)
+(defvaralias 'org-highest-priority 'org-priority-highest)

 (defcustom org-priority-highest ?A
   "The highest priority of TODO items.
@@ -2394,7 +2394,7 @@ Must be smaller than `org-priority-lowest'."
          (character :tag "Character")
          (integer :tag "Integer (< 65)")))

-(defalias 'org-lowest-priority 'org-priority-lowest)
+(defvaralias 'org-lowest-priority 'org-priority-lowest)
 (defcustom org-priority-lowest ?C
   "The lowest priority of TODO items.
 A character like ?A, ?B, etc., or a numeric value like 1, 2, etc.
@@ -2404,7 +2404,7 @@ Must be higher than `org-priority-highest'."
          (character :tag "Character")
          (integer :tag "Integer (< 65)")))

-(defalias 'org-default-priority 'org-priority-default)
+(defvaralias 'org-default-priority 'org-priority-default)
 (defcustom org-priority-default ?B
   "The default priority of TODO items.
 This is the priority an item gets if no explicit priority is given.



On Sat, Feb 29, 2020 at 11:35 PM No Wayman <iarchivedmywholelife@gmail.com>
wrote:

> Actually, on closer inspection. Shouldn't:
>
> (defalias 'org-highest-priority 'org-priority-highest)
>
> be
>
> (defvaralias ...)?
>
> On Sat, Feb 29, 2020 at 8:09 PM No Wayman <iarchivedmywholelife@gmail.com>
> wrote:
>
>> After updating Org, I'm  hitting errors for an undefined
>> `org-highest-priority'.
>> I see that this is an alias for `org-priority-highest', but
>> describe-function (and I'm not sure why it's describe-function vs
>> describe-variable) dutifully reports:
>>
>>  org-highest-priority is an alias for ‘org-priority-highest’,
>>  which is not
>>  defined. Please make a bug report.
>>
>>  Not documented.
>>
>> My first hunch is that this is due to a mixed installation of Org,
>> but I'm having trouble diagnosing this. I've installed
>> org-plus-contrib using the straight package manager.
>> I've ensured that Org is not loaded before/during upgrading Org.
>> (locate-library "org") points to the correct file:
>>
>>  "/home/n/.emacs.d/straight/build/org/org.elc"
>>
>> In the src elisp file,
>> /home/n/.emacs.d/straight/repos/org/lisp/org.el there defalias is
>> there as I would expect:
>>
>> (defalias 'org-highest-priority 'org-priority-highest)
>>
>> My usual technique for debugging this is evaling:
>>
>>   (eval-after-load "org"
>>     '(debug))
>>
>> prior to loading Org. However, in this case it looks like it's
>> loading the proper file:
>>
>> Debugger entered: nil
>>   (closure (t) nil (debug))()
>>   funcall((closure (t) nil (debug)))
>>   mapc(funcall ((closure (t) nil (debug)) (closure (t) nil
>>   (add-to-list 'org-src-lang-modes '("php" . php))) (closure (t)
>>   nil (add-to-list 'org-src-lang-modes '("redis" . redis)))))
>>   do-after-load-evaluation("/home/n/.emacs.d/straight/build/org/org.elc")
>>   require(org)
>>   byte-code("\300\301!\210\300\302!\210\300\303!\207" [require
>>   cl-lib org org-refile] 2)
>>   autoload-do-load((autoload "org-capture" 1424805 t nil)
>>   org-capture)
>>   command-execute(org-capture)
>>
>> I plan on reporting with the author of straight.el, too. Just
>> following through on the describe-function message here.
>> Not sure how to proceed with debugging. Apologies if this is
>> noise.
>>
>>
>> Emacs  : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X
>> toolkit, cairo version 1.17.3, Xaw3d scroll bars)
>>  of 2020-02-23
>> Package: Org mode version 9.3.6 (release_9.3.6-399-ge6df03 @
>> /home/n/.emacs.d/straight/build/org/)
>>
>> current state:
>> ==============
>> (setq
>>  org-src-mode-hook '(org-src-babel-configure-edit-buffer
>>  org-src-mode-configure-edit-buffer
>>                      doom-modeline-set-org-src-modeline)
>>  org-link-shell-confirm-function 'yes-or-no-p
>>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>>  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
>>  org-refile-targets '((org-agenda-files :maxlevel . 20)
>>  (my/org-files-list :maxlevel . 20))
>>  org-enforce-todo-dependencies t
>>  org-agenda-category-icon-alist '(("[Ww]ork"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Rr]efile"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Aa]ccounting"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Hh]abit"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Hh]ealth"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Ii]n"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Oo]ut"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Ll]isten"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Pp]lay"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Rr]ead"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Ww]atch"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   ("[Cc]alendar"
>>                                    (#("" 0 1
>>                                       (rear-nonsticky t display
>>                                       (raise -0.24) font-lock-face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2) face
>>                                        (:family "FontAwesome"
>>                                        :height 1.2))
>>                                       )
>>                                     )
>>                                    nil nil :ascent center)
>>                                   )
>>  org-agenda-files '("~/Documents/todo")
>>  org-reveal-start-hook '(org-decrypt-entry)
>>  org-modules '(org-habit)
>>  org-blocker-hook
>>  '(org-block-todo-from-children-or-siblings-or-parent)
>>  org-mode-hook '(org-indent-mode
>>                  (closure (t) nil (add-hook 'after-save-hook
>>                  'my/org-agenda-redo-all nil t)
>>                   (setq prettify-symbols-unprettify-at-point
>>                   'right-edge)
>>                   (setq prettify-symbols-alist
>>                    '(("#+begin_src" . "λ") ("#+BEGIN_SRC" . "λ")
>>                    ("#+end_src" . "λ")
>>                      ("#+END_SRC" . "λ") (":PROPERTIES:" . "⚙")
>>                      (":properties:" . "⚙")
>>                      (":END:" . "∎") ("#+RESULTS:" . "→"))
>>                    )
>>                   (prettify-symbols-mode 1))
>>                  org-bullets-mode org-better-repeat-mode
>>                  #[0 "\300\301\302\303\304$\207"
>>                    [add-hook change-major-mode-hook org-show-all
>>                    append local] 5]
>>                  #[0 "\300\301\302\303\304$\207"
>>                    [add-hook change-major-mode-hook
>>                    org-babel-show-result-all append local]
>>                    5]
>>                  org-babel-result-hide-spec
>>                  org-babel-hide-all-hashes writegood-mode
>>                  org-journal-update-auto-mode-alist flyspell-mode
>>                  org-eldoc-load)
>>  org-outline-path-complete-in-steps nil
>>  org-archive-hook '(org-attach-archive-delete-maybe)
>>  org-journal-carryover-items nil
>>  org-confirm-elisp-link-function 'yes-or-no-p
>>  org-reverse-note-order t
>>  org-journal-mode-hook '(#[0 "\301 \302\303\304$\207"
>>                            [org-journal-encrypt-on add-hook
>>                            org-journal-encryption-hook nil
>>                             t]
>>                            5]
>>                          (lambda nil
>>                           (add-hook org-journal-encrypt-on
>>                           'org-journal-encryption-hook nil
>>                            t)
>>                           )
>>                          )
>>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>>  org-metaup-hook '(org-babel-load-in-session-maybe)
>>  org-log-reschedule t
>>  org-agenda-text-search-extra-files '(agenda-archives)
>>  org-babel-pre-tangle-hook '(save-buffer)
>>  org-file-apps '((auto-mode . emacs) ("\\.mm\\'" . default)
>>                  ("\\.mp[[:digit:]]\\'" . "/usr/bin/mpv
>>                  --force-window=yes %s")
>>                  ("\\.x?html?\\'" . "/usr/bin/bash -c '$BROWSER
>>                  %s'")
>>                  ("\\.pdf\\'" . default))
>>  org-tab-first-hook '(org-babel-hide-result-toggle-maybe
>>  org-babel-header-arg-expand)
>>  org-log-done 'time
>>  org-journal-date-format "[%Y-%m-%d %a]"
>>  org-hide-emphasis-markers t
>>  org-ellipsis "▿"
>>  org-habit-following-days 1
>>  org-agenda-span 'day
>>  org-agenda-loop-over-headlines-in-active-region nil
>>  org-src-lang-modes '(("arduino" . arduino) ("redis" . redis)
>>  ("php" . php) ("C" . c)
>>                       ("C++" . c++) ("asymptote" . asy) ("bash" .
>>                       sh) ("beamer" . latex)
>>                       ("calc" . fundamental) ("cpp" . c++)
>>                       ("ditaa" . artist)
>>                       ("dot" . fundamental) ("elisp" . emacs-lisp)
>>                       ("ocaml" . tuareg)
>>                       ("screen" . shell-script) ("shell" . sh)
>>                       ("sqlite" . sql))
>>  org-src-preserve-indentation t
>>  org-habit-today-glyph 128197
>>  org-catch-invisible-edits 'show-and-error
>>  org-habit-show-habits-only-for-today nil
>>  org-occur-hook '(org-first-headline-recenter)
>>  org-agenda-mode-hook '(org-journal-update-org-agenda-files)
>>  org-structure-template-alist '(("sj" . "src javascript") ("ss" .
>>  "src shell")
>>                                 ("se" . "src emacs-lisp") ("a" .
>>                                 "export ascii")
>>                                 ("c" . "center") ("C" . "comment")
>>                                 ("e" . "example")
>>                                 ("E" . "export") ("h" . "export
>>                                 html")
>>                                 ("l" . "export latex") ("q" .
>>                                 "quote") ("s" . "src")
>>                                 ("v" . "verse"))
>>  org-cycle-hook '(org-cycle-hide-archived-subtrees
>>  org-cycle-show-empty-lines
>>                   org-optimize-window-after-visibility-change)
>>  org-todo-keywords '((sequence "TODO(t)" "STARTED(s!)" "NEXT(n!)"
>>  "BLOCKED(b@/!)" "|"
>>                       "DONE(d)")
>>                      (sequence "IDEA(i)" "|" "CANCELED(c@/!)"
>>                      "DELEGATED(D@/!)")
>>                      (sequence "RESEARCH(r)" "|"))
>>  org-speed-command-hook '(org-speed-command-activate
>>  org-babel-speed-command-activate)
>>  org-better-repeat-mode t
>>  org-hierarchical-todo-statistics nil
>>  org-M-RET-may-split-line nil
>>  org-agenda-use-tag-inheritance nil
>>  org-journal-dir "~/Documents/journal"
>>  org-return-follows-link t
>>  org-refile-allow-creating-parent-nodes 'confirm
>>  org-refile-use-outline-path 'file
>>  org-export-before-parsing-hook '(org-attach-expand-links)
>>  org-confirm-shell-link-function 'yes-or-no-p
>>  org-link-parameters '(("attachment" :follow org-attach-follow
>>  :complete
>>                         org-attach-complete-link)
>>                        ("id" :follow org-id-open)
>>                        ("region" :follow org-region-open :export
>>                        nil :store
>>                         org-region-store-link)
>>                        ("mu4e" :follow mu4e-org-open :store
>>                        mu4e-org-store-link)
>>                        ("elfeed" :follow elfeed-link-open :store
>>                        elfeed-link-store-link)
>>                        ("file+sys") ("file+emacs") ("shell"
>>                        :follow org-link--open-shell)
>>                        ("news" :follow
>>                         #[514 "\301\300\302.Q.\"\207" ["news"
>>                         browse-url ":"] 6
>>                           "\n\n(fn URL ARG)"]
>>                         )
>>                        ("mailto" :follow
>>                         #[514 "\301\300\302.Q.\"\207" ["mailto"
>>                         browse-url ":"] 6
>>                           "\n\n(fn URL ARG)"]
>>                         )
>>                        ("https" :follow
>>                         #[514 "\301\300\302.Q.\"\207" ["https"
>>                         browse-url ":"] 6
>>                           "\n\n(fn URL ARG)"]
>>                         )
>>                        ("http" :follow
>>                         #[514 "\301\300\302.Q.\"\207" ["http"
>>                         browse-url ":"] 6
>>                           "\n\n(fn URL ARG)"]
>>                         )
>>                        ("ftp" :follow
>>                         #[514 "\301\300\302.Q.\"\207" ["ftp"
>>                         browse-url ":"] 6
>>                           "\n\n(fn URL ARG)"]
>>                         )
>>                        ("help" :follow org-link--open-help)
>>                        ("file" :complete org-link-complete-file)
>>                        ("elisp" :follow org-link--open-elisp)
>>                        ("doi" :follow org-link--open-doi))
>>  org-bullets-bullet-list '("◇")
>>  org-link-elisp-confirm-function 'yes-or-no-p
>>  org-habit-completed-glyph 10003
>>  org-journal-time-format "%I:%M %p\njrn"
>>  org-journal-hook '(flyspell-mode)
>>  org-habit-preceding-days 29
>>  org-journal-file-format "%Y.%m.%d.%A.org"
>>  org-src-window-setup 'current-window
>>  org-confirm-babel-evaluate nil
>>  org-agenda-clockreport-parameter-plist '(:link t :maxlevel 2
>>  :stepskip0 t :fileskip0 t)
>>  org-link-from-user-regexp "\\<n@arch\\>"
>>  org-agenda-sorting-strategy '((agenda time-up priority-down
>>  category-keep)
>>                                (todo priority-down category-keep)
>>                                (tags priority-down category-keep)
>>                                (search category-keep))
>>  org-agenda-inhibit-startup t
>>  )
>>
>

[-- Attachment #1.2: Type: text/html, Size: 27990 bytes --]

[-- Attachment #2: 0001-Use-defvaralias-for-prioirity-variable-aliases.patch --]
[-- Type: text/x-patch, Size: 1500 bytes --]

From a8a6d1c15db3c2bdd7083257671dad9122821269 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Tue, 10 Mar 2020 13:43:28 -0400
Subject: [PATCH] Use defvaralias for prioirity variable aliases

---
 lisp/org.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 31133c554..7b7e4c80a 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2383,7 +2383,7 @@ set a priority."
   :group 'org-priorities
   :type 'boolean)
 
-(defalias 'org-highest-priority 'org-priority-highest)
+(defvaralias 'org-highest-priority 'org-priority-highest)
 
 (defcustom org-priority-highest ?A
   "The highest priority of TODO items.
@@ -2394,7 +2394,7 @@ Must be smaller than `org-priority-lowest'."
 	  (character :tag "Character")
 	  (integer :tag "Integer (< 65)")))
 
-(defalias 'org-lowest-priority 'org-priority-lowest)
+(defvaralias 'org-lowest-priority 'org-priority-lowest)
 (defcustom org-priority-lowest ?C
   "The lowest priority of TODO items.
 A character like ?A, ?B, etc., or a numeric value like 1, 2, etc.
@@ -2404,7 +2404,7 @@ Must be higher than `org-priority-highest'."
 	  (character :tag "Character")
 	  (integer :tag "Integer (< 65)")))
 
-(defalias 'org-default-priority 'org-priority-default)
+(defvaralias 'org-default-priority 'org-priority-default)
 (defcustom org-priority-default ?B
   "The default priority of TODO items.
 This is the priority an item gets if no explicit priority is given.
-- 
2.25.1


  reply	other threads:[~2020-03-10 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-01  1:09 Bug: org-highest-priority not defined [9.3.6 (release_9.3.6-399-ge6df03 @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2020-03-01  4:35 ` No Wayman
2020-03-10 17:46   ` No Wayman [this message]
2020-03-24  3:50     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANKwjwV+wE5XA18yPHLQhc5hyoOAauOg1g5yW-BmZ9Cm21ZwEg@mail.gmail.com \
    --to=iarchivedmywholelife@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).