From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bradd Subject: Re: org-depend: TRIGGER XYZ(KEYWORD) not working Date: Sun, 3 Dec 2017 21:42:00 -0500 Message-ID: References: <2017-11-19T10-47-05@devnull.Karl-Voit.at> <2017-12-03T18-47-08@devnull.Karl-Voit.at> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e082ec7d4a758e6055f7aa973" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLghn-0007lH-P6 for emacs-orgmode@gnu.org; Sun, 03 Dec 2017 21:42:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLghm-00024v-LE for emacs-orgmode@gnu.org; Sun, 03 Dec 2017 21:42:03 -0500 Received: from mail-pf0-x236.google.com ([2607:f8b0:400e:c00::236]:33376) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLghm-00024F-Cp for emacs-orgmode@gnu.org; Sun, 03 Dec 2017 21:42:02 -0500 Received: by mail-pf0-x236.google.com with SMTP id y89so7456563pfk.0 for ; Sun, 03 Dec 2017 18:42:01 -0800 (PST) In-Reply-To: <2017-12-03T18-47-08@devnull.Karl-Voit.at> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Karl Voit Cc: emacs-orgmode --089e082ec7d4a758e6055f7aa973 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Karl, > Examples: > > * Top-Heading > > ** TODO Here I invoke org-todo to DONE > :PROPERTIES: > :TRIGGER: 2017-12-03-target(TODO) > :END: > > ** This should be changed to TODO > :PROPERTIES: > :ID: 2017-12-03-target > :END: > > ... this is working (i.e., "This should be changed to TODO" gets its > TODO keyword). > > * Top-Heading with process indicator [0/2] > > ** TODO Here I invoke org-todo to DONE > :PROPERTIES: > :TRIGGER: 2017-12-03-target(TODO) > :END: > > ** This should be changed to TODO > :PROPERTIES: > :ID: 2017-12-03-target > :END: > > ... this is *not* working. > > However, anticipating the wrong position: > > * Top-Heading with process indicator [0/2] > :PROPERTIES: > :TRIGGER: 2017-12-03-target(TODO) > :END: > > ** TODO Here I invoke org-todo to DONE > :PROPERTIES: > :TRIGGER: 2017-12-03-target(TODO) > :END: > > ** This should be changed to TODO > :PROPERTIES: > :ID: 2017-12-03-target > :END: > > ... is working. And according to this: > > * Top-Heading with process indicator [0/2] > :PROPERTIES: > :TRIGGER: 2017-12-03-target(TODO) > :END: > > ** TODO Here I invoke org-todo to DONE > > ** This should be changed to TODO > :PROPERTIES: > :ID: 2017-12-03-target > :END: > > ... this is also working. So the update of the process indicator > causes the wrong property drawer to be parsed for the relevant > TRIGGER property. > > Contrary to my previous assumption, this is issue is *not* related > to big and small files. This is purely related to the existing or > missing process indicator of the upper-level heading. > > I guess I have found the origin of the bug. =E2=80=8BI'm not able to reproduce what you are seeing above.=E2=80=8B Even= instances with a progress indicator correctly triggered if the TRIGGER property was set. Your final example updates the "Here I invoke org-todo to DONE" entry to DONE and doesn't touch any other heading for me. I did see an issue with triggered headings not honouring note logging when the todo was set to DONE, but I haven't looked any closer at it just yet. What version of org-mode are you running? If you are using the git version can you pull the latest on maint. I performed my testing on maint. > Can you please do me the favor and fix it for me. I feel extraordinary proud of me having dig into elisp (which I don't know > how to code mostly) and found the bug ;-) > > However, I can't fix it on my own :-( > =E2=80=8BEven just being able to dig through some code and debug can be a m= ajor benefit. :-) > Why did nobody tell me about org-edna yet? ;-) > =E2=80=8BI found out on the mailing list as well. Doubt I would have even s= tumbled upon it otherwise. =E2=80=8B Cheers, Adrian --089e082ec7d4a758e6055f7aa973 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi = Karl,
=C2= =A0
Examples:

=C2=A0 =C2=A0 =C2=A0* Top-Heading

=C2=A0 =C2=A0 =C2=A0** TODO Here I invoke org-todo to DONE
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:TRIGGER: 2017-12-03-target(TODO)
=C2=A0 =C2=A0 =C2=A0:END:

=C2=A0 =C2=A0 =C2=A0** This should be changed to TODO
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:ID: 2017-12-03-target
=C2=A0 =C2=A0 =C2=A0:END:

... this is working (i.e., "This should be changed to TODO" gets = its
TODO keyword).

=C2=A0 =C2=A0 =C2=A0* Top-Heading with process indicator [0/2]

=C2=A0 =C2=A0 =C2=A0** TODO Here I invoke org-todo to DONE
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:TRIGGER: 2017-12-03-target(TODO)
=C2=A0 =C2=A0 =C2=A0:END:

=C2=A0 =C2=A0 =C2=A0** This should be changed to TODO
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:ID: 2017-12-03-target
=C2=A0 =C2=A0 =C2=A0:END:

... this is *not* working.

However, anticipating the wrong position:

=C2=A0 =C2=A0 =C2=A0* Top-Heading with process indicator [0/2]
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:TRIGGER: 2017-12-03-target(TODO)
=C2=A0 =C2=A0 =C2=A0:END:

=C2=A0 =C2=A0 =C2=A0** TODO Here I invoke org-todo to DONE
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:TRIGGER: 2017-12-03-target(TODO)
=C2=A0 =C2=A0 =C2=A0:END:

=C2=A0 =C2=A0 =C2=A0** This should be changed to TODO
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:ID: 2017-12-03-target
=C2=A0 =C2=A0 =C2=A0:END:

... is working. And according to this:

=C2=A0 =C2=A0 =C2=A0* Top-Heading with process indicator [0/2]
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:TRIGGER: 2017-12-03-target(TODO)
=C2=A0 =C2=A0 =C2=A0:END:

=C2=A0 =C2=A0 =C2=A0** TODO Here I invoke org-todo to DONE

=C2=A0 =C2=A0 =C2=A0** This should be changed to TODO
=C2=A0 =C2=A0 =C2=A0:PROPERTIES:
=C2=A0 =C2=A0 =C2=A0:ID: 2017-12-03-target
=C2=A0 =C2=A0 =C2=A0:END:

... this is also working. So the update of the process indicator
causes the wrong property drawer to be parsed for the relevant
TRIGGER property.

Contrary to my previous assumption, this is issue is *not* related
to big and small files. This is purely related to the existing or
missing process indicator of the upper-level heading.

I guess I have found the origin of the bug.

=E2=80=8BI'm not abl= e to reproduce what you are seeing above.=E2=80=8B Even instances with a pr= ogress indicator correctly triggered if the TRIGGER property was set. Your = final example updates the "Here I invoke org-todo to DONE" entry = to DONE and doesn't touch any other heading for me.

I did see an issue with triggered headings n= ot honouring note logging when the todo was set to DONE, but I haven't = looked any closer at it just yet.

What version of org-mode are you running? If you are using the g= it version can you pull the latest on maint. I performed my testing on main= t.
=C2=A0
= Can you please do me the favor and fix it for me. I feel
extraordinary proud of me having dig into elisp (which I don't know
how to code mostly) and found the bug ;-)

However, I can't fix it on my own :-(

=E2=80=8BEven just bei= ng able to dig through some code and debug can be a major benefit. :-)
=C2=A0
Why did= nobody tell me about org-edna yet? ;-)

=E2=80=8BI found out on = the mailing list as well. Doubt I would have even stumbled upon it otherwis= e.
=E2=80=8B
Cheers,

Adrian

--089e082ec7d4a758e6055f7aa973--