From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bradd Subject: BUG: TODO statistics in parent heading prevent evaluation of TODOs with TRIGGER property Date: Sun, 10 Dec 2017 16:25:35 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="089e082ec7d40113cf0560030fc2" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eO96R-0004ye-M2 for emacs-orgmode@gnu.org; Sun, 10 Dec 2017 16:25:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eO96Q-0005gC-Qw for emacs-orgmode@gnu.org; Sun, 10 Dec 2017 16:25:39 -0500 Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:35866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eO96Q-0005ek-Gl for emacs-orgmode@gnu.org; Sun, 10 Dec 2017 16:25:38 -0500 Received: by mail-pf0-x231.google.com with SMTP id p84so10075740pfd.3 for ; Sun, 10 Dec 2017 13:25:37 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode --089e082ec7d40113cf0560030fc2 Content-Type: multipart/alternative; boundary="089e082ec7d40113cc0560030fc0" --089e082ec7d40113cc0560030fc0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Please see the patch attached. When completing a TODO with a TRIGGER property that has statistics in the parent headline the trigger would not evaluate because the :position property in `change-plist' may now refer to the line above the original TODO. I have used a marker to avoid the issue with the point moving due to the addition of characters =E2=80=8B in the parent headline=E2=80=8B . Not sure if this is the best way to solve the problem. Cheers, Adrian --089e082ec7d40113cc0560030fc0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,=

Please see the patch att= ached.

When completing a = TODO with a TRIGGER property that has statistics in the parent headline the= trigger would not evaluate because the :position property in `change-plist= ' may now refer to the line above the original TODO.

I have us= ed a marker to avoid the issue with the point moving due to the addition of= characters
=E2=80=8B in the parent headline=E2=80=8B
. Not sure if this is = the best way to solve the problem.

Cheers,
Adrian





--089e082ec7d40113cc0560030fc0-- --089e082ec7d40113cf0560030fc2 Content-Type: application/octet-stream; name="0001-lisp-org.el-Use-marker-for-change-plist-position-pro.patch" Content-Disposition: attachment; filename="0001-lisp-org.el-Use-marker-for-change-plist-position-pro.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jb19wfx20 RnJvbSBmYzhhNDdjYzZlYjk4ZTMxMmM1OTRiYjI5ODM0YzExOWZkYTEzNjFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZHJpYW4gQnJhZGQgPGFkcmlhbi5icmFkZEBnbWFpbC5jb20+ CkRhdGU6IFN1biwgMTAgRGVjIDIwMTcgMTY6MDc6NTcgLTA1MDAKU3ViamVjdDogW1BBVENIXSBs aXNwL29yZy5lbDogVXNlIG1hcmtlciBmb3IgYGNoYW5nZS1wbGlzdCcgcG9zaXRpb24gcHJvcGVy dHkKCiogb3JnLmVsIChvcmctdG9kbyk6IFVzZSBtYXJrZXIgYGNoYW5nZS1wbGlzdCcgcG9zaXRp b24gcHJvcGVydHkgdG8KICBwZXJtaXQgdHJpZ2dlcmluZyB0aHJvdWdoIG9yZy1kZXBlbmQuZWwg d2l0aCBwYXJlbnQgaGVhZGluZwogIHN0YXRpc3RpY3MKCldoZW4gdG9kbyBzdGF0aXN0aWNzIGlu IHBhcmVudCBoZWFkaW5ncyB3ZXJlIHVwZGF0ZWQgaXQgc2hpZnRlZCB0aGUgcG9pbnQKZGVmaW5p bmcgdGhlIDpwb3NpdGlvbiBwcm9wZXJ0eSBpbiBgY2hhbmdlLXBsaXN0JyBjYXVzaW5nIGhlYWRs aW5lcwp3aXRoIFRSSUdHRVIgcHJvcGVydGllcyB0byBmYWlsIHRvIGV2YWx1YXRlLgoKVElOWUNI QU5HRQotLS0KIGxpc3Avb3JnLmVsIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL29yZy5lbCBiL2xpc3Avb3Jn LmVsCmluZGV4IDRiNGNlNDAuLjAzZGU1YWIgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLmVsCisrKyBi L2xpc3Avb3JnLmVsCkBAIC0xMjM3OSw2ICsxMjM3OSw3IEBAIFdoZW4gY2FsbGVkIHRocm91Z2gg RUxpc3AsIGFyZyBpcyBhbHNvIGludGVycHJldGVkIGluIHRoZSBmb2xsb3dpbmcgd2F5OgogCSAg ICAgIChsb29raW5nLWF0ICJcXCg/OiAqXFx8WyBcdF0qJFxcKSIpKQogCSAgKGxldCogKChtYXRj aC1kYXRhIChtYXRjaC1kYXRhKSkKIAkJIChzdGFydHBvcyAocG9pbnQtYXQtYm9sKSkKKwkJIChz dGFydG1hcmsgKG1hcmstbWFya2VyKSkKIAkJIChsb2dnaW5nIChzYXZlLW1hdGNoLWRhdGEgKG9y Zy1lbnRyeS1nZXQgbmlsICJMT0dHSU5HIiB0IHQpKSkKIAkJIChvcmctbG9nLWRvbmUgb3JnLWxv Zy1kb25lKQogCQkgKG9yZy1sb2ctcmVwZWF0IG9yZy1sb2ctcmVwZWF0KQpAQCAtMTI0NjEsNyAr MTI0NjIsNyBAQCBXaGVuIGNhbGxlZCB0aHJvdWdoIEVMaXNwLCBhcmcgaXMgYWxzbyBpbnRlcnBy ZXRlZCBpbiB0aGUgZm9sbG93aW5nIHdheToKIAkJCSAgICAgb3JnLXN0YXRlKSkKIAkJIChuZXh0 IChpZiBvcmctc3RhdGUgKGNvbmNhdCAiICIgb3JnLXN0YXRlICIgIikgIiAiKSkKIAkJIChjaGFu Z2UtcGxpc3QgKGxpc3QgOnR5cGUgJ3RvZG8tc3RhdGUtY2hhbmdlIDpmcm9tIHRoaXMgOnRvIG9y Zy1zdGF0ZQotCQkJCSAgICAgOnBvc2l0aW9uIHN0YXJ0cG9zKSkKKwkJCQkgICAgIDpwb3NpdGlv biAoc2V0LW1hcmtlciBzdGFydG1hcmsgc3RhcnRwb3MpKSkKIAkJIGRvbG9nIG5vdy1kb25lLXAp CiAJICAgICh3aGVuIG9yZy1ibG9ja2VyLWhvb2sKIAkgICAgICAobGV0IChvcmctYmxvY2tlZC1i eS1jaGVja2JveGVzIGJsb2NrLXJlYXNvbikKLS0gCjIuMTAuMSAoQXBwbGUgR2l0LTc4KQoK --089e082ec7d40113cf0560030fc2--