emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Miro Bezjak <bezjak.miro@gmail.com>
To: Sylvain Rousseau <thisirs@gmail.com>
Cc: Bastien <bzg@altern.org>, emacs-orgmode@gnu.org
Subject: Re: org-insert-link with HTML title as default description
Date: Sat, 29 Sep 2012 20:43:12 +0200	[thread overview]
Message-ID: <CAMJqDfPEJoLXq00tyud8vGz22kvVGRCkLN7mfCa4djAxEhEOOA@mail.gmail.com> (raw)
In-Reply-To: <CAJ8n830FbuEWrv=xSBsaO3Fx1ZxAhKwNrsSf=_hABLBOfFyd8Q@mail.gmail.com>

Hi Sylvain, Bastien,

I have indeed noticed `org-make-link-description-function'. Though,
from its documentation I've somehow concluded that it makes the final
(and not default) description. By rereading documentation and source
code for `org-insert-link', it appears that with addition of Sylvain's
patch I could indeed use `org-make-link-description-function' and not
wrap around `org-insert-link'.

Cheers,
Miro

P.S. I'm sending SSH public key in a separate mail.

On Sat, Sep 29, 2012 at 5:09 PM, Sylvain Rousseau <thisirs@gmail.com> wrote:
> Hi Miro and Bastien,
>
> This can be done by setting the function
> `org-make-link-description-function'. However when set, the function
> is supposed to handle all type of links and return a string no matter
> what. There is no fallback mechanism. Here is a patch that fixes it:
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index bdb85de..3630623 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9527,10 +9527,12 @@ Use TAB to complete link prefixes, then RET for type-spe
>             (setq desc path))))
>
>      (if org-make-link-description-function
> -       (setq desc (funcall org-make-link-description-function link desc))
> -      (if default-description (setq desc default-description)
> -       (setq desc (or (and auto-desc desc)
> -                      (read-string "Description: " desc)))))
> +       (setq desc (or (funcall org-make-link-description-function link desc)
> +                      desc)))
> +
> +    (if default-description (setq desc default-description)
> +      (setq desc (or (and auto-desc desc)
> +                    (read-string "Description: " desc))))
>
>      (unless (string-match "\\S-" desc) (setq desc nil))
>      (if remove (apply 'delete-region remove))
>
>
> For example my `org-make-link-description-function' is:
>
>     (setq org-link-to-description
>           '(("\\`file:.*/\\([^/:]+\\)\\(::.*\\)" . "\\1")
>             ("\\`file:.*/\\([^/:]+\\)" . "\\1")))
>
>     (setq org-make-link-description-function
>           (lambda (link description)
>             (let ((found (assoc-default link org-link-to-description
> 'string-match)))
>               (cond
>                ((stringp found) (match-substitute-replacement found t
> nil link))))))
>
>
> HTH,
>
> Sylvain.

next prev parent reply	other threads:[~2012-09-29 18:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-29 12:23 org-insert-link with HTML title as default description Miro Bezjak
2012-09-29 14:42 ` Bastien
2012-09-29 15:09   ` Sylvain Rousseau
2012-09-29 18:43     ` Miro Bezjak [this message]
2012-09-29 20:53     ` Bastien
2012-09-29 23:00       ` Sylvain Rousseau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMJqDfPEJoLXq00tyud8vGz22kvVGRCkLN7mfCa4djAxEhEOOA@mail.gmail.com \
    --to=bezjak.miro@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=thisirs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).