From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miro Bezjak <bezjak.miro@gmail.com>
Subject: Re: Bug (regression) in org-replace-disputed-keys. Bisected.
Date: Fri, 14 Nov 2014 23:29:43 +0100
Message-ID: <CAMJqDfP0GD0MTZLDrxrFwQDO-9b+UvPzHMUuRB_HpZdVsvtRug@mail.gmail.com>
References: <20140909.204231.1213619806378148264.teika@gmx.com>
	<20141001.102227.1578863029392514259.teika@gmx.com>
	<87fve0c8dp.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bezjak.miro@gmail.com>) id 1XpPNq-00051I-9K
	for emacs-orgmode@gnu.org; Fri, 14 Nov 2014 17:30:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bezjak.miro@gmail.com>) id 1XpPNo-0003aq-Tc
	for emacs-orgmode@gnu.org; Fri, 14 Nov 2014 17:30:26 -0500
Received: from mail-vc0-x22d.google.com ([2607:f8b0:400c:c03::22d]:63744)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bezjak.miro@gmail.com>) id 1XpPNo-0003ag-Pk
	for emacs-orgmode@gnu.org; Fri, 14 Nov 2014 17:30:24 -0500
Received: by mail-vc0-f173.google.com with SMTP id id10so5026476vcb.18
	for <emacs-orgmode@gnu.org>; Fri, 14 Nov 2014 14:30:24 -0800 (PST)
In-Reply-To: <87fve0c8dp.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Teika Kazura <teika@gmx.com>, emacs-orgmode@gnu.org, me <bezjak.miro@gmail.com>

Hi all,

I rather like that `org-read-date` takes over windmove keys during the
second or two that I'm using it. By reverting this, I guess I'll have
to copy and paste the whole `defvar` just to add
`(org-replace-disputed-keys nil)`.

May I make a compromise here? Can we make a new defcustom
(org-disable-disputed-keys-during-read-date?) that will disable
`org-replace-disputed-keys` when setting up
`org-read-date-minibuffer-local-map`?

Regards,
Miro


On Mon, Nov 3, 2014 at 9:54 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Teika Kazura <teika@gmx.com> writes:
>
>> Now a real fix. There're two candidates:
>>
>> (i) Revert the wrong commit. Since it was in fact done in two separate commits[2], you need another patch, not git-revert. Here it is:
>> ------------------------------------------------------------------------
>> diff -u -r org-8.2.7c-orig/lisp/org.el org-8.2.7c/lisp/org.el
>> --- org-8.2.7c-orig/lisp/org.el       2014-09-30 18:10:54.485977061 +0900
>> +++ org-8.2.7c/lisp/org.el    2014-09-30 18:11:24.293602328 +0900
>> @@ -16220,8 +16220,7 @@
>>  (defvar org-read-date-inactive)
>>
>>  (defvar org-read-date-minibuffer-local-map
>> -  (let* ((org-replace-disputed-keys nil)
>> -      (map (make-sparse-keymap)))
>> +  (let* ((map (make-sparse-keymap)))
>>      (set-keymap-parent map minibuffer-local-map)
>>      (org-defkey map (kbd ".")
>>                  (lambda () (interactive)
>> ------------------------------------------------------------------------
>
> I think this change is appropriate. Could you provide a patch with git
> format-patch?
>
>
> Regards,
>
> --
> Nicolas Goaziou