From mboxrd@z Thu Jan 1 00:00:00 1970 From: Le Wang Subject: Re: bug#12905: 24.2.50; org: edit source block causes data loss Date: Fri, 14 Dec 2012 00:06:34 +0800 Message-ID: References: <50A62865.8010904@gmail.com> <87sj7han8a.fsf__16482.9143243425$1354894646$gmane$org@gnu.org> <87wqwnyzud.fsf__32428.3239235685$1355331429$gmane$org@bzg.ath.cx> <87bodzt201.fsf@norang.ca> <877gom7tc3.fsf@bzg.ath.cx> <876246skbt.fsf@norang.ca> <87lid262rf.fsf@norang.ca> <8738za44ss.fsf@bzg.ath.cx> <878v925aru.fsf@norang.ca> <87wqwm0yoi.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b86eab868b78304d0be1944 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:54855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjBJ6-0000rd-7X for emacs-orgmode@gnu.org; Thu, 13 Dec 2012 11:06:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjBIy-0004z9-DJ for emacs-orgmode@gnu.org; Thu, 13 Dec 2012 11:06:44 -0500 Received: from mail-vb0-f41.google.com ([209.85.212.41]:34023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjBIy-0004xy-7J for emacs-orgmode@gnu.org; Thu, 13 Dec 2012 11:06:36 -0500 Received: by mail-vb0-f41.google.com with SMTP id l22so2534663vbn.0 for ; Thu, 13 Dec 2012 08:06:35 -0800 (PST) In-Reply-To: <87wqwm0yoi.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Bernt Hansen , emacs-orgmode@gnu.org --047d7b86eab868b78304d0be1944 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Dec 13, 2012 at 11:17 PM, Bastien wrote: > Hi Le, > > No we don't. If anyone knows how to set this up for our needs, > please share. I've only done this for projects hosted on github, others may have more experience. But having a continuous integration service is definitely helpful. For example, there were 10 failures when I ran tests against master just now: 10 unexpected results: FAILED ob-exp/exports-inline FAILED ob-exp/noweb-strip-export-ensure-strips FAILED test-ob/org-babel-remove-result--results-default FAILED test-ob/org-babel-results-indented-wrap FAILED test-org-babel/combining-scalar-and-raw-result-types FAILED test-org-babel/inline-src-blocks FAILED test-org-babel/inline-src_blk-default-results-replace-line-1 FAILED test-org-babel/just-one-results-block FAILED test-org-babel/nested-code-block FAILED test-org-babel/partial-nested-code-block I haven't investigated further though. > Whatever works -- we first need to make sure this fixes it and try > to understand why ;) I can confirm that copy-marker does not work as I've used it on Emacs 23.3.1. > Thanks for taking care of this, You're welcome. I've attached 3 patches to fix this and another bug I found while writing tests. -- Le --047d7b86eab868b78304d0be1944 Content-Type: application/octet-stream; name="0001-don-t-use-copy-marker-nil-t-for-Emacs-23-compat.patch" Content-Disposition: attachment; filename="0001-don-t-use-copy-marker-nil-t-for-Emacs-23-compat.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hao2rd0b0 RnJvbSA1YjNlNjI4YjNiYzhhZmQwYzA4MmZhZWYwNTkxMjZiMzBkMTc0ZDI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZSBXYW5nIDxsZS53YW5nQGFnd29ybGQuY29tLmF1PgpEYXRl OiBUaHUsIDEzIERlYyAyMDEyIDIzOjQwOjU5ICswODAwClN1YmplY3Q6IFtQQVRDSCAxLzNdIGRv bid0IHVzZSAoY29weS1tYXJrZXIgbmlsIHQpIGZvciBFbWFjcyAyMyBjb21wYXQKCi0tLQogbGlz cC9vcmctc3JjLmVsIHwgNCArKystCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vcmctc3JjLmVsIGIvbGlzcC9vcmctc3Jj LmVsCmluZGV4IGY5MWRhMTkuLjY1MTU5ODcgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLXNyYy5lbAor KysgYi9saXNwL29yZy1zcmMuZWwKQEAgLTIzMCw3ICsyMzAsOSBAQCBidWZmZXIuIgogCSAoYmVn IChtYWtlLW1hcmtlcikpCiAJIDs7IE1vdmUgbWFya2VyIHdpdGggaW5zZXJ0ZWQgdGV4dCBmb3Ig Y2FzZSB3aGVuIHNyYyBibG9jayBpcwogCSA7OyBqdXN0IG9uZSBlbXB0eSBsaW5lLCBpLmUuIGJl ZyA9PSBlbmQuCi0JIChlbmQgKGNvcHktbWFya2VyIG5pbCB0KSkKKwkgKGVuZCAobGV0ICgobWFy a2VyIChtYWtlLW1hcmtlcikpKQorCQkoc2V0LW1hcmtlci1pbnNlcnRpb24tdHlwZSBtYXJrZXIg dCkKKwkJbWFya2VyKSkKIAkgKGFsbG93LXdyaXRlLWJhY2stcCAobnVsbCBjb2RlKSkKIAkgYmxv Y2stbmluZGVudCB0b3RhbC1uaW5kZW50IG92bCBsYW5nIGxhbmctZiBzaW5nbGUgbGZtdCBidWZm ZXIgbXNnCiAJIGJlZ2xpbmUgbWFya2xpbmUgbWFya2NvbCBsaW5lIGNvbCB0cmFuc21pdHRlZC12 YXJpYWJsZXMpCi0tIAoxLjcuMTEuNAoK --047d7b86eab868b78304d0be1944 Content-Type: application/octet-stream; name="0002-fix-org-edit-src-code-invoked-outside-src-block.patch" Content-Disposition: attachment; filename="0002-fix-org-edit-src-code-invoked-outside-src-block.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hao2rd0e1 RnJvbSAyZTZkZDU3OTMwZGNiNWI1N2Q1Njc4NTVkMDgzNGRmNTBkZTdlODllIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZSBXYW5nIDxsZS53YW5nQGFnd29ybGQuY29tLmF1PgpEYXRl OiBUaHUsIDEzIERlYyAyMDEyIDIzOjQ2OjAwICswODAwClN1YmplY3Q6IFtQQVRDSCAyLzNdIGZp eCBvcmctZWRpdC1zcmMtY29kZSBpbnZva2VkIG91dHNpZGUgc3JjIGJsb2NrCgotLS0KIGxpc3Av b3JnLXNyYy5lbCB8IDExICsrKysrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25z KCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLXNyYy5lbCBiL2xpc3Av b3JnLXNyYy5lbAppbmRleCA2NTE1OTg3Li45N2Y0NzNhIDEwMDY0NAotLS0gYS9saXNwL29yZy1z cmMuZWwKKysrIGIvbGlzcC9vcmctc3JjLmVsCkBAIC0yMjEsMTAgKzIyMSwxMyBAQCBidWZmZXIu IgogCSAgKGxldCogKCh0ZW1wIChvcmctZWRpdC1zcmMtZmluZC1yZWdpb24tYW5kLWxhbmcpKQog CQkgKGJlZyAobnRoIDAgdGVtcCkpCiAJCSAoZW5kIChudGggMSB0ZW1wKSkpCi0JICAgIChpZiAo Pj0gZW5kIGJlZykgdGVtcAotCSAgICAgIChnb3RvLWNoYXIgYmVnKQotCSAgICAgIChpbnNlcnQg IlxuIikKLQkgICAgICAob3JnLWVkaXQtc3JjLWZpbmQtcmVnaW9uLWFuZC1sYW5nKSkpKQorCSAg ICAoaWYgKGFuZCBiZWcgZW5kKQorCQkoaWYgKD49IGVuZCBiZWcpCisJCSAgICB0ZW1wCisJCSAg KGdvdG8tY2hhciBiZWcpCisJCSAgKGluc2VydCAiXG4iKQorCQkgIChvcmctZWRpdC1zcmMtZmlu ZC1yZWdpb24tYW5kLWxhbmcpKQorCSAgICAgIChlcnJvciAiUG9pbnQgbm90IGluIHNyYyBibG9j ay4iKSkpKQogCSAoZnVsbC1pbmZvIChvcmctYmFiZWwtZ2V0LXNyYy1ibG9jay1pbmZvICdsaWdo dCkpCiAJIChvcmctbW9kZS1wIChkZXJpdmVkLW1vZGUtcCAnb3JnLW1vZGUpKSA7OyBkZXJpdmVk LW1vZGUtcCBpcyByZWZsZXhpdmUKIAkgKGJlZyAobWFrZS1tYXJrZXIpKQotLSAKMS43LjExLjQK Cg== --047d7b86eab868b78304d0be1944 Content-Type: application/octet-stream; name="0003-add-tests-for-org-src-edit.patch" Content-Disposition: attachment; filename="0003-add-tests-for-org-src-edit.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hao2rd0g2 RnJvbSAzMjk5ZTVjZThjYWM5ZjNhMGNiZDkxMjAyMDk1NWZjNTAyZDVhZGE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZSBXYW5nIDxsZS53YW5nQGFnd29ybGQuY29tLmF1PgpEYXRl OiBUaHUsIDEzIERlYyAyMDEyIDIzOjQ2OjQwICswODAwClN1YmplY3Q6IFtQQVRDSCAzLzNdIGFk ZCB0ZXN0cyBmb3Igb3JnLXNyYy1lZGl0CgotLS0KIHRlc3RpbmcvbGlzcC90ZXN0LW9yZy1zcmMu ZWwgfCA5OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDk4IGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0aW5n L2xpc3AvdGVzdC1vcmctc3JjLmVsCgpkaWZmIC0tZ2l0IGEvdGVzdGluZy9saXNwL3Rlc3Qtb3Jn LXNyYy5lbCBiL3Rlc3RpbmcvbGlzcC90ZXN0LW9yZy1zcmMuZWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uNDJiMGY5ZQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3RpbmcvbGlz cC90ZXN0LW9yZy1zcmMuZWwKQEAgLTAsMCArMSw5OCBAQAorOzs7IHRlc3Qtb3JnLXNyYy5lbCAt LS0gVGVzdHMgZm9yIG9yZy1zcmMuZWwKKworOzsgQ29weXJpZ2h0IChDKSAyMDEyICBMZSBXYW5n CisKKzs7IEF1dGhvcjogTGUgV2FuZyA8bDI2d2FuZyBhdCBnbWFpbCBkb3QgY29tPgorCis7OyBU aGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5k L29yIG1vZGlmeQorOzsgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKzs7IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRp b24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCis7OyAoYXQgeW91ciBvcHRp b24pIGFueSBsYXRlciB2ZXJzaW9uLgorCis7OyBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQg aW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKzs7IGJ1dCBXSVRIT1VUIEFOWSBX QVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OyBNRVJDSEFO VEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCis7 OyBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCis7OyBZb3Ug c2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGlj ZW5zZQorOzsgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3 dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKworKHJlcXVpcmUgJ29yZy10ZXN0KQorCisMCisKKyhl cnQtZGVmdGVzdCB0ZXN0LW9yZy1zcmMvYmFzaWMgKCkKKyAgIkVkaXRpbmcgcmVndWxhciBibG9j ayB3b3Jrcy4gd2l0aCBwb2ludCBvbgorCisjK2JlZ2luX3NyYyBsaW5lCisiCisgIChvcmctdGVz dC13aXRoLXRlbXAtdGV4dAorICAgIgorIytiZWdpbl9zcmMgZW1hY3MtbGlzcAorICAobWVzc2Fn ZSBoZWxsbykKKyMrZW5kX3NyYworIgorICAgKGdvdG8tbGluZSAyKQorICAgKG9yZy1lZGl0LXNw ZWNpYWwpCisgICAoaW5zZXJ0ICJibGFoIikKKyAgIChvcmctZWRpdC1zcmMtZXhpdCkKKyAgIChz aG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAiCisjK2JlZ2luX3NyYyBlbWFjcy1saXNwCisg IGJsYWgobWVzc2FnZSBoZWxsbykKKyMrZW5kX3NyYworIikpCisgICAoc2hvdWxkIChlcXVhbCAo d29yZC1hdC1wb2ludCkgImJsYWgiKSkpKQorCisoZXJ0LWRlZnRlc3QgdGVzdC1vcmctc3JjL3Bv aW50LW91dHNpZGUtYmxvY2sgKCkKKyAgIkVkaXRpbmcgd2l0aCBwb2ludCBiZWZvcmUvYWZ0ZXIg YmxvY2sgc2lnbmFscyBleHBlY3RlZCBlcnJvci4iCisgIChvcmctdGVzdC13aXRoLXRlbXAtdGV4 dAorICAgICAgIgorIytiZWdpbl9zcmMgZW1hY3MtbGlzcAorICAobWVzc2FnZSBoZWxsbykKKyMr ZW5kX3NyYworIgorICAgIChnb3RvLWxpbmUgMSkKKyAgICAoc2hvdWxkLWVycm9yIChvcmctZWRp dC1zcGVjaWFsKSkKKyAgICAoZ290by1jaGFyIChwb2ludC1tYXgpKQorICAgIChzaG91bGQtZXJy b3IgKG9yZy1lZGl0LXNwZWNpYWwpKSkpCisKKyhlcnQtZGVmdGVzdCB0ZXN0LW9yZy1zcmMvZW1w dHktYmxvY2sgKCkKKyAgIkVkaXRpbmcgZW1wdHkgYmxvY2suIgorICAob3JnLXRlc3Qtd2l0aC10 ZW1wLXRleHQKKyAgICAgICIKKyMrYmVnaW5fc3JjIGVtYWNzLWxpc3AKKyMrZW5kX3NyYworIgor ICAgIChnb3RvLWxpbmUgMikKKyAgICAob3JnLWVkaXQtc3BlY2lhbCkKKyAgICAoaW5zZXJ0ICJi bGFoIikKKyAgICAob3JnLWVkaXQtc3JjLWV4aXQpCisgICAgKHNob3VsZCAoZXF1YWwgKGJ1ZmZl ci1zdHJpbmcpICIKKyMrYmVnaW5fc3JjIGVtYWNzLWxpc3AKKyAgYmxhaAorIytlbmRfc3JjCisi KSkKKyAgICAoc2hvdWxkIChlcXVhbCAod29yZC1hdC1wb2ludCkgImJsYWgiKSkpKQorCisoZXJ0 LWRlZnRlc3QgdGVzdC1vcmctc3JjL2JsYW5rLWxpbmUtYmxvY2sgKCkKKyAgIkVkaXRpbmcgYmxv Y2sgd2l0aCBqdXN0IGEgYmxhbmsgbGluZS4iCisgIChvcmctdGVzdC13aXRoLXRlbXAtdGV4dAor ICAgICAgIgorIytiZWdpbl9zcmMgZW1hY3MtbGlzcAorCisjK2VuZF9zcmMKKyIKKyAgICAoZ290 by1saW5lIDMpCisgICAgKG9yZy1lZGl0LXNwZWNpYWwpCisgICAgKGluc2VydCAiYmxhaCIpCisg ICAgKG9yZy1lZGl0LXNyYy1leGl0KQorICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5n KSAiCisjK2JlZ2luX3NyYyBlbWFjcy1saXNwCisgIGJsYWgKKyMrZW5kX3NyYworIikpCisgICAg KHNob3VsZCAoZXF1YWwgKHdvcmQtYXQtcG9pbnQpICJibGFoIikpKSkKKworKHByb3ZpZGUgJ3Rl c3Qtb3JnLXNyYykKKzs7OyB0ZXN0LW9yZy1zcmMuZWwgZW5kcyBoZXJlCi0tIAoxLjcuMTEuNAoK --047d7b86eab868b78304d0be1944--