From mboxrd@z Thu Jan 1 00:00:00 1970 From: Le Wang Subject: Re: [PATCH] org-edit-special too much space if starting with empty block Date: Fri, 23 Nov 2012 22:54:12 +0800 Message-ID: References: <87sj8jlj4b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:47882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbue3-0007Pb-62 for emacs-orgmode@gnu.org; Fri, 23 Nov 2012 09:54:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tbudx-0006nM-D5 for emacs-orgmode@gnu.org; Fri, 23 Nov 2012 09:54:19 -0500 Received: from mail-qa0-f48.google.com ([209.85.216.48]:50973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbudx-0006mI-8x for emacs-orgmode@gnu.org; Fri, 23 Nov 2012 09:54:13 -0500 Received: by mail-qa0-f48.google.com with SMTP id s11so1886525qaa.0 for ; Fri, 23 Nov 2012 06:54:12 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Orgmode Mailing List Has anyone had a chance to check this out? Others have run into this problem. On Sun, Nov 18, 2012 at 1:49 PM, Le Wang wrote: > On Fri, Nov 9, 2012 at 8:23 AM, Nicolas Goaziou wrote: >> Thank you for your patch. >> >> Would you mind adding comments in the function in order to explain the >> need for two pass. Also, you may want to reverse the if test in order to >> get rid of the progn. > > I've refactored and added comments. > >> Finally, could you provide the patch as "git format-patch" and add >> a changelog entry to it? > > The patch is now in the requested format. If the commit message and > inlined comments still aren't enough to explain the changes, please > let me know. > > Thanks! > > > -- > Le -- Le