From mboxrd@z Thu Jan  1 00:00:00 1970
From: Puneeth Chaganti <punchagan@gmail.com>
Subject: Re: [RFC] Change property drawer syntax
Date: Fri, 5 Dec 2014 20:03:04 +0530
Message-ID: <CALnw1fSu5AqsEDO54fP=xX70_KiFgJyzHU_-VgOEqy4Oo2-yaw@mail.gmail.com>
References: <87oatek909.fsf@nicolasgoaziou.fr> <86zjbwlm31.fsf@example.com>
	<86r3x8lllg.fsf@example.com> <86389659lx.fsf@example.com>
	<87ppc9o7nz.fsf@nicolasgoaziou.fr>
	<867fyh9et8.fsf@example.com> <87mw7bnf7c.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punchagan@gmail.com>) id 1Xwtwl-0007bI-8Z
	for emacs-orgmode@gnu.org; Fri, 05 Dec 2014 09:33:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <punchagan@gmail.com>) id 1Xwtwj-0000vy-Rm
	for emacs-orgmode@gnu.org; Fri, 05 Dec 2014 09:33:27 -0500
Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:57716)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <punchagan@gmail.com>) id 1Xwtwj-0000vt-L1
	for emacs-orgmode@gnu.org; Fri, 05 Dec 2014 09:33:25 -0500
Received: by mail-wg0-f50.google.com with SMTP id k14so1060897wgh.9
	for <emacs-orgmode@gnu.org>; Fri, 05 Dec 2014 06:33:25 -0800 (PST)
In-Reply-To: <87mw7bnf7c.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode List <emacs-orgmode@gnu.org>

Hi Nicolas,

It looks the commit 8d8ad983823c63b13fd6b471ce9db8c2f95e3808 broke
generation of org sparse trees, when searching with properties that
are not all uppercase.   The fix seems to be just removing the
conversion of key to upcase in `org-entry-properties'.  Since the
comparison with special properties is being done by a case insensitive
check, this should be the only fix required?  There are no test
failures, and the conversion to uppercase seems to have been
introduced only in this change, so it should be OK?

diff --git a/lisp/org.el b/lisp/org.el
index e806440..8cbbcc4 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15703,7 +15703,7 @@ strings."
                    ;; after its extension.  We also forbid standard
                    ;; properties to be named as special properties.
                    (while (re-search-forward org-property-re end t)
-                     (let* ((key (upcase (org-match-string-no-properties 2)))
+                     (let* ((key (org-match-string-no-properties 2))
                             (extendp (org-string-match-p "\\+\\'" key))
                             (key-base (if extendp (substring key 0 -1) key))
                             (value (org-match-string-no-properties 3)))

Thanks,
Puneeth