From mboxrd@z Thu Jan 1 00:00:00 1970 From: Puneeth Chaganti Subject: Re: [RFC] Change property drawer syntax Date: Sat, 6 Dec 2014 12:12:35 +0530 Message-ID: References: <87oatek909.fsf@nicolasgoaziou.fr> <86zjbwlm31.fsf@example.com> <86r3x8lllg.fsf@example.com> <86389659lx.fsf@example.com> <87ppc9o7nz.fsf@nicolasgoaziou.fr> <867fyh9et8.fsf@example.com> <87mw7bnf7c.fsf@nicolasgoaziou.fr> <878uil3c95.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=f46d041825bcdf25dc0509868088 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xx951-0003x7-Jr for emacs-orgmode@gnu.org; Sat, 06 Dec 2014 01:43:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xx94z-0007Os-FE for emacs-orgmode@gnu.org; Sat, 06 Dec 2014 01:42:59 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:56790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xx94z-0007Nx-7T for emacs-orgmode@gnu.org; Sat, 06 Dec 2014 01:42:57 -0500 Received: by mail-wg0-f45.google.com with SMTP id b13so2514297wgh.32 for ; Fri, 05 Dec 2014 22:42:56 -0800 (PST) In-Reply-To: <878uil3c95.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode List --f46d041825bcdf25dc0509868088 Content-Type: text/plain; charset=UTF-8 On Sat, Dec 6, 2014 at 5:01 AM, Nicolas Goaziou wrote: > Hello, > > Puneeth Chaganti writes: > >> It looks the commit 8d8ad983823c63b13fd6b471ce9db8c2f95e3808 broke >> generation of org sparse trees, when searching with properties that >> are not all uppercase. > > Could you provide an ECM? I've attached the ECM. >> The fix seems to be just removing the conversion of key to upcase in >> `org-entry-properties'. Since the comparison with special properties >> is being done by a case insensitive check, this should be the only fix >> required? > > There is another check, case-sensitive this time, for duplicate > properties just below. > > Anyway, I think the problem lies in the fact that, somewhere in the > internals of the function generating the spare tree, there is > a case-sensitive search. Yes, that is correct. I have a few code blocks that work and don't work, in the ECM, if at all you want to look at them. --f46d041825bcdf25dc0509868088 Content-Type: application/octet-stream; name="sparse-tree-ecm.org" Content-Disposition: attachment; filename="sparse-tree-ecm.org" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i3cm6fyp0 KiBDbGFzc2ljCioqIEdvbGRiZXJnIFZhcmlhdGlvbnMKICAgOlBST1BFUlRJRVM6CiAgIDpUaXRs ZTogICAgR29sZGJlcmcgVmFyaWF0aW9ucwogICA6Q29tcG9zZXI6IEouUy4gQmFjaAogICA6QXJ0 aXN0OiAgIEdsZW4gR291bGQKICAgOlB1Ymxpc2hlcjogRGV1dHNjaGUgR3JhbW1vcGhvbgogICA6 TkRpc2tzOiAgIDEKICAgOlRFU1Q6ICAgICAxCiAgIDpFTkQ6CgojK0JFR0lOX1NSQyBlbWFjcy1s aXNwCiAgKG9yZy1tYXRjaC1zcGFyc2UtdHJlZSBuaWwgIk5EaXNrcz1cIjFcIiIpIDs7IERvZXMg bm90IHdvcmsKICAob3JnLW1hdGNoLXNwYXJzZS10cmVlIG5pbCAiVEVTVD1cIjFcIiIpICAgOzsg V29ya3MKCiAgOzsgVGhlIG1hdGNoZXIgY3JlYXRlZCBpcwogIChhbmQgKHByb2duIChzZXRxIG9y Zy1jYWNoZWQtcHJvcHMgbmlsKSAoc3RyaW5nPSAob3IgKG9yZy1jYWNoZWQtZW50cnktZ2V0IG5p bCAiTkRpc2tzIikgIiIpICIxIikpIHQpCiAgOzsgQ2FjaGVkIGVudHJpZXMgaGF2ZSB1cGNhc2Ug dGFncyBhbmQgaXQgZG9lc24ndCB3b3JrCgoKICA7OyBUaGlzIHdvdWxkIHdvcmsKICAoYW5kIChw cm9nbiAoc2V0cSBvcmctY2FjaGVkLXByb3BzIG5pbCkgKHN0cmluZz0gKG9yIChvcmctY2FjaGVk LWVudHJ5LWdldCBuaWwgIk5ESVNLUyIpICIiKSAiMSIpKSB0KQoKICA7OyBBbHNvLCB0aGlzCiAg KGFuZCAocHJvZ24gKHNldHEgb3JnLWNhY2hlZC1wcm9wcyBuaWwpIChzdHJpbmc9IChvciAob3Jn LWVudHJ5LWdldCBuaWwgIk5EaXNrcyIpICIiKSAiMSIpKSB0KQoKIytFTkRfU1JDCg== --f46d041825bcdf25dc0509868088--