emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Brand <michael.ch.brand@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Bastien <bzg@altern.org>,
	emacs-orgmode@gnu.org, "Sébastien Delafond" <sdelafond@gmail.com>,
	"Sanjoy Mahajan" <sanjoy@olin.edu>
Subject: Re: outline-demote incorrectly demotes leaf nodes
Date: Sat, 22 Oct 2011 10:15:24 +0200	[thread overview]
Message-ID: <CALn3zojRg8B=A_SG=f6yRfGwiutpczcQVv_bS53ngnA=P96wOA@mail.gmail.com> (raw)
In-Reply-To: <D5805C42-25CD-4BA9-A4C1-B47A0837C05E@gmail.com>

Hi Carsten

On Fri, Oct 21, 2011 at 16:40, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
> On Oct 19, 2011, at 5:39 PM, Michael Brand wrote:
>> (define-key org-mode-map [remap outline-promote] 'org-promote-subtree)
>> (define-key org-mode-map [remap outline-demote] 'org-demote-subtree)
>> [...]
>
> Would you like to carefully think about which other functions you
> might want to have remapped ...

I started to go through the functions that are bound in
outline-mode-prefix-map to compare their behavior with that of the Org
equivalents. Now I stumbled upon
outline/org-forward/backward-same-level. All four doc strings state
"Stop at the first and last subheadings of a superior heading", but
the Org ones don't. As I remember, Org "motion on same level" C-c
C-f/b once stopped. Git bisect shows that this had been the case
before the "motion on same level" functionality moved into the new
functions org-forward/backward-same-level with
http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=0eaf3cce
At that time the (error "No following same-level heading")
disappeared.

I assume that Org mode should still stop as documented and like
Outline mode. If this is true I'd like to ask you if you could help to
resolve this. Of course I tried to do it myself but have to admit that
it would mean too much effort for me to understand what happens before
and after the commit with the three optimization levels that it
implements.

> and then prepare a patch?

I'll add the two new pairs from above and probably some more into a
follow-up to this
http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=b2632dc4
when I'll be finished with going through outline-mode-prefix-map.

Michael

  parent reply	other threads:[~2011-10-22  8:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18  8:55 outline-demote incorrectly demotes leaf nodes Sébastien Delafond
2011-10-18  9:59 ` Christian Moe
2011-10-18 10:22   ` Bernt Hansen
2011-10-18 11:21     ` Sébastien Delafond
2011-10-18 11:27       ` Bernt Hansen
2011-10-18 18:03   ` Sanjoy Mahajan
2011-10-18 18:57     ` Nick Dokos
2011-10-19  7:14     ` Carsten Dominik
2011-10-19 13:57       ` Sanjoy Mahajan
2011-10-19 15:39       ` Michael Brand
2011-10-21 14:22         ` Bastien
2011-10-21 14:40         ` Carsten Dominik
2011-10-21 16:08           ` Bastien
2011-10-22  8:15           ` Michael Brand [this message]
2011-11-09 18:16             ` Michael Brand
2011-12-11 18:44               ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALn3zojRg8B=A_SG=f6yRfGwiutpczcQVv_bS53ngnA=P96wOA@mail.gmail.com' \
    --to=michael.ch.brand@gmail.com \
    --cc=bzg@altern.org \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sanjoy@olin.edu \
    --cc=sdelafond@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).