From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: Org campture recursively expands %-escapes Date: Wed, 6 Jan 2016 06:45:57 +0100 Message-ID: References: <874mgb9gqv.fsf@nicolasgoaziou.fr> <87d1uwpm1a.fsf@nicolasgoaziou.fr> <87610o2wkz.fsf@nicolasgoaziou.fr> <87io4kn6cn.fsf@nicolasgoaziou.fr> <87oad2qw4z.fsf@nicolasgoaziou.fr> <87bn92qsmb.fsf@nicolasgoaziou.fr> <87lh837fzx.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c37a3a4e27c30528a3de0b Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGgv2-0001Zk-0H for emacs-orgmode@gnu.org; Wed, 06 Jan 2016 00:46:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGgv0-0004fa-Tf for emacs-orgmode@gnu.org; Wed, 06 Jan 2016 00:45:59 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:36707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGgv0-0004eb-NQ for emacs-orgmode@gnu.org; Wed, 06 Jan 2016 00:45:58 -0500 Received: by mail-wm0-x22a.google.com with SMTP id l65so47228442wmf.1 for ; Tue, 05 Jan 2016 21:45:58 -0800 (PST) In-Reply-To: <87lh837fzx.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode --001a11c37a3a4e27c30528a3de0b Content-Type: text/plain; charset=UTF-8 Hi Nicolas On Wed, Jan 6, 2016 at 12:39 AM, Nicolas Goaziou wrote: > I do. Somehow, I didn't see this before. This is because I renamed > `org-capture-expand-embedded-elisp' into > `org-capture--expand-embedded-elisp'. > > However, ISTM there is some code duplication between > `org-feed-format-entry' and `org-capture-fill-template'. Is calling > `org-capture-expand-embedded-elisp' from the former the right thing to > do? I don't really know. It was only my choice of how to avoid code duplication between `org-feed-format-entry' and `org-capture-fill-template' according to http://thread.gmane.org/gmane.emacs.orgmode/56991/focus=57265 and with lack of better knowledge from my side. If there is a better solution please go ahead. Michael --001a11c37a3a4e27c30528a3de0b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Nicolas

On Wed, Jan 6, 2016 at 12:39 AM, Nicolas= Goaziou <mail@nicolasgoaziou.= fr> wrote:
> I do. Somehow, I didn't see this before. This= is because I renamed
> `org-capture-expand-embedded-elisp' into<= br>> `org-capture--expand-embedded-elisp'.
>
> However, = ISTM there is some code duplication between
> `org-feed-format-entry&= #39; and `org-capture-fill-template'. Is calling
> `org-capture-e= xpand-embedded-elisp' from the former the right thing to
> do?
I don't really know. It was only my choice of how to avoid codeduplication between `org-feed-format-entry' and
`org-capture-fill-t= emplate' according to
http://thread.gmane.org/gmane.emacs.orgmode/5= 6991/focus=3D57265
and with lack of better knowledge from my side. I= f there is a better
solution please go ahead.

Michael
--001a11c37a3a4e27c30528a3de0b--