From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: [PATCH] Link to Org file: regard startup view state Date: Wed, 25 Jan 2012 18:28:26 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0016e6d99fa46786e904b75d97b7 Return-path: Received: from eggs.gnu.org ([140.186.70.92]:48521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq6eL-0005co-FU for emacs-orgmode@gnu.org; Wed, 25 Jan 2012 12:28:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rq6e5-0002JM-3y for emacs-orgmode@gnu.org; Wed, 25 Jan 2012 12:28:35 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:65034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq6e4-0002Ik-KW for emacs-orgmode@gnu.org; Wed, 25 Jan 2012 12:28:28 -0500 Received: by wera13 with SMTP id a13so3018005wer.0 for ; Wed, 25 Jan 2012 09:28:26 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode --0016e6d99fa46786e904b75d97b7 Content-Type: text/plain; charset=ISO-8859-1 Hi all I would like to ask for a review of the attached patch that resolves an issue with org-open-at-point. When opening a link to another Org file not yet opened (first close it if opened) before this patch: 1) When point is on the line with the link and the line is not a heading then the target file is opened with the target file startup view state, e. g. the default OVERVIEW. 2) When point is on the heading of the entry of which the link is part of then the target file is opened with "SHOW ALL". But it is expected to regard the target file startup view state like case 1). Note: Only in case 2) `org-open-at-point' uses `org-offer-links-in-entry' and from there `org-open-link-from-string'. example current buffer with link: #+BEGIN_SRC org ,* section , [[file:myfile.org::*mytarget]] #+END_SRC example target file myfile.org: #+BEGIN_SRC org ,* mytarget , text ,*** subsection #+END_SRC Michael --0016e6d99fa46786e904b75d97b7 Content-Type: text/plain; charset=US-ASCII; name="0001-Link-to-Org-file-regard-startup-view-state.patch.txt" Content-Disposition: attachment; filename="0001-Link-to-Org-file-regard-startup-view-state.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gxumm8iw0 RnJvbSA4NTNlYzg2NWYwZDA5NzBlYWM5YWRkNmViMGJiNjI2YjM3ODIzODM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJyYW5kIDxtaWNoYWVsLmNoLmJyYW5kQGdtYWls LmNvbT4KRGF0ZTogV2VkLCAyNSBKYW4gMjAxMiAxODoyNDo1OCArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIExpbmsgdG8gT3JnIGZpbGU6IHJlZ2FyZCBzdGFydHVwIHZpZXcgc3RhdGUKCiogbGlzcC9v cmcuZWwgKG9yZy1vcGVuLWxpbmstZnJvbS1zdHJpbmcpOiBSZWdhcmQgYHJlZmVyZW5jZS1idWZm ZXInCndoZW4gc2V0dGluZyBgb3JnLWluaGliaXQtc3RhcnR1cCcuCgpXaGVuIG9wZW5pbmcgYSBs aW5rIHRvIGFub3RoZXIgT3JnIGZpbGUgbm90IHlldCBvcGVuZWQgKGZpcnN0IGNsb3NlIGl0Cmlm IG9wZW5lZCkgYmVmb3JlIHRoaXMgcGF0Y2g6CjEpIFdoZW4gcG9pbnQgaXMgb24gdGhlIGxpbmUg d2l0aCB0aGUgbGluayBhbmQgdGhlIGxpbmUgaXMgbm90IGEKICAgaGVhZGluZyB0aGVuIHRoZSB0 YXJnZXQgZmlsZSBpcyBvcGVuZWQgd2l0aCB0aGUgdGFyZ2V0IGZpbGUgc3RhcnR1cAogICB2aWV3 IHN0YXRlLCBlLiBnLiB0aGUgZGVmYXVsdCBPVkVSVklFVy4KMikgV2hlbiBwb2ludCBpcyBvbiB0 aGUgaGVhZGluZyBvZiB0aGUgZW50cnkgb2Ygd2hpY2ggdGhlIGxpbmsgaXMgcGFydAogICBvZiB0 aGVuIHRoZSB0YXJnZXQgZmlsZSBpcyBvcGVuZWQgd2l0aCAiU0hPVyBBTEwiLiBCdXQgaXQgaXMK ICAgZXhwZWN0ZWQgdG8gcmVnYXJkIHRoZSB0YXJnZXQgZmlsZSBzdGFydHVwIHZpZXcgc3RhdGUg bGlrZSBjYXNlIDEpLgpOb3RlOiBPbmx5IGluIGNhc2UgMikgYG9yZy1vcGVuLWF0LXBvaW50JyB1 c2VzCmBvcmctb2ZmZXItbGlua3MtaW4tZW50cnknIGFuZCBmcm9tIHRoZXJlIGBvcmctb3Blbi1s aW5rLWZyb20tc3RyaW5nJy4KCmV4YW1wbGUgY3VycmVudCBidWZmZXIgd2l0aCBsaW5rOgojK0JF R0lOX1NSQyBvcmcKICAsKiBzZWN0aW9uCiAgLCAgW1tmaWxlOm15ZmlsZS5vcmc6OipteXRhcmdl dF1dCiMrRU5EX1NSQwoKZXhhbXBsZSB0YXJnZXQgZmlsZSBteWZpbGUub3JnOgojK0JFR0lOX1NS QyBvcmcKICAsKiBteXRhcmdldAogICwgIHRleHQKICAsKioqIHN1YnNlY3Rpb24KIytFTkRfU1JD Ci0tLQogbGlzcC9vcmcuZWwgfCAgICAyICstCiAxIGZpbGVzIGNoYW5nZWQsIDEgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL29yZy5lbCBiL2xpc3Avb3Jn LmVsCmluZGV4IDFmYTcyNTkuLjFmZmQxYjMgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLmVsCisrKyBi L2xpc3Avb3JnLmVsCkBAIC05NDQzLDcgKzk0NDMsNyBAQCBPcmctbW9kZSBzeW50YXguIgogICAo aW50ZXJhY3RpdmUgInNMaW5rOiBcblAiKQogICAobGV0ICgocmVmZXJlbmNlLWJ1ZmZlciAob3Ig cmVmZXJlbmNlLWJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkpCiAgICAgKHdpdGgtdGVtcC1idWZm ZXIKLSAgICAgIChsZXQgKChvcmctaW5oaWJpdC1zdGFydHVwIHQpKQorICAgICAgKGxldCAoKG9y Zy1pbmhpYml0LXN0YXJ0dXAgKG5vdCByZWZlcmVuY2UtYnVmZmVyKSkpCiAJKG9yZy1tb2RlKQog CShpbnNlcnQgcykKIAkoZ290by1jaGFyIChwb2ludC1taW4pKQotLSAKMS43LjEKCg== --0016e6d99fa46786e904b75d97b7--