From: Michael Brand <michael.ch.brand@gmail.com>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: org-mode List <emacs-orgmode@gnu.org>
Subject: Re: [PATH] Speedups to org-table-recalculate
Date: Sun, 19 Oct 2014 21:57:05 +0200 [thread overview]
Message-ID: <CALn3zoiqUfGR6G24YDqH69ZOdiAHX72yqJ+6Xdq+ELmv2n0qmg@mail.gmail.com> (raw)
In-Reply-To: <CAPrg3HALf6UDzpFvoqEV2u1Z7vHqV4r7m5v0KxyTod05m_Rf7A@mail.gmail.com>
Hi Nathaniel
On Sat, Oct 18, 2014 at 7:11 AM, Nathaniel Flath <flat0103@gmail.com> wrote:
> Patches are attached.
I am not an expert for all the following comments, please correct me
or contradict where necessary.
The patches do not apply on current master, so I did not try them out
yet.
You might want to add a def-edebug-spec like there is one for many
other defmacro in Org.
Limit lines to max. 80 chars.
It will make it easier for the maintainer Bastien to apply the patches
when you format them with git including a changelog etc. as described
here
http://orgmode.org/worg/org-contribute.html
> + (if (not all) (message "Re-applying formula to field: %s" (car eq))
> + (org-table-execute-once-per-second log-last-time (message "Re-applying formula to field: %s" (car eq))))
Good idea to still log always when only one table row is recalculated.
The doubling of the message makes it more complicated to maintain its
string. I suggest to change the macro to allow
(org-table-execute-once-per-second
(when all log-last-time) ; Log just always when `all' is nil.
(message "Re-applying formula to field: %s" (car eq)))
Why not test `all' also for the other message with "to field"?
> + ,@body
> + )))
Parentheses not alone on an own line.
> + (and all (org-table-execute-once-per-second log-last-time (message "Re-applying formulas to %d lines...done" cnt))))
Shouldn't this use `log-first-time'?
Michael
next prev parent reply other threads:[~2014-10-19 19:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 20:03 [PATH] Speedups to org-table-recalculate Nathaniel Flath
2014-07-29 21:30 ` Bastien
2014-07-29 21:35 ` Nathaniel Flath
2014-07-29 21:42 ` Bastien
2014-08-01 21:56 ` Michael Brand
2014-08-07 22:57 ` Nathaniel Flath
2014-08-17 13:39 ` Michael Brand
2014-10-10 5:56 ` Nathaniel Flath
2014-10-10 10:35 ` Michael Brand
2014-10-10 19:43 ` Nathaniel Flath
2014-10-11 16:16 ` Michael Brand
2014-10-18 5:11 ` Nathaniel Flath
2014-10-19 19:57 ` Michael Brand [this message]
2014-10-20 1:56 ` Nathaniel Flath
2014-10-20 19:41 ` Michael Brand
2014-10-26 0:27 ` Nathaniel Flath
2014-10-26 19:58 ` Michael Brand
2014-11-09 10:18 ` Nathaniel Flath
2014-11-09 15:42 ` Michael Brand
2014-11-12 11:51 ` Nathaniel Flath
2014-11-12 19:09 ` Michael Brand
2014-11-14 13:33 ` Nathaniel Flath
2014-11-14 17:40 ` Michael Brand
2014-11-14 18:00 ` Nathaniel Flath
2014-11-14 20:19 ` Michael Brand
2014-11-14 22:37 ` Nicolas Goaziou
2014-11-21 9:10 ` Nathaniel Flath
2014-11-21 23:30 ` Nicolas Goaziou
2014-12-01 6:02 ` Nathaniel Flath
2014-12-01 6:15 ` Nathaniel Flath
2014-12-05 23:57 ` Nicolas Goaziou
2014-12-08 7:35 ` Nathaniel Flath
2014-12-08 12:56 ` Michael Brand
2014-12-14 21:07 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALn3zoiqUfGR6G24YDqH69ZOdiAHX72yqJ+6Xdq+ELmv2n0qmg@mail.gmail.com \
--to=michael.ch.brand@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=flat0103@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).