From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: [PATCH] Add check for assignment to hline relative references in table formulas. Date: Fri, 8 Nov 2013 12:09:22 +0100 Message-ID: References: <760e1f326345602d5fdfc3e9197444d2@mail.rickster.com> <2a44af29883017d4a922e25399f34200@mail.rickster.com> <87iow7w1gk.fsf@bzg.ath.cx> <871u2u8uv0.fsf@Rainer.invalid> <878ux0ngv2.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VejwQ-0001Dv-FF for emacs-orgmode@gnu.org; Fri, 08 Nov 2013 06:09:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VejwK-0000rs-OT for emacs-orgmode@gnu.org; Fri, 08 Nov 2013 06:09:30 -0500 Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:42078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VejwK-0000rc-Ez for emacs-orgmode@gnu.org; Fri, 08 Nov 2013 06:09:24 -0500 Received: by mail-la0-f46.google.com with SMTP id el20so1576710lab.5 for ; Fri, 08 Nov 2013 03:09:22 -0800 (PST) In-Reply-To: <878ux0ngv2.fsf@Rainer.invalid> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: Org Mode Hi Achim On Thu, Nov 7, 2013 at 8:37 PM, Achim Gratz wrote: > I've fixed the failing test since it wasn't checking hline expressions > and hence should not have relied on undocumented behaviour in the first > place. I agree that testing of "LHS hline ref range" and testing of something else (in this case "comparison") at the same time in the same ert-deftest has also disadvantages. But why did you only remove test coverage of "LHS hline ref range" instead of move it into a new ert-deftest? Michael