From: Michael Brand <michael.ch.brand@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Add the capture feature "%(sexp)" to org-feed
Date: Thu, 9 Aug 2012 16:07:41 +0200 [thread overview]
Message-ID: <CALn3zogGT5Lr2Fj4JdGQ8Q3S+Ry7NY5mQAdQTJ2FQZxc=0m3Bg@mail.gmail.com> (raw)
In-Reply-To: <87y5lqe21l.fsf@gnu.org>
Hi Bastien
Thank you for reviewing my patch.
On Wed, Aug 8, 2012 at 1:05 AM, Bastien <bzg@gnu.org> wrote:
> I've reworked some parts of your patch,
You omitted the Local variables sentence-end-double-space: t. Isn't
this a good idea for all the users like me that have set this to nil
in their config? I wanted to add it to more files as soon as I will
change them.
“The current date.” is probably meant to remain “the current date.”.
> specifically, I used `org-at-regexp-p' instead of
> `org-capture-inside-embedded-elisp-p'.
With `org-capture-inside-embedded-elisp-p' I wanted to be quite more
waterproof than `org-at-regexp-p' with the new additional closing
parenthesis in `org-capture-template-embedded-elisp-re'. See its
comment “to deal with for example %(length ")")”. Isn't it a good idea
to use `forward-sexp' in Emacs Lisp Mode for this? What can I improve?
> Can you check this is working okay for you?
I'll do with the final version of the patch if there will be changes.
Michael
next prev parent reply other threads:[~2012-08-09 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-16 15:53 Add the capture feature "%(sexp)" to org-feed Michael Brand
2012-06-17 2:07 ` Nick Dokos
2012-06-24 17:51 ` Michael Brand
2012-08-07 23:05 ` Bastien
2012-08-09 14:07 ` Michael Brand [this message]
2012-08-09 14:53 ` Bastien
2012-08-09 18:00 ` Michael Brand
2012-08-10 8:53 ` Bastien
2012-08-11 15:31 ` Michael Brand
2012-08-11 16:55 ` Bastien
2012-08-11 18:11 ` Michael Brand
2012-08-11 21:59 ` Bastien
2012-08-12 9:37 ` Michael Brand
2012-08-12 10:12 ` Bastien
2012-08-09 21:09 ` Ivan Andrus
2012-08-10 4:48 ` Michael Brand
2012-08-10 7:24 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALn3zogGT5Lr2Fj4JdGQ8Q3S+Ry7NY5mQAdQTJ2FQZxc=0m3Bg@mail.gmail.com' \
--to=michael.ch.brand@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).