From mboxrd@z Thu Jan 1 00:00:00 1970 From: Derek Feichtinger Subject: Re: Bug: fix for latex export of doi links [8.2.10 (8.2.10-35-g19a7d6-elpaplus @ .../elpa/org-plus-contrib-20150330/)] Date: Fri, 3 Apr 2015 21:52:32 +0200 Message-ID: References: <874moxyq7m.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11346e3cfd6bcb0512d749e0 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye7dq-0003xZ-C4 for emacs-orgmode@gnu.org; Fri, 03 Apr 2015 15:52:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ye7do-0004sr-Tm for emacs-orgmode@gnu.org; Fri, 03 Apr 2015 15:52:34 -0400 Received: from mail-ie0-x22f.google.com ([2607:f8b0:4001:c03::22f]:36461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye7do-0004sn-MG for emacs-orgmode@gnu.org; Fri, 03 Apr 2015 15:52:32 -0400 Received: by iebrs15 with SMTP id rs15so11993085ieb.3 for ; Fri, 03 Apr 2015 12:52:32 -0700 (PDT) In-Reply-To: <874moxyq7m.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Derek Feichtinger , emacs-orgmode@gnu.org --001a11346e3cfd6bcb0512d749e0 Content-Type: text/plain; charset=UTF-8 Hi, Nicolas thanks for responding so fast. Sure, I'll try and submit the patch. Thanks for all your great work! Happy Easter, Derek On Fri, Apr 3, 2015 at 9:19 PM, Nicolas Goaziou wrote: > Hello, > > Derek Feichtinger writes: > > > The current org latex export will export a link doi:10.xyz/abcd without > > the protocol prefix as 10.xyz/abcd. Correctly, it should retain the > > prefix. > > > > An easy fix is adding "doi" to the list of protocols that retain > > the link type string in ox-latex.el, below. > > > > ################### ox-latex.el ############### > > (defun org-latex-link (link desc info) > > "Transcode a LINK object from Org to LaTeX. > > > > DESC is the description part of the link, or the empty string. > > INFO is a plist holding contextual information. See > > `org-export-data'." > > (let* ((type (org-element-property :type link)) > > (raw-path (replace-regexp-in-string > > "%" "\\%" (org-element-property :path link) nil t)) > > ;; Ensure DESC really exists, or set it to nil. > > (desc (and (not (string= desc "")) desc)) > > (imagep (org-export-inline-image-p > > link org-latex-inline-image-rules)) > > (path (cond > > ;; ----- NEXT LINE CONTAINS THE FIX ------- > > ((member type '("http" "https" "ftp" "mailto" "doi")) > > (concat type ":" raw-path)) > > ((and (string= type "file") (file-name-absolute-p raw-path)) > > (concat "file:" raw-path)) > > (t raw-path))) > > protocol) > > ############# > > Indeed. Thank you. > > Would you mind preparing a patch with "git format-patch" for correct > attribution? See for > details. > > Regards, > > -- > Nicolas Goaziou > --001a11346e3cfd6bcb0512d749e0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi, Nicolas

thanks for responding so fa= st. Sure, I'll try and submit the patch.
Thanks for all your = great work!

Happy Easter,
Derek

On Fri, Apr 3,= 2015 at 9:19 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
Hello,

Derek Feichtinger <dfeich@gmail.com<= /a>> writes:

> The current org latex export will export a link doi:10.xyz/abcd withou= t
> the protocol prefix as 10.xyz/abcd. Correctly, it should retain the > prefix.
>
> An easy fix is adding "doi" to the list of protocols that re= tain
> the link type string in ox-latex.el, below.
>
> ################### ox-latex.el ###############
> (defun org-latex-link (link desc info)
>=C2=A0 =C2=A0"Transcode a LINK object from Org to LaTeX.
>
> DESC is the description part of the link, or the empty string.
> INFO is a plist holding contextual information.=C2=A0 See
> `org-export-data'."
>=C2=A0 =C2=A0(let* ((type (org-element-property :type link))
>=C2=A0 (raw-path (replace-regexp-in-string
>=C2=A0 =C2=A0 =C2=A0"%" "\\%" (org-element-property= :path link) nil t))
>=C2=A0 ;; Ensure DESC really exists, or set it to nil.
>=C2=A0 (desc (and (not (string=3D desc "")) desc))
>=C2=A0 (imagep (org-export-inline-image-p
>=C2=A0 =C2=A0link org-latex-inline-image-rules))
>=C2=A0 (path (cond
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; ----- = NEXT LINE CONTAINS THE FIX -------
> ((member type '("http" "https" "ftp"= "mailto" "doi"))
>=C2=A0 (concat type ":" raw-path))
> ((and (string=3D type "file") (file-name-absolute-p raw-path= ))
>=C2=A0 (concat "file:" raw-path))
> (t raw-path)))
>=C2=A0 protocol)
> #############

Indeed. Thank you.

Would you mind preparing a patch with "git format-patch" for corr= ect
attribution? See <http://orgmode.org/worg/org-contribute.html> for=
details.

Regards,

--
Nicolas Goaziou

--001a11346e3cfd6bcb0512d749e0--