From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakob Lombacher Subject: Re: [PATCH] custom port for postgresql Date: Thu, 22 Sep 2016 16:03:47 +0200 Message-ID: References: <87k2earkc9.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b874df2747e64053d192142 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn4cu-00014I-3H for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 10:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn4cp-0006mX-EY for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 10:05:22 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn4cp-0006X2-5h for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 10:05:19 -0400 Received: by mail-wm0-f42.google.com with SMTP id 197so6528924wmk.1 for ; Thu, 22 Sep 2016 07:04:48 -0700 (PDT) In-Reply-To: <87k2earkc9.fsf@saiph.selenimh> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jakob Lombacher , Adam Porter , emacs-orgmode@gnu.org --047d7b874df2747e64053d192142 Content-Type: multipart/alternative; boundary=047d7b874df2747e60053d192140 --047d7b874df2747e60053d192140 Content-Type: text/plain; charset=UTF-8 Hi Nicolas, sure, here you go. All the best Jakob 2016-09-17 10:39 GMT+02:00 Nicolas Goaziou : > Hello, > > Jakob Lombacher writes: > > > I changed the dbport as optional argument and added the dbpassword option > > as well. > > I applied your patch with the modifications below: > > - I added a proper commit message > > - I added TINYCHANGE cookie > > - I reordered dbport argument as in your initial patch. Although the > recommendation of making it optional makes sense, it breaks > consistency with other "dbstring" functions, and this is an internal > function anyway. > > Could you provide an entry for ORG-NEWS file? > > Thank you for the patch. > > Regards, > > -- > Nicolas Goaziou > --047d7b874df2747e60053d192140 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Nicolas,

sure, here you go.

All the best

Jakob

2016-09-17 10:39 GMT+02:00 Nicolas Goaziou <ma= il@nicolasgoaziou.fr>:
Hell= o,

Jakob Lombacher <Jakob@lombacher.= net> writes:

> I changed the dbport as optional argument and added the dbpassword opt= ion
> as well.

I applied your patch with the modifications below:

- I added a proper commit message

- I added TINYCHANGE cookie

- I reordered dbport argument as in your initial patch. Although the
=C2=A0 recommendation of making it optional makes sense, it breaks
=C2=A0 consistency with other "dbstring" functions, and this is a= n internal
=C2=A0 function anyway.

Could you provide an entry for ORG-NEWS file?

Thank you for the patch.

Regards,

--
Nicolas Goaziou

--047d7b874df2747e60053d192140-- --047d7b874df2747e64053d192142 Content-Type: text/x-patch; charset=US-ASCII; name="0001-ORG-NEWS-support-of-header-argument-for-postgresql.patch" Content-Disposition: attachment; filename="0001-ORG-NEWS-support-of-header-argument-for-postgresql.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iteeqf4l0 RnJvbSBkZDk2NGI3YWY5ZWEwODJhNWQ4ZDcxNjMwNTY1ODk5ZGFiZjdhMTE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBMb21iYWNoZXIgPEpha29iQExvbWJhY2hlci5uZXQ+ CkRhdGU6IFRodSwgMjIgU2VwIDIwMTYgMTU6NTk6MzUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBP UkctTkVXUyBzdXBwb3J0IG9mIGhlYWRlciBhcmd1bWVudCBmb3IgcG9zdGdyZXNxbAoKLS0tCiBl dGMvT1JHLU5FV1MgfCA1ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvZXRjL09SRy1ORVdTIGIvZXRjL09SRy1ORVdTCmluZGV4IGVkYTAxOGYuLmRl OTlmN2IgMTAwNjQ0Ci0tLSBhL2V0Yy9PUkctTkVXUworKysgYi9ldGMvT1JHLU5FV1MKQEAgLTMx Nyw2ICszMTcsMTEgQEAgQWxpY2UgPC0tIEJvYjogYW5vdGhlciBhdXRoZW50aWNhdGlvbiBSZXNw b25zZQogUGxlYXNlIG5vdGUgdGhhdCAqcGRmKiAqZG9lcyBub3Qgd29yayBvdXQgb2YgdGhlIGJv eCogYW5kIG5lZWRzcwogYWRkaXRpb25hbCBzZXR1cCBpbiBhZGRpdGlvbiB0byBwbGFudHVtbC4g U2VlCiBbW2h0dHA6Ly9wbGFudHVtbC5jb20vcGRmLmh0bWxdXSBmb3IgZGV0YWlscyBhbmQgc2V0 dXAgaW5mb3JtYXRpb24uCisqKioqIEltcHJvdmVkIHN1cHBvcnQgb2YgaGVhZGVyIGFyZ3VtZW50 cyBmb3IgcG9zdGdyZXNxbCAKKyAgICAgVGhlIHBvc3RncmVzcWwgZW5naW5lIGluIGEgc3FsIGNv ZGUgYmxvY2sgc3VwcG9ydHMgbm93ICo6ZGJwb3J0KgorICAgICBhbmQgKjpkYnBhc3N3b3JkKiBh cyBoZWFkZXIgYXJndW1lbnRzLgorICAgICAKKyAgICAgCiAqKiogUmV3cml0ZSBvZiByYWRpbyBs aXN0cwogUmFkaW8gbGlzdHMsIGkuZSwgT3JnIHBsYWluIGxpc3RzIGluIGZvcmVpZ24gYnVmZmVy cywgaGF2ZSBiZWVuCiByZXdyaXR0ZW4gdG8gYmUgb24gcGFyIHdpdGggUmFkaW8gdGFibGVzLiAg WW91IGNhbiB1c2UgYSBsYXJnZSBzZXQgb2YKLS0gCjIuOC4xCgo= --047d7b874df2747e64053d192142--