From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brice Waegenire Subject: Re: [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes Date: Tue, 2 Jun 2015 23:04:32 +0200 Message-ID: References: <874mo58oa5.fsf@kmlap.domain.org> <87pp6kk7lg.fsf@nicolasgoaziou.fr> <876184i1zx.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1135a66803704f05178f4a90 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YztMR-0002cP-EJ for emacs-orgmode@gnu.org; Tue, 02 Jun 2015 17:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YztMP-0001Mj-VR for emacs-orgmode@gnu.org; Tue, 02 Jun 2015 17:04:35 -0400 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:34034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YztMP-0001Md-PX for emacs-orgmode@gnu.org; Tue, 02 Jun 2015 17:04:33 -0400 Received: by qkoo18 with SMTP id o18so108740237qko.1 for ; Tue, 02 Jun 2015 14:04:33 -0700 (PDT) In-Reply-To: <876184i1zx.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Brice Waegenire , emacs-orgmode@gnu.org --001a1135a66803704f05178f4a90 Content-Type: text/plain; charset=UTF-8 Sorry for the long delayed response. Here is that version of this patch, at least I hope it is. Yes I signed the papers, my number is #1011602. 2015-05-07 22:09 GMT+02:00 Nicolas Goaziou : > Brice Waegenire writes: > >> Thanks for help on this! >> Here is the last version of the patch taking into account all of your >> comments. > > Thank you. > >> (read-from-minibuffer >> - "How many minutes left? " >> - (if (not (eq org-timer-default-timer 0)) >> - (number-to-string org-timer-default-timer)))))) >> + "How much time left? (minutes or h:mm:ss) " >> + (when (not (string-equal org-timer-default-timer "0")) > > Nitpick: `unless' > >> + (eval org-timer-default-timer)))))) > > Since `org-timer-default-timer' is a string, there's no need to eval it. > > BTW, did you sign FSF papers already? If not, you need to add TINYCHANGE > to the end of the commit message. > > > Regards, --001a1135a66803704f05178f4a90 Content-Type: text/x-patch; charset=US-ASCII; name="0001-org-timer.el-hh-mm-ss-format-for-setting-a-timer.patch" Content-Disposition: attachment; filename="0001-org-timer.el-hh-mm-ss-format-for-setting-a-timer.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iaftcfri0 RnJvbSBiNGIyMmNlMTc0ZGQ4ZTFhY2E3ZGU4YTljNzAyOWE2Y2UzZjZkYmQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmljZSBXYWVnZW5laXJlIDxicmljZS53Z2VAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVuIDIwMTUgMjI6NDk6MzggKzAyMDAKU3ViamVjdDogW1BBVENIXSBv cmctdGltZXIuZWw6IGhoOm1tOnNzIGZvcm1hdCBmb3Igc2V0dGluZyBhIHRpbWVyCgoqIGxpc3Av b3JnLXRpbWVyLmVsIChvcmctdGltZXItc2V0LXRpbWVyKTogQWRkIHN1cHBvcnQgZm9yIGhoOm1t OnNzCmZvcm1hdC4KKG9yZy10aW1lci1kZWZhdWx0LXRpbWVyKTogVHlwZSBjaGFuZ2VkIGZyb20g bnVtYmVyIHRvIHN0cmluZy4KKiB0ZXN0aW5nL2xpc3AvdGVzdC1vcmctdGltZXIuZWwgKHRlc3Qt b3JnLXRpbWVyL3NldC10aW1lcik6IEFkZApoaDptbTpzcyBmb3JtYXQgaW4gdGhlIHRlc3QuCi0t LQogbGlzcC9vcmctdGltZXIuZWwgICAgICAgICAgICAgIHwgMjggKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLQogdGVzdGluZy9saXNwL3Rlc3Qtb3JnLXRpbWVyLmVsIHwgIDggKysrKysrKysK IDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGlzcC9vcmctdGltZXIuZWwgYi9saXNwL29yZy10aW1lci5lbAppbmRleCAwNTkz NTczLi5kMjA4MTJmIDEwMDY0NAotLS0gYS9saXNwL29yZy10aW1lci5lbAorKysgYi9saXNwL29y Zy10aW1lci5lbApAQCAtNjUsMTIgKzY1LDEzIEBAIHRoZSB2YWx1ZSBvZiB0aGUgdGltZXIuIgog ICA6Z3JvdXAgJ29yZy10aW1lCiAgIDp0eXBlICdzdHJpbmcpCiAKLShkZWZjdXN0b20gb3JnLXRp bWVyLWRlZmF1bHQtdGltZXIgMAotICAiVGhlIGRlZmF1bHQgdGltZXIgd2hlbiBhIHRpbWVyIGlz IHNldC4KKyhkZWZjdXN0b20gb3JnLXRpbWVyLWRlZmF1bHQtdGltZXIgIjAiCisgICJUaGUgZGVm YXVsdCB0aW1lciB3aGVuIGEgdGltZXIgaXMgc2V0LCBpbiBtaW51dGVzIG9yIGhoOm1tOnNzIGZv cm1hdC4KIFdoZW4gMCwgdGhlIHVzZXIgaXMgcHJvbXB0ZWQgZm9yIGEgdmFsdWUuIgogICA6Z3Jv dXAgJ29yZy10aW1lCi0gIDp2ZXJzaW9uICIyNC4xIgotICA6dHlwZSAnbnVtYmVyKQorICA6dmVy c2lvbiAiMjUuMSIKKyAgOnBhY2thZ2UtdmVyc2lvbiAnKE9yZyAuICI4LjMiKQorICA6dHlwZSAn c3RyaW5nKQogCiAoZGVmY3VzdG9tIG9yZy10aW1lci1kaXNwbGF5ICdtb2RlLWxpbmUKICAgIldo ZW4gYSB0aW1lciBpcyBydW5uaW5nLCBvcmctbW9kZSBjYW4gZGlzcGxheSBpdCBpbiB0aGUgbW9k ZQpAQCAtNDAyLDE0ICs0MDMsMTQgQEAgVkFMVUUgY2FuIGJlIGBvbicsIGBvZmYnLCBvciBgcGF1 c2UnLiIKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBvcmctdGltZXItc2V0LXRpbWVyICgmb3B0 aW9uYWwgb3B0KQotICAiUHJvbXB0IGZvciBhIGR1cmF0aW9uIGFuZCBzZXQgYSB0aW1lci4KKyAg IlByb21wdCBmb3IgYSBkdXJhdGlvbiBpbiBtaW51dGVzIG9yIGhoOm1tOnNzIGFuZCBzZXQgYSB0 aW1lci4KIAogSWYgYG9yZy10aW1lci1kZWZhdWx0LXRpbWVyJyBpcyBub3QgemVybywgc3VnZ2Vz dCB0aGlzIHZhbHVlIGFzCiB0aGUgZGVmYXVsdCBkdXJhdGlvbiBmb3IgdGhlIHRpbWVyLiAgSWYg YSB0aW1lciBpcyBhbHJlYWR5IHNldCwKIHByb21wdCB0aGUgdXNlciBpZiBzaGUgd2FudHMgdG8g cmVwbGFjZSBpdC4KIAogQ2FsbGVkIHdpdGggYSBudW1lcmljIHByZWZpeCBhcmd1bWVudCwgdXNl IHRoaXMgbnVtZXJpYyB2YWx1ZSBhcwotdGhlIGR1cmF0aW9uIG9mIHRoZSB0aW1lci4KK3RoZSBk dXJhdGlvbiBvZiB0aGUgdGltZXIgaW4gbWludXRlcy4KIAogQ2FsbGVkIHdpdGggYSBgQy11JyBw cmVmaXggYXJndW1lbnRzLCB1c2UgYG9yZy10aW1lci1kZWZhdWx0LXRpbWVyJwogd2l0aG91dCBw cm9tcHRpbmcgdGhlIHVzZXIgZm9yIGEgZHVyYXRpb24uCkBAIC00MzAsMTYgKzQzMSwxNyBAQCB1 c2luZyB0aHJlZSBgQy11JyBwcmVmaXggYXJndW1lbnRzLiIKIAkJCSAgIGVmZm9ydC1taW51dGVz CiAJCQkgICAobnVtYmVyLXRvLXN0cmluZyBlZmZvcnQtbWludXRlcykpCiAJCSAgICAgKGFuZCAo bnVtYmVycCBvcHQpIChudW1iZXItdG8tc3RyaW5nIG9wdCkpCi0JCSAgICAgKGFuZCAobGlzdHAg b3B0KSAobm90IChudWxsIG9wdCkpCi0JCQkgIChudW1iZXItdG8tc3RyaW5nIG9yZy10aW1lci1k ZWZhdWx0LXRpbWVyKSkKKwkJICAgICAoYW5kIChjb25zcCBvcHQpIG9yZy10aW1lci1kZWZhdWx0 LXRpbWVyKQorCQkgICAgIChhbmQgKHN0cmluZ3Agb3B0KSBvcHQpCiAJCSAgICAgKHJlYWQtZnJv bS1taW5pYnVmZmVyCi0JCSAgICAgICJIb3cgbWFueSBtaW51dGVzIGxlZnQ/ICIKLQkJICAgICAg KGlmIChub3QgKGVxIG9yZy10aW1lci1kZWZhdWx0LXRpbWVyIDApKQotCQkJICAobnVtYmVyLXRv LXN0cmluZyBvcmctdGltZXItZGVmYXVsdC10aW1lcikpKSkpKQorCQkgICAgICAiSG93IG11Y2gg dGltZSBsZWZ0PyAobWludXRlcyBvciBoOm1tOnNzKSAiCisJCSAgICAgICh1bmxlc3MgKG5vdCAo c3RyaW5nLWVxdWFsIG9yZy10aW1lci1kZWZhdWx0LXRpbWVyICIwIikpCisJCQkgIChvcmctdGlt ZXItZGVmYXVsdC10aW1lcikpKSkpKQorICAgICh3aGVuIChzdHJpbmctbWF0Y2ggIlxcYFswLTld K1xcJyIgbWludXRlcykKKwkoc2V0cSBtaW51dGVzIChjb25jYXQgbWludXRlcyAiOjAwIikpKQog ICAgIChpZiAobm90IChzdHJpbmctbWF0Y2ggIlswLTldKyIgbWludXRlcykpCiAJKG9yZy10aW1l ci1zaG93LXJlbWFpbmluZy10aW1lKQotICAgICAgKGxldCogKChtaW5zIChzdHJpbmctdG8tbnVt YmVyIChtYXRjaC1zdHJpbmcgMCBtaW51dGVzKSkpCi0JICAgICAoc2VjcyAoKiBtaW5zIDYwKSkK KyAgICAgIChsZXQgKChzZWNzIChvcmctdGltZXItaG1zLXRvLXNlY3MgKG9yZy10aW1lci1maXgt aW5jb21wbGV0ZSBtaW51dGVzKSkpCiAJICAgICAoaGwgKG9yZy10aW1lci0tZ2V0LXRpbWVyLXRp dGxlKSkpCiAJKGlmIChvciAobm90IG9yZy10aW1lci1jb3VudGRvd24tdGltZXIpCiAJCShlcXVh bCBvcHQgJygxNikpCmRpZmYgLS1naXQgYS90ZXN0aW5nL2xpc3AvdGVzdC1vcmctdGltZXIuZWwg Yi90ZXN0aW5nL2xpc3AvdGVzdC1vcmctdGltZXIuZWwKaW5kZXggNzE2NGE1ZC4uOGFiYmI4NSAx MDA2NDQKLS0tIGEvdGVzdGluZy9saXNwL3Rlc3Qtb3JnLXRpbWVyLmVsCisrKyBiL3Rlc3Rpbmcv bGlzcC90ZXN0LW9yZy10aW1lci5lbApAQCAtMTc4LDYgKzE3OCwxNCBAQCBBbHNvLCBtdXRlIG91 dHB1dCBmcm9tIGBtZXNzYWdlJy4iCiAJICAgICAgKG9yZy10aW1lci1zZXQtdGltZXIgMTApKQog CSAgICAodGVzdC1vcmctdGltZXIvd2l0aC1jdXJyZW50LXRpbWUgdGVzdC1vcmctdGltZXIvdGlt ZTEKIAkgICAgICAob3JnLXRpbWVyKSkKKwkgICAgKG9yZy10cmltIChidWZmZXItc3RyaW5nKSkp KSkKKyAgKHNob3VsZAorICAgKGVxdWFsICIwOjAwOjA0IgorCSAgKHRlc3Qtb3JnLXRpbWVyL3dp dGgtdGVtcC10ZXh0ICIiCisJICAgICh0ZXN0LW9yZy10aW1lci93aXRoLWN1cnJlbnQtdGltZSB0 ZXN0LW9yZy10aW1lci90aW1lMAorCSAgICAgIChvcmctdGltZXItc2V0LXRpbWVyICIzOjMwIikp CisJICAgICh0ZXN0LW9yZy10aW1lci93aXRoLWN1cnJlbnQtdGltZSB0ZXN0LW9yZy10aW1lci90 aW1lMQorCSAgICAgIChvcmctdGltZXIpKQogCSAgICAob3JnLXRyaW0gKGJ1ZmZlci1zdHJpbmcp KSkpKSkKIAogKGVydC1kZWZ0ZXN0IHRlc3Qtb3JnLXRpbWVyL3BhdXNlLXRpbWVyICgpCi0tIAoy LjQuMgoK --001a1135a66803704f05178f4a90--