emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: stardiviner <numbchild@gmail.com>
To: Org-mode <emacs-orgmode@gnu.org>
Subject: [SUGGESTION] Let org-set-tags-command TAB complete with more tags.
Date: Sat, 14 Nov 2020 14:15:14 +0800	[thread overview]
Message-ID: <CAL1eYuLS5htAgAK_6uueUooTqkgE8GuhVgs4i6if59XtdH8kww@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

Currently press [TAB] key in `org-set-tags-command` will provide current
buffer tags as completion candidates. This is very less.
 I suggest providing all tags in candidates.
Here is a modification.

#+begin_src diff
modified   lisp/org.el
@@ -12254,12 +12254,7 @@ (defun org-fast-tag-selection (current inherited
table &optional todo-table)
     (when exit-after-next (setq exit-after-next 'now)))
    ((= c ?\t)
     (condition-case nil
- (setq tg (completing-read
-  "Tag: "
-  (or buffer-tags
-      (with-current-buffer buf
- (setq buffer-tags
-      (org-get-buffer-tags))))))
+ (setq tg (completing-read "Tag: " (org-global-tags-completion-table)))
       (quit (setq tg "")))
     (when (string-match "\\S-" tg)
       (cl-pushnew (list tg) buffer-tags :test #'equal)
#+end_src

The Org Mode has `org-tag-alist` for user to setting default fast-selection
tags group. I don't know whether function
`(org-global-tags-completion-table)` already merged with `org-tag-alist`.
It seems only get tags from all Agenda files after I checked out its source
code.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

[-- Attachment #2: Type: text/html, Size: 2390 bytes --]

                 reply	other threads:[~2020-11-14  6:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL1eYuLS5htAgAK_6uueUooTqkgE8GuhVgs4i6if59XtdH8kww@mail.gmail.com \
    --to=numbchild@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).