From: "numbchild@gmail.com" <numbchild@gmail.com>
To: "numbchild@gmail.com" <numbchild@gmail.com>,
Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] improve ol-man.el with occur searching
Date: Mon, 31 Aug 2020 18:34:27 +0800 [thread overview]
Message-ID: <CAL1eYuJH9F_MA3xFMaaGtt+vsdaj4YuN95PVmu9jGspUb6CEbQ@mail.gmail.com> (raw)
In-Reply-To: <CAL1eYuLKjo9YAdzfTgjb7fELJfC92VPNxaKiBSr5KXTBLmftbQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]
Hi, Nicolas, gentle ping about this patch.
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Mon, Aug 17, 2020 at 11:22 AM numbchild@gmail.com <numbchild@gmail.com>
wrote:
> Thanks for reviewing my code and points. :)
> Fixed in this attached patch.
>
> [stardiviner] <Hack this world!> GPG key ID: 47C32433
> IRC(freeenode): stardiviner Twitter: @numbchild
> Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
> Blog: http://stardiviner.github.io/
>
>
> On Sun, Aug 16, 2020 at 5:54 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
>
>> Hello,
>>
>> "numbchild@gmail.com" <numbchild@gmail.com> writes:
>>
>> > With this patch, ol-man.el link type can be a link like this:
>> > ```org
>> > [[man:grep::--extended-regexp][grep --extended-regexp]]
>> > ```
>> > Occur will auto search "--extended-regexp" string in man page buffer.
>>
>> Thanks.
>>
>> > +PATH should be a topic that can be thrown at the man command.
>> > +If PATH contains extra ::STRING which will use `occur' to search
>> > +matched strings in man buffer."
>>
>> > + (string-match "\\(.*?\\)\\(?:::\\(.*\\)\\)?$" path)
>> > + (let* ((command (match-string 1 path))
>> > + (search (match-string 2 path)))
>> > + (funcall org-man-command command)
>> > + (with-current-buffer (concat "*Man " command "*")
>>
>> This should only be called if search is non-empty.
>>
>> > + (occur search))))
>>
>> Why occur? Org uses `search-forward' for [[foo.org::text]] text links,
>> and uses `occur' with [[foo.org::/text/]] links.
>>
>> Wouldn't it be more idiomatic to use a regular text search here?
>>
>> Regards,
>> --
>> Nicolas Goaziou
>>
>
[-- Attachment #2: Type: text/html, Size: 3634 bytes --]
next prev parent reply other threads:[~2020-08-31 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 4:41 [PATCH] improve ol-man.el with occur searching numbchild
2020-08-16 9:54 ` Nicolas Goaziou
2020-08-17 3:22 ` numbchild
2020-08-31 10:34 ` numbchild [this message]
2020-09-05 8:05 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL1eYuJH9F_MA3xFMaaGtt+vsdaj4YuN95PVmu9jGspUb6CEbQ@mail.gmail.com \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).