From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: Add ob-sclang.el for sclang Org-mode babel support in contrib/ Date: Sun, 11 Jun 2017 10:02:02 +0800 Message-ID: References: <87ink4z27l.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1144e55c7bf9110551a598ed" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJsD9-0003Y2-CX for emacs-orgmode@gnu.org; Sat, 10 Jun 2017 22:02:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJsD8-00057M-1p for emacs-orgmode@gnu.org; Sat, 10 Jun 2017 22:02:39 -0400 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:36574) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dJsD7-00056y-NY for emacs-orgmode@gnu.org; Sat, 10 Jun 2017 22:02:37 -0400 Received: by mail-wr0-x230.google.com with SMTP id v111so64607733wrc.3 for ; Sat, 10 Jun 2017 19:02:34 -0700 (PDT) In-Reply-To: <87ink4z27l.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org-mode --001a1144e55c7bf9110551a598ed Content-Type: text/plain; charset="UTF-8" Yeah, I have used to contrib to org-mode, but need to sign FSF papers spend my time, and I don't know how. So I decide to move code in `contrib/`. When I back home, I will try to sign FSF papers, because I have time and fixed location. If I move code into `contrib/`, do I need to do more in this code? I will add `lexical-binding`, but don't know how to write test for this. Could org-mode team pull branch code on my github repo directory? Or should I send a patch from `git format-patch`? [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Sat, Jun 10, 2017 at 4:17 PM, Nicolas Goaziou wrote: > Hello, > > "numbchild@gmail.com" writes: > > > Here is my branch > > https://github.com/stardiviner/org-mode/tree/feature/ob-sclang > > Merge this branch? > > Thank you for your work. > > I'd like to refrain more packages to contrib, unless the intent is to > eventually merge them into core later. > > However, I think this can go into core. Would you like to clean it up > a bit, activate lexical-binding, provide some tests, and send a patch > (using git format-patch)? > > You will need to sign FSF papers to do that, if you haven't done > already. If you are willing to do this, we can also move your library to > "contrib/" temporarily. > > Regards, > > -- > Nicolas Goaziou > --001a1144e55c7bf9110551a598ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yeah, I have used to contrib to org-mode, but need to sign= FSF papers spend my time, and I don't know how. So I decide to move co= de in `contrib/`.
When I back home, I will try to sign FSF papers, bec= ause I have time and fixed location.
If I move code into `contrib/`, d= o I need to do more in this code?
I will add `lexical-binding`, but = don't know how to write test for this.
Could org-mode team pull br= anch code on my github repo directory? Or should I send a patch from `git f= ormat-patch`?

=
[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner =C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fingerprint= =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.g= ithub.io/

On Sat, Jun 10, 2017 at 4:17 PM, Nicolas Goa= ziou <mail@nicolasgoaziou.fr> wrote:
Hello,

"numbchild@gmail.com" = <numbchild@gmail.com> writ= es:

> Here is my branch
> https://github.com/stardivin= er/org-mode/tree/feature/ob-sclang
> Merge this branch?

Thank you for your work.

I'd like to refrain more packages to contrib, unless the intent is to eventually merge them into core later.

However, I think this can go into core. Would you like to clean it up
a bit, activate lexical-binding, provide some tests, and send a patch
(using git format-patch)?

You will need to sign FSF papers to do that, if you haven't done
already. If you are willing to do this, we can also move your library to "contrib/" temporarily.

Regards,

--
Nicolas Goaziou

--001a1144e55c7bf9110551a598ed--