From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: ob-shell and remote shells Date: Wed, 29 Nov 2017 14:17:18 +0800 Message-ID: References: <87609ug5ae.fsf@luisa.c0t0d0s0.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113d5386419538055f1918b9" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJvgt-0006Il-OA for emacs-orgmode@gnu.org; Wed, 29 Nov 2017 01:17:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJvgs-0006N0-Hc for emacs-orgmode@gnu.org; Wed, 29 Nov 2017 01:17:51 -0500 Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:39423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJvgs-0006Mw-7b for emacs-orgmode@gnu.org; Wed, 29 Nov 2017 01:17:50 -0500 Received: by mail-oi0-x230.google.com with SMTP id r63so1681984oia.6 for ; Tue, 28 Nov 2017 22:17:50 -0800 (PST) In-Reply-To: <87609ug5ae.fsf@luisa.c0t0d0s0.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Michael Welle Cc: Org-mode --001a113d5386419538055f1918b9 Content-Type: text/plain; charset="UTF-8" Off the topic, I'm curious what is the `:session` in `ob-shell` ? [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Tue, Nov 28, 2017 at 4:45 PM, Michael Welle wrote: > Hello, > > I want to execute shell blocks like follows: > > #+BEGIN_SRC shell :session n42 :dir /127.0.0.1: :shebang "#!/bin/bash" > echo los > echo $SHELL > echo $BASH > echo ready > #+end_src > > The trouble is that the shebang property doesn't work in this case. The > script is executed with the login shell of the user and fails because of > syntax errors (for instance, if bashisms are used in the script). > > With my minimal and dangerous knowledge about Org's source code ;), I > think the following might work (from ob-shell.el): > > (defun org-babel-sh-initiate-session (&optional session _params) > "Initiate a session named SESSION according to PARAMS." > (when (and session (not (string= session "none"))) > (save-window-excursion > (or (org-babel-comint-buffer-livep session) > (progn > (let ((explicit-shell-file-name (xxx))) > (shell session)) > ;; Needed for Emacs 23 since the marker is initially > ;; undefined and the filter functions try to use it without > ;; checking. > (set-marker comint-last-output-start (point)) > (get-buffer (current-buffer))))))) > > > Note the let form. Further tasks that have to be done is to add the > shebang key to _params, which I hope is available at all places where > o-b-s-i-s is evaluated. Further at (xxx) a regexp etc. is needed to > transform the shebang line to a shell path suitable for e-s-f-n. > > Any opinions, please? Depending on the opinions I will implement the > approach this week and see if it works as expected. > > Regards > hmw > > --001a113d5386419538055f1918b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Off the topic, I'm curious what is the `:session` in `= ob-shell` ?

[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner =C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fingerprint= =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.g= ithub.io/

On Tue, Nov 28, 2017 at 4:45 PM, Michael Wel= le <mwe012008@gmx.net> wrote:
Hello,

I want to execute shell blocks like follows:

#+BEGIN_SRC shell :session n42 :dir /127.0.0.1: :shebang "#!/bin/bash"=
echo los
echo $SHELL
echo $BASH
echo ready
#+end_src

The trouble is that the shebang property doesn't work in this case. The=
script is executed with the login shell of the user and fails because of syntax errors (for instance, if bashisms are used in the script).

With my minimal and dangerous knowledge about Org's source code ;), I think the following might work (from ob-shell.el):

(defun org-babel-sh-initiate-session (&optional session _params)
=C2=A0 "Initiate a session named SESSION according to PARAMS." =C2=A0 (when (and session (not (string=3D session "none")))
=C2=A0 =C2=A0 (save-window-excursion
=C2=A0 =C2=A0 =C2=A0 (or (org-babel-comint-buffer-livep session)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (progn
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((explicit-shell-file-name (= xxx)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (shell session))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Needed for Emacs 23 since the = marker is initially
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; undefined and the filter funct= ions try to use it without
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; checking.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (set-marker comint-last-output-st= art (point))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (get-buffer (current-buffer))))))= )


Note the let form. Further tasks that have to be done is to add the
shebang key to _params, which I hope is available at all places where
o-b-s-i-s is evaluated. Further at (xxx) a regexp etc. is needed to
transform the shebang line to a shell path suitable for e-s-f-n.

Any opinions, please? Depending on the opinions I will implement the
approach this week and see if it works as expected.

Regards
hmw


--001a113d5386419538055f1918b9--