From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Jerram Subject: Re: Capture with date prompt defaults to yesterday Date: Tue, 11 Jun 2019 09:53:09 +0100 Message-ID: References: <87imth5bh5.fsf@nicolasgoaziou.fr> <87ef41lrqg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c10623058b086d9a" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:57368) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hacX1-0004fv-E3 for emacs-orgmode@gnu.org; Tue, 11 Jun 2019 04:53:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hacWz-0006rs-SV for emacs-orgmode@gnu.org; Tue, 11 Jun 2019 04:53:27 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:38771) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hacWz-0006nZ-Il for emacs-orgmode@gnu.org; Tue, 11 Jun 2019 04:53:25 -0400 Received: by mail-lf1-x130.google.com with SMTP id b11so8665373lfa.5 for ; Tue, 11 Jun 2019 01:53:22 -0700 (PDT) In-Reply-To: <87ef41lrqg.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Neil Jerram , Org Mode List --000000000000c10623058b086d9a Content-Type: text/plain; charset="UTF-8" On Mon, 10 Jun 2019, 10:22 Nicolas Goaziou, wrote: > Hello, > > Neil Jerram writes: > > > Yes, it does make the default time noon. But AFAICS the time of day > > doesn't actually matter in any of the Org source code where the result of > > org-get-cursor-date is used. Have I missed a case where it does > > matter? > > Probably not. I didn't check. But this could become a future gotcha. > > > However, in the attached patch I've revised that so that the default time > > of day is :00am, i.e. it's the earliest time that > > Org treats as being that date. WDYT? > > I think this is better. I applied your patch. Thank you. > > > Alternatively, we could refactor the code around where > org-get-cursor-date > > is used to make it more explicit when the time of day doesn't matter, and > > look further if there are any cases where it does. > > I think the current state is sufficient. > > Regards, > > -- > Nicolas Goaziou > Thanks Nicolas! Neil --000000000000c10623058b086d9a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, 10 Jun 2019, 10:22 Nicolas Goaziou, <mail@nicolasgoaziou.fr> wrote:
=
Hello,

Neil Jerram <neiljerram@gmail.com> writes:

> Yes, it does make the default time noon.=C2=A0 But AFAICS the time of = day
> doesn't actually matter in any of the Org source code where the re= sult of
> org-get-cursor-date is used.=C2=A0 Have I missed a case where it does<= br> > matter?

Probably not. I didn't check. But this could become a future gotcha.
> However, in the attached patch I've revised that so that the defau= lt time
> of day is <org-extend-today-until>:00am, i.e. it's the earli= est time that
> Org treats as being that date.=C2=A0 WDYT?

I think this is better. I applied your patch. Thank you.

> Alternatively, we could refactor the code around where org-get-cursor-= date
> is used to make it more explicit when the time of day doesn't matt= er, and
> look further if there are any cases where it does.

I think the current state is sufficient.

Regards,

--
Nicolas Goaziou

Thanks Nicolas!
=C2=A0 =C2=A0 =C2=A0 = =C2=A0Neil

--000000000000c10623058b086d9a--