From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Jerram Subject: Re: Capture with date prompt defaults to yesterday Date: Sun, 9 Jun 2019 11:40:53 +0100 Message-ID: References: <87imth5bh5.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000005dcd65058ae1b3a0" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:48831) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZvGE-0001Id-Dy for emacs-orgmode@gnu.org; Sun, 09 Jun 2019 06:41:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZvGC-0001t6-9B for emacs-orgmode@gnu.org; Sun, 09 Jun 2019 06:41:14 -0400 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:46377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZvGA-0001py-93 for emacs-orgmode@gnu.org; Sun, 09 Jun 2019 06:41:12 -0400 Received: by mail-lj1-x22f.google.com with SMTP id v24so997867ljg.13 for ; Sun, 09 Jun 2019 03:41:06 -0700 (PDT) In-Reply-To: <87imth5bh5.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Neil Jerram , Org Mode List --0000000000005dcd65058ae1b3a0 Content-Type: multipart/alternative; boundary="0000000000005dcd62058ae1b39e" --0000000000005dcd62058ae1b39e Content-Type: text/plain; charset="UTF-8" On Fri, 7 Jun 2019 at 22:31, Nicolas Goaziou wrote: > Hello, > > Neil Jerram writes: > > > Nicolas, I hope you don't mind me sending a 'ping' for this, as it looks > > like it might have got lost. Please do let me know what you think. > > I'm not sure this is a right fix. Doesn't it force default times to noon > instead of midnight? I think default times should be midnight. > Yes, it does make the default time noon. But AFAICS the time of day doesn't actually matter in any of the Org source code where the result of org-get-cursor-date is used. Have I missed a case where it does matter? However, in the attached patch I've revised that so that the default time of day is :00am, i.e. it's the earliest time that Org treats as being that date. WDYT? Alternatively, we could refactor the code around where org-get-cursor-date is used to make it more explicit when the time of day doesn't matter, and look further if there are any cases where it does. Best wishes, Neil --0000000000005dcd62058ae1b39e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, 7 Jun 2019 at 22:31, Nicolas Goaz= iou <mail@nicolasgoaziou.fr> wrote:
Hello,

Neil Jerram <n= eiljerram@gmail.com> writes:

> Nicolas, I hope you don't mind me sending a 'ping' for thi= s, as it looks
> like it might have got lost.=C2=A0 Please do let me know what you thin= k.

I'm not sure this is a right fix. Doesn't it force default times to= noon
instead of midnight? I think default times should be midnight.

Yes, it does make the default time noon.=C2=A0 But = AFAICS the time of day doesn't actually matter in any of the Org source= code where the result of org-get-cursor-date is used.=C2=A0 Have I missed = a case where it does matter?
=C2=A0
However, in the att= ached patch I've revised that so that the default time of day is <or= g-extend-today-until>:00am, i.e. it's the earliest time that Org tre= ats as being that date.=C2=A0 WDYT?

Alternatively,= we could refactor the code around where=C2=A0org-get-cursor-date is used t= o make it more explicit when the time of day doesn't matter, and look f= urther if there are any cases where it does.

Best = wishes,
=C2=A0 =C2=A0 Neil

--0000000000005dcd62058ae1b39e-- --0000000000005dcd65058ae1b3a0 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-capture-s-idea-of-the-current-day-more-intuitiv.patch" Content-Disposition: attachment; filename="0001-Make-capture-s-idea-of-the-current-day-more-intuitiv.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwotgz220 RnJvbSA0OGIzNDJiYmQ4Yzk3YmYyNDIxNGI1N2UwNGQ2ZDU5MTA4MzIwYmEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOZWlsIEplcnJhbSA8bmVpbEB0aWdlcmEuaW8+CkRhdGU6IFR1 ZSwgMjggTWF5IDIwMTkgMjE6MDE6MTcgKzAxMDAKU3ViamVjdDogW1BBVENIXSBNYWtlIGNhcHR1 cmUncyBpZGVhIG9mIHRoZSBjdXJyZW50IGRheSBtb3JlIGludHVpdGl2ZQoKLS0tCiBsaXNwL29y Zy5lbCB8IDggKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vcmcuZWwgYi9saXNwL29yZy5lbAppbmRleCBj Njg2MWRjOWEuLjZhZjk3YjM0OCAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9v cmcuZWwKQEAgLTE4OTM2LDcgKzE4OTM2LDkgQEAgUmV0dXJucyB0aGUgbnVtYmVyIG9mIGVtcHR5 IGxpbmVzIHBhc3NlZC4iCiBUaGlzIHdvcmtzIGluIHRoZSBjYWxlbmRhciBhbmQgaW4gdGhlIGFn ZW5kYSwgYW55d2hlcmUgZWxzZSBpdCBqdXN0CiByZXR1cm5zIHRoZSBjdXJyZW50IHRpbWUuCiBJ ZiBXSVRILVRJTUUgaXMgbm9uLW5pbCwgcmV0dXJucyB0aGUgdGltZSBvZiB0aGUgZXZlbnQgYXQg cG9pbnQgKGluCi10aGUgYWdlbmRhKSBvciB0aGUgY3VycmVudCB0aW1lIG9mIHRoZSBkYXkuIgor dGhlIGFnZW5kYSkgb3IgdGhlIGN1cnJlbnQgdGltZSBvZiB0aGUgZGF5OyBvdGhlcndpc2UgcmV0 dXJucyB0aGUKK2VhcmxpZXN0IHRpbWUgb24gdGhlIGN1cnNvciBkYXRlIHRoYXQgT3JnIHRyZWF0 cyBhcyB0aGF0IGRhdGUKKyhiZWFyaW5nIGluIG1pbmQgYG9yZy1leHRlbmQtdG9kYXktdW50aWwn KS4iCiAgIChsZXQgKGRhdGUgZGF5IGRlZmQgdHAgaG9kIG1vZCkKICAgICAod2hlbiB3aXRoLXRp bWUKICAgICAgIChzZXRxIHRwIChnZXQtdGV4dC1wcm9wZXJ0eSAocG9pbnQpICd0aW1lKSkKQEAg LTE4OTQ5LDEzICsxODk1MSwxMyBAQCB0aGUgYWdlbmRhKSBvciB0aGUgY3VycmVudCB0aW1lIG9m IHRoZSBkYXkuIgogICAgIChjb25kCiAgICAgICgoZXEgbWFqb3ItbW9kZSAnY2FsZW5kYXItbW9k ZSkKICAgICAgIChzZXRxIGRhdGUgKGNhbGVuZGFyLWN1cnNvci10by1kYXRlKQotCSAgICBkZWZk IChlbmNvZGUtdGltZSAwIChvciBtb2QgMCkgKG9yIGhvZCAwKQorCSAgICBkZWZkIChlbmNvZGUt dGltZSAwIChvciBtb2QgMCkgKG9yIGhvZCBvcmctZXh0ZW5kLXRvZGF5LXVudGlsKQogCQkJICAg ICAgKG50aCAxIGRhdGUpIChudGggMCBkYXRlKSAobnRoIDIgZGF0ZSkpKSkKICAgICAgKChlcSBt YWpvci1tb2RlICdvcmctYWdlbmRhLW1vZGUpCiAgICAgICAoc2V0cSBkYXkgKGdldC10ZXh0LXBy b3BlcnR5IChwb2ludCkgJ2RheSkpCiAgICAgICAod2hlbiBkYXkKIAkoc2V0cSBkYXRlIChjYWxl bmRhci1ncmVnb3JpYW4tZnJvbS1hYnNvbHV0ZSBkYXkpCi0JICAgICAgZGVmZCAoZW5jb2RlLXRp bWUgMCAob3IgbW9kIDApIChvciBob2QgMCkKKwkgICAgICBkZWZkIChlbmNvZGUtdGltZSAwIChv ciBtb2QgMCkgKG9yIGhvZCBvcmctZXh0ZW5kLXRvZGF5LXVudGlsKQogCQkJCShudGggMSBkYXRl KSAobnRoIDAgZGF0ZSkgKG50aCAyIGRhdGUpKSkpKSkKICAgICAob3IgZGVmZCAoY3VycmVudC10 aW1lKSkpKQogCi0tIAoyLjE3LjEKCg== --0000000000005dcd65058ae1b3a0--