From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Beffa Subject: Re: [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line Date: Sat, 16 Aug 2014 09:50:07 +0200 Message-ID: References: <87mwbbp45b.fsf@nicolasgoaziou.fr> <874mxiizgg.fsf@gmx.us> <87lhqubvtd.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIYkb-0000Do-OS for emacs-orgmode@gnu.org; Sat, 16 Aug 2014 03:50:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XIYka-00045e-Qf for emacs-orgmode@gnu.org; Sat, 16 Aug 2014 03:50:09 -0400 Received: from mail-yk0-x22b.google.com ([2607:f8b0:4002:c07::22b]:36862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIYka-00045a-L7 for emacs-orgmode@gnu.org; Sat, 16 Aug 2014 03:50:08 -0400 Received: by mail-yk0-f171.google.com with SMTP id 19so2822778ykq.2 for ; Sat, 16 Aug 2014 00:50:08 -0700 (PDT) In-Reply-To: <87lhqubvtd.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus , emacs-orgmode@gnu.org, Nicolas Goaziou On Mon, Aug 11, 2014 at 10:44 PM, Nicolas Goaziou wrote: > Rasmus writes: > >> How about adding the possibility to add hooks to org-fill-paragraph? >> So that people can add "extensions" to fill as they want and the core >> function can rely on org-element only? > > You can `defadvice' anything to your heart's content. > >From the elisp manual: "... Advising a function can cause confusion in debugging, since people who debug calls to the original function may not notice that it has been modified with advice. Therefore, if you have the possibility to change the code of that function to run a hook, please solve the problem that way. ..." Given that people have different opinions on this, a hook would actually be a good idea. It would give more freedom to the users. Isn't this the goal of the GNU project :-) Regards, Fede