From: Dan Drake <dan.drake@gmail.com>
To: "Rudolf Adamkovič" <rudolf@adamkovic.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-cut-subtree should respect org-ctrl-k-protect-subtree
Date: Wed, 28 Aug 2024 06:46:26 -0500 [thread overview]
Message-ID: <CAKqbAeEYY1ymE6UyyrR_RMh1SmQHb4RSrAGQ2rF1WoMmXdZgUw@mail.gmail.com> (raw)
In-Reply-To: <m25xrmoxw0.fsf@adamkovic.org>
I agree, a function that examines the "protect subtree" variable and
performs the logic is best. I can work on that.
What do you think we should have for the new name for
org-ctrl-k-protect-subtree? Just "org-protect-subtree"?
How do we handle renaming the variable? We'd want some way of
deprecating the old one and so on.
On Tue, Aug 27, 2024 at 9:15 AM Rudolf Adamkovič <rudolf@adamkovic.org> wrote:
>
> Dan Drake <dan.drake@gmail.com> writes:
>
> > I took at look at the source code, and it seems like a trivial change
> > to make these two things act consistently: [...]
>
> Dan,
>
> Thank you for reporting the bug and even prototyping a solution.
>
> I think the logic should be
>
> extracted into a function,
>
> and tested on all paths:
>
> - `org-kill-note-or-show-branches' (`C-c C-k'),
> - `org-cut-subtree' (`k' on first *) and
> - `org-kill-line' (`C-k').
>
> However, we should then also rename
>
> `org-ctrl-k-protect-subtree'
>
> to something more general, like
>
> `org-protect-subtrees',
>
> as it applies beyond "ctrl-k".
>
> Rudy
> --
> "The whole science is nothing more than a refinement of everyday
> thinking." --- Albert Einstein, 1879-1955
>
> Rudolf Adamkovič <rudolf@adamkovic.org> [he/him]
> http://adamkovic.org
--
Ceci n'est pas une .signature.
next prev parent reply other threads:[~2024-08-28 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 13:10 org-cut-subtree should respect org-ctrl-k-protect-subtree Dan Drake
2024-08-27 14:15 ` Rudolf Adamkovič
2024-08-28 11:46 ` Dan Drake [this message]
2024-08-29 10:39 ` Rudolf Adamkovič
2024-09-01 16:20 ` Ihor Radchenko
2024-09-01 18:49 ` Dan Drake
2024-09-15 12:46 ` Ihor Radchenko
2024-09-17 23:36 ` Dan Drake
2024-10-20 12:46 ` Ihor Radchenko
2024-09-03 23:09 ` Rudolf Adamkovič
2024-09-22 16:35 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKqbAeEYY1ymE6UyyrR_RMh1SmQHb4RSrAGQ2rF1WoMmXdZgUw@mail.gmail.com \
--to=dan.drake@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=rudolf@adamkovic.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).