From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henning Weiss Subject: Re: [PATCH] org-mobile agenda title Date: Wed, 5 Dec 2012 14:10:01 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=90e6ba614f8c42e31904d01ab369 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:38322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgEjt-0005RN-07 for emacs-orgmode@gnu.org; Wed, 05 Dec 2012 08:10:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgEjk-0000ab-HT for emacs-orgmode@gnu.org; Wed, 05 Dec 2012 08:10:12 -0500 Received: from mail-ie0-f169.google.com ([209.85.223.169]:34163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgEjk-0000XN-8A for emacs-orgmode@gnu.org; Wed, 05 Dec 2012 08:10:04 -0500 Received: by mail-ie0-f169.google.com with SMTP id c14so9331694ieb.0 for ; Wed, 05 Dec 2012 05:10:02 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --90e6ba614f8c42e31904d01ab369 Content-Type: multipart/alternative; boundary=90e6ba614f8c42e30e04d01ab367 --90e6ba614f8c42e30e04d01ab367 Content-Type: text/plain; charset=ISO-8859-1 Hi, I was wondering why this patch was reversed in master. An updated version of the patch is attached, and a discussion of what it does is below. Henning On Wed, Jan 25, 2012 at 10:21 PM, Henning Weiss wrote: > Hi everyone, > > I have been working on a patch for mobileorg-androidthat improves the displaying of the generated > agendas.org file. The problem I'm having is that TITLE: fields of all > entries are generated by concatenating the name and the matching criterion > of an entry. The issue is discussed in further details here > . > > I have tried to create a patch that removes the match criterions from the > generated title entry and attached it below. This could potentially break > other org-mobile clients and might not be the best way to solve this. > > What would it take to include this in orgmode? > > best regards, > Henning Weiss > > diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el > index 541ccc8..82320c7 100644 > --- a/lisp/org-mobile.el > +++ b/lisp/org-mobile.el > @@ -592,7 +592,7 @@ The table of checksums is written to the file > mobile-checksums." > (cons (list 'org-agenda-title-append > (concat "KEYS=" gkey "#" (number-to-string > (setq cnt (1+ cnt))) > - " TITLE: " gdesc " " match "")) > + " TITLE: " gdesc "")) > settings)) > (push (list type match settings) new))))) > (and new (list "X" "SUMO" (reverse new) > --90e6ba614f8c42e30e04d01ab367 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi,

I was wondering why this patch was reversed in maste= r. An updated version of the patch is attached, and a discussion of what it= does is below.

Henning

On Wed, Jan 25, 2012 at 10:21 PM, Henning Weiss <hdweiss@gmail.com>= wrote:
Hi everyone,

I have been working on a patch for mobileo= rg-android that improves the displaying of the generated agendas.org file. The problem I'= m having is that TITLE: fields of all entries are generated by=A0concatenat= ing=A0the name and the matching criterion of an entry. The issue is discuss= ed in further details=A0here.

I have tried to create a patch that removes the match c= riterions from the generated title entry and attached it below. This could = potentially break other org-mobile clients and might not be the best way to= solve this.

What would it take to include this in orgmode?

best regards,
Henning Weiss

=
diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 541ccc8..82320c7 100644
--- a/lisp/org-mobile.el
= +++ b/lisp/org-mobile.el
@@ -592,7 +592,7 @@ The table of checksu= ms is written to the file mobile-checksums."
=A0 (cons (list 'org-agenda-title-append=
=A0 =A0 =A0(concat &quo= t;<after>KEYS=3D" gkey "#" (number-to-string
=A0 =A0 =A0 =A0(setq cnt= (1+ cnt)))
- =A0 =A0" TITLE:= " gdesc " " match "</after>"))
+<= span style=3D"white-space:pre-wrap"> =A0 =A0" TITLE: "= gdesc "</after>"))
=A0 =A0 =A0 =A0settings)= )
=A0 =A0(push (list= type match settings) new)))))
=A0 =A0 =A0(and new (list "X&= quot; "SUMO" (reverse new)

--90e6ba614f8c42e30e04d01ab367-- --90e6ba614f8c42e31904d01ab369 Content-Type: application/octet-stream; name="0001-Removed-match-from-agendas-title.patch" Content-Disposition: attachment; filename="0001-Removed-match-from-agendas-title.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hach3vzt0 RnJvbSA2MzUzMzJmYjQ5NjM3NDYzYmZlM2Y1OGU3ODBhZDNlZTFhN2VhOWIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5uaW5nIFdlaXNzIDxoZHdlaXNzQGdtYWlsLmNvbT4KRGF0 ZTogU3VuLCAyMyBTZXAgMjAxMiAwMjozNjo0MSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFJlbW92 ZWQgbWF0Y2ggZnJvbSBhZ2VuZGFzIHRpdGxlCgotLS0KIGxpc3Avb3JnLW1vYmlsZS5lbCB8ICAg IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2xpc3Avb3JnLW1vYmlsZS5lbCBiL2xpc3Avb3JnLW1vYmlsZS5lbAppbmRleCBm ZmRkNjY1Li45MDZmZjI2IDEwMDY0NAotLS0gYS9saXNwL29yZy1tb2JpbGUuZWwKKysrIGIvbGlz cC9vcmctbW9iaWxlLmVsCkBAIC01OTMsNyArNTkzLDcgQEAgVGhlIHRhYmxlIG9mIGNoZWNrc3Vt cyBpcyB3cml0dGVuIHRvIHRoZSBmaWxlIG1vYmlsZS1jaGVja3N1bXMuIgogCQkoY29ucyAobGlz dCAnb3JnLWFnZW5kYS10aXRsZS1hcHBlbmQKIAkJCSAgICAoY29uY2F0ICI8YWZ0ZXI+S0VZUz0i IGdrZXkgIiMiIChudW1iZXItdG8tc3RyaW5nCiAJCQkJCQkJICAgICAoc2V0cSBjbnQgKDErIGNu dCkpKQotCQkJCSAgICAiIFRJVExFOiAiIGdkZXNjICIgIiBtYXRjaCAiPC9hZnRlcj4iKSkKKwkJ CQkgICAgIiBUSVRMRTogIiBnZGVzYyAiPC9hZnRlcj4iKSkKIAkJICAgICAgc2V0dGluZ3MpKQog CSAgKHB1c2ggKGxpc3QgdHlwZSBtYXRjaCBzZXR0aW5ncykgbmV3KSkpKSkKICAgICAoYW5kIG5l dyAobGlzdCAiWCIgIlNVTU8iIChyZXZlcnNlIG5ldykKLS0gCjEuNy4xMAoK --90e6ba614f8c42e31904d01ab369--