From: Henning Weiss <hdweiss@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-mobile agenda title
Date: Wed, 5 Dec 2012 14:10:01 +0100 [thread overview]
Message-ID: <CAKq33ufBhKUgwMpwVBfFSLaudvY2ofbbOyu63TJvaoRd0fSqEA@mail.gmail.com> (raw)
In-Reply-To: <CAKq33ucev3yTJhtRtwPP6FAG-ks9OfaCcNaudbbH859LTpEKAw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1561 bytes --]
Hi,
I was wondering why this patch was reversed in master. An updated version
of the patch is attached, and a discussion of what it does is below.
Henning
On Wed, Jan 25, 2012 at 10:21 PM, Henning Weiss <hdweiss@gmail.com> wrote:
> Hi everyone,
>
> I have been working on a patch for mobileorg-android<https://github.com/matburt/mobileorg-android>that improves the displaying of the generated
> agendas.org file. The problem I'm having is that TITLE: fields of all
> entries are generated by concatenating the name and the matching criterion
> of an entry. The issue is discussed in further details here<https://github.com/matburt/mobileorg-android/issues/114#issuecomment-3658654>
> .
>
> I have tried to create a patch that removes the match criterions from the
> generated title entry and attached it below. This could potentially break
> other org-mobile clients and might not be the best way to solve this.
>
> What would it take to include this in orgmode?
>
> best regards,
> Henning Weiss
>
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index 541ccc8..82320c7 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -592,7 +592,7 @@ The table of checksums is written to the file
> mobile-checksums."
> (cons (list 'org-agenda-title-append
> (concat "<after>KEYS=" gkey "#" (number-to-string
> (setq cnt (1+ cnt)))
> - " TITLE: " gdesc " " match "</after>"))
> + " TITLE: " gdesc "</after>"))
> settings))
> (push (list type match settings) new)))))
> (and new (list "X" "SUMO" (reverse new)
>
[-- Attachment #1.2: Type: text/html, Size: 2755 bytes --]
[-- Attachment #2: 0001-Removed-match-from-agendas-title.patch --]
[-- Type: application/octet-stream, Size: 843 bytes --]
From 635332fb49637463bfe3f58e780ad3ee1a7ea9b3 Mon Sep 17 00:00:00 2001
From: Henning Weiss <hdweiss@gmail.com>
Date: Sun, 23 Sep 2012 02:36:41 +0200
Subject: [PATCH] Removed match from agendas title
---
lisp/org-mobile.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index ffdd665..906ff26 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -593,7 +593,7 @@ The table of checksums is written to the file mobile-checksums."
(cons (list 'org-agenda-title-append
(concat "<after>KEYS=" gkey "#" (number-to-string
(setq cnt (1+ cnt)))
- " TITLE: " gdesc " " match "</after>"))
+ " TITLE: " gdesc "</after>"))
settings))
(push (list type match settings) new)))))
(and new (list "X" "SUMO" (reverse new)
--
1.7.10
next prev parent reply other threads:[~2012-12-05 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 21:21 [PATCH] org-mobile agenda title Henning Weiss
2012-01-28 14:41 ` Bastien
2012-01-28 20:05 ` Henning Weiss
2012-03-20 15:30 ` Bastien
2012-12-05 13:10 ` Henning Weiss [this message]
2012-12-30 8:55 ` Bastien
2013-01-04 15:29 ` Henning Weiss
2013-01-04 16:22 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKq33ufBhKUgwMpwVBfFSLaudvY2ofbbOyu63TJvaoRd0fSqEA@mail.gmail.com \
--to=hdweiss@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).