From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henning Weiss Subject: Re: [PATCH] org-mobile agenda title Date: Sat, 28 Jan 2012 21:05:08 +0100 Message-ID: References: <87r4yjzy7w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=20cf303f6ab0558f2804b79c21ad Return-path: Received: from eggs.gnu.org ([140.186.70.92]:48027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrEWN-0006yi-H4 for emacs-orgmode@gnu.org; Sat, 28 Jan 2012 15:05:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrEWL-0001zX-St for emacs-orgmode@gnu.org; Sat, 28 Jan 2012 15:05:11 -0500 Received: from mail-yx0-f169.google.com ([209.85.213.169]:50089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrEWL-0001zQ-Oz for emacs-orgmode@gnu.org; Sat, 28 Jan 2012 15:05:09 -0500 Received: by yenm10 with SMTP id m10so1401802yen.0 for ; Sat, 28 Jan 2012 12:05:09 -0800 (PST) In-Reply-To: <87r4yjzy7w.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org, Richard Moreland --20cf303f6ab0558f2804b79c21ad Content-Type: text/plain; charset=ISO-8859-1 On Sat, Jan 28, 2012 at 3:41 PM, Bastien wrote: > Hi Henning, > > Henning Weiss writes: > > > I have been working on a patch for mobileorg-android that improves > > the displaying of the generated agendas.org file. The problem I'm > > having is that TITLE: fields of all entries are generated > > by concatenating the name and the matching criterion of an entry. The > > issue is discussed in further details here. > > > > I have tried to create a patch that removes the match criterions from > > the generated title entry and attached it below. This could > > potentially break other org-mobile clients and might not be the best > > way to solve this. > > > > What would it take to include this in orgmode? > > The patch looks okay to me (I read the discussion you pointed to.) > > Richard, would this patch break anything on your side? > > Thanks, > > -- > Bastien > Hi again, I have a little revision to the patch to remove the matching criterion from "normal" (ie. non-block) agendas as well. See below. best regards, Henning Weiss --- a/lisp/org-mobile.el +++ b/lisp/org-mobile.el @@ -574,7 +574,7 @@ The table of checksums is written to the file mobile-checksums." (concat "KEYS=" key " TITLE: " (if (and (stringp desc) (> (length desc) 0)) desc (symbol-name type)) - " " match "")) + "")) settings)) (push (list type match settings) new)) ((or (functionp (nth 2 e)) (symbolp (nth 2 e))) @@ -592,7 +592,7 @@ The table of checksums is written to the file mobile-checksums." (cons (list 'org-agenda-title-append (concat "KEYS=" gkey "#" (number-to-string (setq cnt (1+ cnt))) - " TITLE: " gdesc " " match "")) + " TITLE: " gdesc "")) settings)) (push (list type match settings) new))))) (and new (list "X" "SUMO" (reverse new) --20cf303f6ab0558f2804b79c21ad Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Sat, Jan 28, 2012 at 3:41 PM, Bastien <bzg= @altern.org> wrote:
Hi Henning,

Henning Weiss <hd= weiss@gmail.com> writes:

> I have been working on a patch for mobileorg-android that improves
> the displaying of the generated agendas.org file. The problem I'm
> having is that TITLE: fields of all entries are generated
> by=A0concatenating=A0the name and the matching criterion of an entry. = The
> issue is discussed in further details=A0here.
>
> I have tried to create a patch that removes the match criterions from<= br> > the generated title entry and attached it below. This could
> potentially break other org-mobile clients and might not be the best > way to solve this.
>
> What would it take to include this in orgmode?

The patch looks okay to me (I read the discussion you pointed to.)
Richard, would this patch break anything on your side?

Thanks,

--
=A0Bastien

Hi again,

I have a little revision to the patch to remove the matching criterion fr= om "normal" (ie. non-block) agendas as well. See below.

best regards,
Henning Weiss

--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -574,7 +574,7 @@ The table of checksums is written to the file m= obile-checksums."
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (concat "<= after>KEYS=3D" key " TITLE: "
=A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (if (and (stringp desc)= (> (length desc) 0))
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 desc (symbol-name type))
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &quo= t; " match "</after>"))
+ =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "</after>")= )
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 settings))
= =A0 =A0 =A0 =A0 (push (list type match settings) new))
=A0 =A0 =A0 =A0 ((or (functionp (nth 2 e)) (symbolp (nth 2 e)))
<= div>@@ -592,7 +592,7 @@ The table of checksums is written to the file mobil= e-checksums."
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (cons (list &#= 39;org-agenda-title-append
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (concat "= <after>KEYS=3D" gkey "#" (number-to-string
= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (setq cnt (1+ cnt)))
- =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 " TITLE: &= quot; gdesc " " match "</after>"))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = " TITLE: " gdesc "</after>"))
=A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 settings))
=A0 =A0 =A0 =A0 = =A0 (push (list type match settings) new)))))
=A0 =A0 =A0(and new= (list "X" "SUMO" (reverse new)
--20cf303f6ab0558f2804b79c21ad--