From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henning Weiss Subject: [PATCH] org-attach-store-link-p gets wrong value for attach when using customize-variable Date: Mon, 12 Mar 2012 22:17:34 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=0016e68ef437621c6f04bb1245ca Return-path: Received: from eggs.gnu.org ([208.118.235.92]:55061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Ccv-0007dL-EY for emacs-orgmode@gnu.org; Mon, 12 Mar 2012 17:17:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7Ccb-0001Uf-BD for emacs-orgmode@gnu.org; Mon, 12 Mar 2012 17:17:57 -0400 Received: from mail-yx0-f169.google.com ([209.85.213.169]:47050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Ccb-0001UA-4T for emacs-orgmode@gnu.org; Mon, 12 Mar 2012 17:17:37 -0400 Received: by yenm8 with SMTP id m8so3686904yen.0 for ; Mon, 12 Mar 2012 14:17:34 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --0016e68ef437621c6f04bb1245ca Content-Type: text/plain; charset=ISO-8859-1 Hi, I have attached a very small patch fixing the value that org-attach-store-link-p gets through the customize interface. The additional quote prevented org-attach-attach from calling org-attach-store-link when org-attach-store-link-p was configured to "Link to the attach-dir location". best regards, Henning Weiss diff --git a/lisp/org-attach.el b/lisp/org-attach.el index 1816a07..7ba3d72 100644 --- a/lisp/org-attach.el +++ b/lisp/org-attach.el @@ -105,7 +105,7 @@ ln create a hard link. Note that this is not supported :type '(choice (const :tag "Don't store link" nil) (const :tag "Link to origin location" t) - (const :tag "Link to the attach-dir location" 'attached))) + (const :tag "Link to the attach-dir location" attached))) ;;;###autoload (defun org-attach () --0016e68ef437621c6f04bb1245ca Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi,

I have attached a very small patch fixing= the value that=A0org-attach-store-link-p gets through the customize interf= ace. The additional quote prevented org-attach-attach from calling=A0org-at= tach-store-link when=A0org-attach-store-link-p was configured to "Link= to the attach-dir location".

best regards,
Henning Weiss

diff --git a/lisp/org-attach.el b/lisp/org-attach.el
index 1816a07..7ba3d72 100644
--- a/lisp/org-attach.el
+++ b/lisp/org-attach.el
@@ -105,7 +105,7 @@ ln =A0 =A0creat= e a hard link. =A0Note that this is not supported
=A0 =A0:type &#= 39;(choice
=A0 =A0 =A0 =A0 =A0 (const :tag "Don't store = link" nil)
=A0 =A0 =A0 =A0 =A0 (const :tag "Link to origin location" t)=
- =A0 =A0 =A0 =A0 (const :tag "Link to the attach-dir locat= ion" 'attached)))
+ =A0 =A0 =A0 =A0 (const :tag "Li= nk to the attach-dir location" attached)))
=A0
=A0;;;###autoload
=A0(defun org-attach ()
--0016e68ef437621c6f04bb1245ca--