From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Li Subject: Re: Bug: agenda text search with buffer restriction fails [9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20171225/)] Date: Sat, 30 Dec 2017 03:45:38 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a114f20b8c5235f05618d49aa" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eVFa9-00028T-Nb for emacs-orgmode@gnu.org; Sat, 30 Dec 2017 06:45:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eVFa8-0008Jk-N0 for emacs-orgmode@gnu.org; Sat, 30 Dec 2017 06:45:41 -0500 Received: from mail-qt0-x22b.google.com ([2607:f8b0:400d:c0d::22b]:37322) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eVFa8-0008I0-GU for emacs-orgmode@gnu.org; Sat, 30 Dec 2017 06:45:40 -0500 Received: by mail-qt0-x22b.google.com with SMTP id f2so56638691qtj.4 for ; Sat, 30 Dec 2017 03:45:40 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --001a114f20b8c5235f05618d49aa Content-Type: text/plain; charset="UTF-8" On Sat, Dec 30, 2017 at 3:38 AM, Allen Li wrote: > Doing a text agenda search with org-agenda-text-search-extra-files > set to (agenda-archives) and with a buffer restriction results in an error: > > Debugger entered--Lisp error: (wrong-type-argument stringp agenda-archives) > file-exists-p(agenda-archives) > #[(a b) "\302 !\205 \302 !\205 \303 \"\207" [a b file-exists-p > file-equal-p] 3]("/tmp/tmp.org" agenda-archives) > cl--position("/tmp/tmp.org" (agenda-archives) 0 1) > cl--delete-duplicates(("/tmp/tmp.org" agenda-archives) (:test #[(a > b) "\302 !\205 \302 !\205 \303 \"\207" [a b file-exists-p > file-equal-p] 3]) t) > cl-remove-duplicates(("/tmp/tmp.org" agenda-archives) :test #[(a b) > "\302 !\205 \302 !\205 \303 \"\207" [a b file-exists-p file-equal-p] > 3]) > org-search-view(nil) > funcall-interactively(org-search-view nil) > call-interactively(org-search-view) > org-agenda(nil) > funcall-interactively(org-agenda nil) > call-interactively(org-agenda nil nil) > command-execute(org-agenda) I made a patch for this (attached), which works when evaluated in my working session. We were not removing the agenda-archives symbol if a restriction is in effect. > > > Emacs : GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26) > of 2017-12-04 > Package: Org mode version 9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ > /home/ionasal/.emacs.d/elpa/org-plus-contrib-20171225/) --001a114f20b8c5235f05618d49aa Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Remove-agenda-archives-even-with-buffer-restriction.patch" Content-Disposition: attachment; filename="0001-Remove-agenda-archives-even-with-buffer-restriction.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jbta5mwq0 RnJvbSBlYTc2MDJhNTBjZTI1OGVlYjQ4MzM5NjJmOTExNTBkNDAxMzAzMTcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBTYXQsIDMwIERlYyAyMDE3IDAzOjQxOjUxIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gUmVt b3ZlIGFnZW5kYS1hcmNoaXZlcyBldmVuIHdpdGggYnVmZmVyIHJlc3RyaWN0aW9uCgotLS0KIGxp c3Avb3JnLWFnZW5kYS5lbCB8IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLWFnZW5kYS5lbCBiL2xp c3Avb3JnLWFnZW5kYS5lbAppbmRleCA4ODg4MTg2MzAuLjdmM2I5ZDBjYSAxMDA2NDQKLS0tIGEv bGlzcC9vcmctYWdlbmRhLmVsCisrKyBiL2xpc3Avb3JnLWFnZW5kYS5lbApAQCAtNDQ4Miw5ICs0 NDgyLDkgQEAgaXMgYWN0aXZlLiIKICAgICAgIChzZXRxIGZpbGVzIChvcmctYWdlbmRhLWZpbGVz IG5pbCAnaWZtb2RlKSkKICAgICAgIDs7IEFkZCBgb3JnLWFnZW5kYS10ZXh0LXNlYXJjaC1leHRy YS1maWxlcycgdW5sZXNzIHRoZXJlIGlzIHNvbWUKICAgICAgIDs7IHJlc3RyaWN0aW9uLgotICAg ICAgKHVubGVzcyAoZ2V0ICdvcmctYWdlbmRhLWZpbGVzICdvcmctcmVzdHJpY3QpCi0JKHdoZW4g KGVxIChjYXIgb3JnLWFnZW5kYS10ZXh0LXNlYXJjaC1leHRyYS1maWxlcykgJ2FnZW5kYS1hcmNo aXZlcykKLQkgIChwb3Agb3JnLWFnZW5kYS10ZXh0LXNlYXJjaC1leHRyYS1maWxlcykKKyAgICAg ICh3aGVuIChlcSAoY2FyIG9yZy1hZ2VuZGEtdGV4dC1zZWFyY2gtZXh0cmEtZmlsZXMpICdhZ2Vu ZGEtYXJjaGl2ZXMpCisJKHBvcCBvcmctYWdlbmRhLXRleHQtc2VhcmNoLWV4dHJhLWZpbGVzKQor CSh1bmxlc3MgKGdldCAnb3JnLWFnZW5kYS1maWxlcyAnb3JnLXJlc3RyaWN0KQogCSAgKHNldHEg ZmlsZXMgKG9yZy1hZGQtYXJjaGl2ZS1maWxlcyBmaWxlcykpKSkKICAgICAgIDs7IFVuaXF1aWZ5 IGZpbGVzLiAgSG93ZXZlciwgbGV0IGBvcmctY2hlY2stYWdlbmRhLWZpbGUnIGhhbmRsZQogICAg ICAgOzsgbm9uLWV4aXN0ZW50IG9uZXMuCi0tIAoyLjE1LjEKCg== --001a114f20b8c5235f05618d49aa--