From: Allen Li <vianchielfaura@gmail.com>
To: Tim Cross <theophilusx@gmail.com>
Cc: emacs-orgmode@gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: org-2ft and/or float-time is wrong [9.1.2 (9.1.2-22-ga2a034-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20171023/)]
Date: Wed, 1 Nov 2017 22:12:17 -0700 [thread overview]
Message-ID: <CAJr1M6eRfm4vr+KttKjYm2poezJgf4Pf0O9MH_EhJno9gwqR7g@mail.gmail.com> (raw)
In-Reply-To: <874lqdth1r.fsf@gmail.com>
On Wed, Nov 1, 2017 at 9:56 PM, Tim Cross <theophilusx@gmail.com> wrote:
>
> OK, thanks for the additional information. That helps a lot.
>
> We can now narrow down where the issue is.
>
> After having looked (only very casually) at some of the org date/time
> related functions, I think there may be quite a few issues. I'm not
> convinced the root cause is org-2ft converting to UTC, though I think
> that change has probably revealed some of the issues.
>
> There does seem to be some inconsistency or lack of clarity regarding
> some of these operations and it could well be that the switch to using
> UTC is not the correct approach, but just switching back probably isn't
> either What does appear to be required is increased consistency in some
> of these functions or where/how they are used. .
Thanks. I think I have been harping a bit too hard on org-2ft, but
indeed it seems to be a bit more systemic an issue.
> To correctly fix this, I feel more analysis is warranted. I'm prepared
> to look at this and present a summary and options, but it will have to
> wait until after 21st when I start leave from work. It is a complex area
> and perhaps my skills won't be up to it, but I should at least be able
> to identify the main areas needing attention/decisions.
My initial approach would be to do some refactoring here, especially
among org-2ft, org-matcher-time, and org-parse-time-string, each of
which calls the others in a cycle and each share a part of the logic
for interpreting Org mode timestamps.
I'm not familiar with refactoring FOSS code via mailed patches, nor if
Org maintainers would welcome such patches, but I would be willing to
do some refactoring here.
>
> Whether we should change back to non-UTC for time comparisons in the
> meantime is not something I feel informed enough to make a call. It
> really depends on the daylight savings time related issues affecting
> clock tables and other functionality. This is probably something core
> org maintainers will need to make a call on.
>
> Tim
next prev parent reply other threads:[~2017-11-02 5:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 0:40 Bug: org-2ft and/or float-time is wrong [9.1.2 (9.1.2-22-ga2a034-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20171023/)] Allen Li
2017-10-31 4:33 ` Allen Li
2017-10-31 18:23 ` Nicolas Goaziou
2017-10-31 18:35 ` Allen Li
2017-10-31 18:52 ` Nicolas Goaziou
2017-11-01 5:07 ` Allen Li
2017-11-01 5:41 ` Tim Cross
2017-11-01 6:26 ` Allen Li
2017-11-01 7:18 ` Tim Cross
2017-11-01 8:28 ` Allen Li
2017-11-01 13:09 ` Tim Cross
2017-11-01 19:14 ` Allen Li
2017-11-01 19:21 ` Allen Li
2017-11-02 0:09 ` Tim Cross
2017-11-02 0:26 ` Allen Li
2017-11-02 3:27 ` Tim Cross
2017-11-02 4:05 ` Allen Li
2017-11-02 4:28 ` Allen Li
2017-11-02 4:49 ` Allen Li
2017-11-02 4:56 ` Tim Cross
2017-11-02 5:12 ` Allen Li [this message]
2017-11-02 16:19 ` Nick Dokos
2017-11-02 19:56 ` Tim Cross
2017-11-01 20:55 ` Nicolas Goaziou
2017-11-02 0:10 ` Allen Li
2017-11-02 9:35 ` Nicolas Goaziou
2017-11-02 11:12 ` Tim Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJr1M6eRfm4vr+KttKjYm2poezJgf4Pf0O9MH_EhJno9gwqR7g@mail.gmail.com \
--to=vianchielfaura@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=theophilusx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).