From: Allen Li <vianchielfaura@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: agenda text search with buffer restriction fails [9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20171225/)]
Date: Sat, 30 Dec 2017 13:39:19 -0800 [thread overview]
Message-ID: <CAJr1M6djHu7M2Xrq7nEV=jx0CxXuhc2VziymnZ-22dzTJK6Z4Q@mail.gmail.com> (raw)
In-Reply-To: <878tdk76xx.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Sat, Dec 30, 2017 at 4:10 AM, Bastien <bzg@gnu.org> wrote:
> Hi Allen,
>
> thanks for the patch, it looks good.
>
> Can you provide it with a changelog? Like for those two:
>
> https://code.orgmode.org/bzg/org-mode/commit/b9b921716ba1d2a564bb9443427dfb21bb609e05
> https://code.orgmode.org/bzg/org-mode/commit/da83e7d583895976a2398becbb995bcce1f729be
Oops, done. Attached new patch.
> I assume the email address darkfeline AT felesatra DOT moe belongs
> to you, in which case you don't need to add "TINYCHANGE" at the end
> of the changelog message since your FSF papers are signed.
Yes, that's under a domain that I own so I don't rely on Gmail to
receive email (although I often send with Gmail to avoid spam filter
issues, alas).
You can find my public key/identity on, e.g. the MIT key servers.
>
> Thanks!
>
> --
> Bastien
[-- Attachment #2: 0001-Remove-agenda-archives-even-with-buffer-restriction.patch --]
[-- Type: text/x-patch, Size: 1214 bytes --]
From 21d8d507474ac3faa5b1ea9dfa7aa3647cddd8af Mon Sep 17 00:00:00 2001
From: Allen Li <darkfeline@felesatra.moe>
Date: Sat, 30 Dec 2017 03:41:51 -0800
Subject: [PATCH] Remove agenda-archives even with buffer restriction
* lisp/org-agenda.el (org-search-view): Remove agenda-archives even
with buffer restriction
---
lisp/org-agenda.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 888818630..7f3b9d0ca 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4482,9 +4482,9 @@ is active."
(setq files (org-agenda-files nil 'ifmode))
;; Add `org-agenda-text-search-extra-files' unless there is some
;; restriction.
- (unless (get 'org-agenda-files 'org-restrict)
- (when (eq (car org-agenda-text-search-extra-files) 'agenda-archives)
- (pop org-agenda-text-search-extra-files)
+ (when (eq (car org-agenda-text-search-extra-files) 'agenda-archives)
+ (pop org-agenda-text-search-extra-files)
+ (unless (get 'org-agenda-files 'org-restrict)
(setq files (org-add-archive-files files))))
;; Uniquify files. However, let `org-check-agenda-file' handle
;; non-existent ones.
--
2.15.1
next prev parent reply other threads:[~2017-12-30 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 11:38 Bug: agenda text search with buffer restriction fails [9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20171225/)] Allen Li
2017-12-30 11:45 ` Allen Li
2017-12-30 12:10 ` Bastien
2017-12-30 21:39 ` Allen Li [this message]
2018-04-26 23:34 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJr1M6djHu7M2Xrq7nEV=jx0CxXuhc2VziymnZ-22dzTJK6Z4Q@mail.gmail.com' \
--to=vianchielfaura@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).