From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Li Subject: Re: [PATCH 2/2] org-refile: Fix inconsistency when listing refile targets Date: Thu, 6 Jul 2017 23:55:34 -0700 Message-ID: References: <20170515125455.18251-1-seb@wirrsal.net> <20170515125455.18251-2-seb@wirrsal.net> <87o9thsrky.fsf@wirrsal.net> <877ezq10ku.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTNAw-0003Oh-GD for emacs-orgmode@gnu.org; Fri, 07 Jul 2017 02:55:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTNAv-0000ES-9f for emacs-orgmode@gnu.org; Fri, 07 Jul 2017 02:55:38 -0400 Received: from mail-qt0-x22f.google.com ([2607:f8b0:400d:c0d::22f]:34645) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTNAu-0000Cp-VX for emacs-orgmode@gnu.org; Fri, 07 Jul 2017 02:55:37 -0400 Received: by mail-qt0-x22f.google.com with SMTP id 32so20267602qtv.1 for ; Thu, 06 Jul 2017 23:55:35 -0700 (PDT) In-Reply-To: <877ezq10ku.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org, =?UTF-8?Q?Sebastian_Reu=C3=9Fe?= Yes, 2906e50177d47 is needed on maint. However, my understanding is that on maint we still escape filesystem slashes in the outline path? If so, org-protect-path will be needed around the file-truename in 2906e50177d4 My workflow recently changed such that I no longer need to set org-refile-use-outline-path to full-file-path, so my interest in this bug has dropped accordingly, but it is still a bug on maint that breaks refiling, so I think the fix should be backported unless there are plans for a main -> maint merge soon. On Sun, Jul 2, 2017 at 11:44 PM, Nicolas Goaziou wrote: > Hello, > > Allen Li writes: > >> I just realized that this patch was applied to the master branch, not >> the maint branch. >> >> The absence of this patch results in the continued life of a bug in >> the maint branch where it is not possible to refile to the top level >> of an agenda file when using full-file-path for >> org-refile-use-outline-path. >> >> Is it possible to backport this to the maint branch? This will >> require adding the org-protect-slash that I mentioned earlier in this >> thread. Otherwise, refile is basically unusable for me when >> full-file-path is set. > > Wouldn't 2906e50177d47b4f4a0e75532a0c9dcc9cf72824 be sufficient in your > case? > > If not, what commits are required? > > Regards, > > -- > Nicolas Goaziou