emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

* [patch] a small change
@ 2012-05-01  9:44 feng shu
  2012-05-01  9:55 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: feng shu @ 2012-05-01  9:44 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-A-small-change.patch --]
[-- Type: application/octet-stream, Size: 1275 bytes --]

From 790097f4e3c7acdcccbcc42e302e0e31c264c46d Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@gmail.com>
Date: Tue, 1 May 2012 15:24:56 +0800
Subject: [PATCH] A small change.

* org.el (org-create-formula-image-with-imagemagick): using   'call-process to launch latex program instead of 'shell-command.
---
 lisp/org.el |    5 +++--
 1 个文件被修改，插入 3 行(+)，删除 2 行(-)

diff --git a/lisp/org.el b/lisp/org.el
index f54026c..e9e6564 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -17037,7 +17037,7 @@ Some of the options can be changed using the variable
 	       ((eq processing-type 'imagemagick)
 		(unless executables-checked
 		  (org-check-external-command
-		   "converte" "you need to install imagemagick")
+		   "convert" "you need to install imagemagick")
 		  (setq executables-checked t))
 		(unless (file-exists-p movefile)
 		  (org-create-formula-image-with-imagemagick
@@ -17312,7 +17312,8 @@ inspection."
 			   (save-match-data
 			     (shell-quote-argument (file-name-directory texfile)))
 			   t t cmd)))
-	      (shell-command cmd)))
+	      (setq cmd (split-string cmd))
+	      (eval (append (list 'call-process (pop cmd) 'nil 'nil 'nil) cmd))))
 	(error nil))
       (cd dir))
     (if (not (file-exists-p pdffile))
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 2+ messages in thread

• * Re: [patch] a small change
    2012-05-01  9:44 [patch] a small change feng shu
  @ 2012-05-01  9:55 ` Bastien
    0 siblings, 0 replies; 2+ messages in thread
  From: Bastien @ 2012-05-01  9:55 UTC (permalink / raw)
    To: feng shu; +Cc: emacs-orgmode
  
  Hi Feng,
  
  thanks for the patch.  Can you give it a better name?
  
  Also split it into two patches, one for the typo one for 
  the other change.
  
  As for the code:
  
  - don't use 'nil, use nil
  - (append (list 'x 'y) 'y) => (list 'x 'y 'z)
  
  Thanks!
  
  -- 
   Bastien
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-01  9:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-01  9:44 [patch] a small change feng shu
2012-05-01  9:55 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).