From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brent Goodrick <bgoodr@gmail.com>
Subject: Removing ding each time I type TAB when not after a structure
 template with org-tempo enabled
Date: Sun, 4 Feb 2018 11:07:10 -0800
Message-ID: <CAJj=8EGk64X87EoHB-ZzNdBKNgcJ_u1LyABzbW3575eW7Oao0g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41329)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bgoodr@gmail.com>) id 1eiPdB-0004Np-M1
	for emacs-orgmode@gnu.org; Sun, 04 Feb 2018 14:07:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bgoodr@gmail.com>) id 1eiPdA-00080R-DF
	for emacs-orgmode@gnu.org; Sun, 04 Feb 2018 14:07:13 -0500
Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:38455)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <bgoodr@gmail.com>) id 1eiPdA-000808-5Y
	for emacs-orgmode@gnu.org; Sun, 04 Feb 2018 14:07:12 -0500
Received: by mail-wm0-x22d.google.com with SMTP id 141so21768784wme.3
	for <emacs-orgmode@gnu.org>; Sun, 04 Feb 2018 11:07:12 -0800 (PST)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Cc: emacs-orgmode@gnu.org

Hi:

I recently upgraded to org from Git. Thus, org-version for me returns:

Org mode version 9.1.6 (release_9.1.6-425-gd89e35 @
/home/brentg/emacs_lisp_imported/org-mode/org-mode/lisp/)

In this new version, I discovered that structure templates were not
enabled by default, so I enabled them. But to my chagrin, I found that
I get a "ding" each time I type the TAB key when on a blank line that
is _not_ right after a structure template such as "<e".

Below is my hackaround, but can someone take a look into arranging it
so that is not the default to ding if tempo-complete-tag cannot find
anything to complete, and thus I can remove my hack?

Just passing silent to it will actually break TABing over (normal tab
meaning) in Org buffers, so the obvious fix won't work.  (ding)
returns nil which it must so that the hook works as expected.

Thanks,
Brent

----------------------------------------------------------

(defun bg-tempo-complete-tag-no-ding (&optional silent)
  ;; flet is NOT the same as cl-flet as it does not bind the function _deeply_
  ;; so that some function that calls the (ding) should pick up this definition
  ;; here. See https://emacs.stackexchange.com/a/3452/15483
  ;;
  ;; The reason we have to do it this way is because if tempo-complete-tag
  ;; returns t (which it will if we set its 'silent' argument to t), it
  ;; short-circuits the use of tempo-complete-tag from within
  ;; org-tab-before-tab-emulation-hook, which means even TABing to the line
  ;; underneath a Org check-list is broken (doesn't even tab). Ugggggh!
  ;;
  (cl-letf (((symbol-function 'ding)
         (lambda (&optional silent)
           ;; (message "bg-tempo-complete-tag-no-ding: Hack around bug
in ding in tempo-complete-tag or org mode")
           nil)))
    (tempo-complete-tag silent)))

(defun bg-org-enable-structure-templates ()
  ;;
  ;; Enable Structure templates that at one point were by default enabled in Org
  ;; mode, but someone changed that for some reason, so re enable it.
  ;;
  (require 'org-tempo)
  ;;
  ;; But tempo-complete-tag is obnoxious. It dings if you have point at the
  ;; start of a line (e.g., NOT after something like "<e"), and if it cannot
  ;; find a template prior to point, it dings. So disable that:
  ;;
  (remove-hook 'org-tab-before-tab-emulation-hook
           'tempo-complete-tag)
  (add-hook 'org-tab-before-tab-emulation-hook
        'bg-tempo-complete-tag-no-ding))


Thanks,
Brent