From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Wales Subject: Re: [RFC PATCH] Changes to pop-up source buffers Date: Sat, 18 Jan 2020 19:46:21 -0700 Message-ID: References: <87eevw7jqk.fsf@gmail.com> <877e1ok1kg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54730) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1it0bZ-0003rj-BA for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 21:46:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1it0bY-0001b4-DB for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 21:46:25 -0500 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]:35914) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1it0bY-0001aD-6P for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 21:46:24 -0500 Received: by mail-lj1-x241.google.com with SMTP id r19so30371181ljg.3 for ; Sat, 18 Jan 2020 18:46:24 -0800 (PST) In-Reply-To: <877e1ok1kg.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Jack Kamm Cc: emacs-orgmode@gnu.org On 1/18/20, Jack Kamm wrote: > What setting of org-src-window-setup are you using? If it is > "current-window" or "reorganize-frame", this patch shouldn't affect you > at all, as those implementations are left the same. you're right, i have that set to current-window, as you might expect. and it is reasonable to expect that any patch would continue to respect it. thanks for your response. jack> A final advantage I'd like to note for pop-to-buffer and quit-restore-window, is that these are the mechanisms used by many built-in Emacs functions to pop up and close windows, such as *Help* windows. i'm not sure what the latest is on what one should use. or whether the latest is on what one should use is problematic for my modest needs. maybe you have looked into the former. help does things like popping up in the fisrt place, opening a linked help buffer, and opening up source code. idk if they all use the same mechanism? i've had issues with 2-3 of them. anomalies on rare occasions occur despite my kludging. iirc stefan once wrote that using the wrong function will break his configuration. there are subtly different purposes for displaying a buffer. one covers the minibuffer, or something.