From: Samuel Wales <samologist@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Improve org-mouse support for checkboxes
Date: Sat, 18 Sep 2021 13:54:15 -0700 [thread overview]
Message-ID: <CAJcAo8svZKZat6cYgWBNz9j1RN+6rfRJtH1t1m3U+_dy+P9BBQ@mail.gmail.com> (raw)
In-Reply-To: <si5f7l$j3f$1@ciao.gmane.io>
thanks for this. if tests are written, might be useful to include the
case where half-checked are parents.
On 9/18/21, Jim Porter <jporterbugs@gmail.com> wrote:
> While trying out `org-mouse', I noticed two semi-related issues with
> checkboxes. First, intermediate-state checkboxes (like [-]) aren't
> clickable. Second, if the checkboxes are inside a block and the theme
> gives the block a background color, the block's background is removed
> behind the checkbox. To see both of these in action:
>
> $ cat file.org
> * Regular
> - [X] Checked.
> - [-] Half-checked.
> - [ ] Not checked.
> * In block
> #+begin_src org
> - [X] Checked.
> - [-] Half-checked.
> - [ ] Not checked.
> #+end_src
>
> $ emacs -Q --eval '(progn (setq org-modules '"'"'(org-mouse))
> (custom-set-faces '"'"'(org-block ((t :background "green")))))' file.org
>
> The attached patch fixes both of these issues. For the first problem,
> maybe it would be useful to put the regexp for checkboxes in a variable
> somewhere so it doesn't get out of sync. I wasn't sure though, so I went
> with the simpler solution for now.
>
> My FSF copyright assignment should be on file, but let me know if there
> are any issues there.
>
--
The Kafka Pandemic
Please learn what misopathy is.
https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html
next prev parent reply other threads:[~2021-09-18 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 19:38 [PATCH] Improve org-mouse support for checkboxes Jim Porter
2021-09-18 20:54 ` Samuel Wales [this message]
2021-09-18 22:47 ` Jim Porter
2021-09-26 5:58 ` Bastien
2021-09-26 18:11 ` Jim Porter
2021-09-26 20:18 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJcAo8svZKZat6cYgWBNz9j1RN+6rfRJtH1t1m3U+_dy+P9BBQ@mail.gmail.com \
--to=samologist@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).