From: Robert Irelan <rirelan@gmail.com>
To: Org-mode <emacs-orgmode@gnu.org>
Subject: Bug: org-map-drill-entries fails in org-tags-expand on empty string
Date: Wed, 23 Jan 2019 11:18:05 -0800 [thread overview]
Message-ID: <CAJUyYjrGHuOv1cgE_4JURgef4Dcotf9bNPKHgrHE2_fQpuhgpA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 23 bytes --]
Patch to fix attached.
[-- Attachment #2: 0001-org-drill-Fix-tag-match-in-org-map-drill-entries.patch --]
[-- Type: text/x-patch, Size: 1116 bytes --]
From a3af9004fbc5a8a86ba8f990d393403ec671f9bf Mon Sep 17 00:00:00 2001
From: Robert Irelan <rmirelan@google.com>
Date: Wed, 23 Jan 2019 11:11:14 -0800
Subject: [PATCH] org-drill: Fix tag match in org-map-drill-entries
* contrib/lisp/org-drill.el: Change MATCH argument to ORG-MAP-ENTRIES
from "" to nil.
Without this, org-tags-expand will throw an error on the empty string.
---
contrib/lisp/org-drill.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
index c7f509bff..895003395 100644
--- a/contrib/lisp/org-drill.el
+++ b/contrib/lisp/org-drill.el
@@ -1483,10 +1483,10 @@ the current topic."
(when (and (not (org-invisible-p))
(> (org-current-level) drill-entry-level))
(when (or (/= (org-current-level) (1+ drill-entry-level))
- (funcall test))
+ (funcall test))
(hide-subtree))
(push (point) drill-sections)))
- "" 'tree))
+ nil 'tree))
(reverse drill-sections)))
--
2.20.1.321.g9e740568ce-goog
next reply other threads:[~2019-01-23 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 19:18 Robert Irelan [this message]
2019-02-01 20:16 ` Bug: org-map-drill-entries fails in org-tags-expand on empty string Robert Irelan
2019-02-01 21:50 ` Stig Brautaset
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJUyYjrGHuOv1cgE_4JURgef4Dcotf9bNPKHgrHE2_fQpuhgpA@mail.gmail.com \
--to=rirelan@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).