emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Alexander Poslavsky <alexander.poslavsky@gmail.com>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: Org-mac-link misplaced quotes?
Date: Sat, 21 Dec 2013 19:27:09 +0200	[thread overview]
Message-ID: <CAJSGrv3H9oj3YfhitSTrMkLKsy0W+YNbACsdKBjNhAO0F=o=og@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 422 bytes --]

I regularly use org-mac-link from contrib/. It works fine, but somehow my
links are a bit mangled, I get:

[["http://orgmode.org/worg/org-contribute.html#sec-4][How to contribute to
Org?"]]

Instead of:

[[http://orgmode.org/worg/org-contribute.html#sec-4][How to contribute to
Org?]]

(Notice the quotation-marks, it's how applescript returns the string)

This small patch fixes that. I hope the patch is done correctly.

[-- Attachment #1.2: Type: text/html, Size: 778 bytes --]

[-- Attachment #2: 0001-org-as-mac-chrome-get-frontmost-url-fix-to-remove-un.patch --]
[-- Type: application/octet-stream, Size: 2313 bytes --]

From c475400cfff5317231e33d1cf12bbdc36a507b03 Mon Sep 17 00:00:00 2001
From: Alex Poslavsky <alexander.poslavsky@gmail.com>
Date: Sat, 21 Dec 2013 19:08:27 +0200
Subject: [PATCH] org-as-mac-chrome-get-frontmost-url: fix to remove unneeded
 quotation-marks

* contrib/lisp/org-mac-link.el: applescript returns the link and description in
  quotes like this:

  [["http://orgmode.org/worg/org-contribute.html#sec-4][How to
  contribute to Org?"]]

  The fix changes it to this:

  [[http://orgmode.org/worg/org-contribute.html#sec-4][How to
  contribute to Org?]]

  TINYCHANGE
---
 contrib/lisp/org-mac-link.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
index d348c2d..a89847f 100644
--- a/contrib/lisp/org-mac-link.el
+++ b/contrib/lisp/org-mac-link.el
@@ -3,13 +3,13 @@
 ;;
 ;; Copyright (c) 2010-2013 Free Software Foundation, Inc.
 ;;
-;; Authors: 
+;; Authors:
 ;;          Anthony Lander <anthony.lander@gmail.com>
 ;;          John Wiegley <johnw@gnu.org>
 ;;          Christopher Suckling <suckling at gmail dot com>
 ;;          Daniil Frumin <difrumin@gmail.com>
 ;;
-;;          
+;;
 ;; Version: 1.1
 ;; Keywords: org, mac, hyperlink
 ;;
@@ -201,14 +201,14 @@ applications and inserting them in org documents"
                         ("S" "kim" org-mac-skim-insert-page ,org-mac-grab-Skim-app-p)))
          (menu-string (make-string 0 ?x))
          input)
-    
+
     ;; Create the menu string for the keymap
     (mapc '(lambda (descriptor)
             (when (elt descriptor 3)
               (setf menu-string (concat menu-string "[" (elt descriptor 0) "]" (elt descriptor 1) " "))))
           descriptors)
     (setf (elt menu-string (- (length menu-string) 1)) ?:)
-    
+
     ;; Prompt the user, and grab the link
     (message menu-string)
     (setq input (read-char-exclusive))
@@ -368,7 +368,7 @@ applications and inserting them in org documents"
                      "set links to {}\n"
                      "copy theResult to the end of links\n"
                      "return links as string\n"))))
-    (car (split-string result "[\r\n]+" t))))
+    (substring (car (split-string result "[\r\n]+" t)) 1 -1)))
 
 (defun org-mac-chrome-get-frontmost-url ()
   (interactive)
-- 
1.8.5.1

next             reply	other threads:[~2013-12-21 17:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-21 17:27 Alexander Poslavsky [this message]
2013-12-22  8:20 ` Org-mac-link misplaced quotes? Bastien

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:d348c2d dfblob:a89847f
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJSGrv3H9oj3YfhitSTrMkLKsy0W+YNbACsdKBjNhAO0F=o=og@mail.gmail.com' \
    --to=alexander.poslavsky@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).