thanks for the troubleshooting. I pushed a fix that should use the
customizable pdf filename function instead.

John

-----------------------------------
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu



On Wed, Mar 10, 2021 at 10:36 AM Marvin M. Doyley <mdoyley@ur.rochester.edu>
wrote:

> HI Kyle,
>
> This solved my problems
>
>  Thanks,
>
> M
>
>
>
>
> On Mar 9, 2021, at 11:49 PM, Kyle Meyer <kyle@kyleam.com> wrote:
>
> Marvin M. Doyley writes:
>
> Hi there,
>
> When I use crossref-add-bibtex-entry it download the BibTeX entry but
> cannot download the associated pdf.
> I get the following error  (wrong-type-argument stringp
> ("/Users/doyley/Dropbox/Filing_Cabinet/B/refs/pdf/“))
>
> I configured org-ref as follows
>
> (setq org-ref-bibliography-notes
> '("/Users/doyley/Dropbox/Filing_Cabinet/B/refs/ref_notes.org")
>      org-ref-default-bibliography
> '("/Users/doyley/Dropbox/Filing_Cabinet/B/refs/ref.bib")
>      org-ref-pdf-directory
> '("/Users/doyley/Dropbox/Filing_Cabinet/B/refs/pdf/")
>   org-ref-notes-citation-link '("cite")
>      )
>
>
> [ Caveat: I've never used org-ref ]
>
> org-ref's 0383cc2 (support multiple pdf directories, 2016-06-10) updated
> org-ref-pdf-directory to accept a list value, so your value is valid,
> but...
>
> Debugger entered--Lisp error: (wrong-type-argument stringp
> ("/Users/doyley/Dropbox/Filing_Cabinet/B/refs/pdf/"))
>
>  file-name-as-directory(("/Users/doyley/Dropbox/Filing_Cabinet/B/refs/pdf/"))
>  doi-utils-get-bibtex-entry-pdf(nil)
>
>
> ... doi-utils-get-bibtex-entry-pdf wasn't updated for that (+cc the
> author of that commit and John Kitchin).
>
> It looks like org-ref-pdf-directory still supports a string, though, and
> you only have one item, so you should be able to work around the issue
> with
>
>  (setq org-ref-pdf-directory
> "/Users/doyley/Dropbox/Filing_Cabinet/B/refs/pdf/")
>
>
>