From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philip Hudson Subject: org-mobile leaks agenda buffer named "*SUMO*" on push [8.2.7 (8.2.7-4-g880362-elpa @ /home/phil/.emacs.d/elpa/org-20140616/)] Date: Fri, 20 Jun 2014 13:29:24 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxxwz-0008Ji-8h for emacs-orgmode@gnu.org; Fri, 20 Jun 2014 08:29:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wxxwv-0008FG-S2 for emacs-orgmode@gnu.org; Fri, 20 Jun 2014 08:29:49 -0400 Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:40353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxxwv-0008F6-Kr for emacs-orgmode@gnu.org; Fri, 20 Jun 2014 08:29:45 -0400 Received: by mail-ob0-f182.google.com with SMTP id nu7so969998obb.41 for ; Fri, 20 Jun 2014 05:29:44 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org To: emacs-orgmode@gnu.org Subject: Bug: org-mobile leaks agenda buffer named "*SUMO*" on push [8.2.7 (8.2.7-4-g880362-elpa @ /home/phil/.emacs.d/elpa/org-20140616/)] From: Phil Hudson --text follows this line-- For a long, long time -- at least two years -- I've been experiencing *something* creating and leaving around an Org agenda buffer named "*SUMO*". It's annoying, because it seems to mess up Org's agenda infrastructure, making ordinary agenda single-key commands error in various uninformative, low-level ways, for example about expected and actual types without any indication as to where the error occurred. Today I ack'ed SUMO in my packages directory and found the only occurrence is in org-mobile.el. It all made sense straight away; IOW, I felt a high degree of confidence that org-mobile.el is the site of the error. I had a very quick look at the code, but it was not obvious at a glance where the leak is. I did spot straight away a 'let' where the current name for an agenda buffer was stored before being temporarily changed that I thought should probably be a 'let*' and that therefore (if I'm right) was only working "by accident", but it wasn't obvious that it actually had anything to do with the problem, so I hacked up a workaround: Excise spurious Org agenda buffers leaked by org-mobile https://gist.github.com/PhilHudson/d6429fb48caf6065ec8c ------------------------------------------------------------------------ Emacs : GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars) of 2014-01-02 on quiz Package: Org-mode version 8.2.7 (8.2.7-4-g880362-elpa @ /home/phil/.emacs.d/elpa/org-20140616/) current state: ============== (setq org-id-locations-file "~/.emacs.d/org-id-locations" org-hide-leading-stars t org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-mobile-files '(org-agenda-files "~/org/bookmarks.org" "~/org/Cygwin-install-checklist.org" "~/org/emacs-install-checklist.org" "~/org/Handles.org" "~/org/Home-LAN.org" "~/org/linux-install-checklist.org" "~/org/Mac-install-checklist.org" "~/org/Movies.org" "~/org/music.org" "~/org/Windows-install-checklist.org") org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook) org-agenda-diary-file "~/Dropbox/myconf/diary.org" org-occur-hook '(org-first-headline-recenter) org-metaup-hook '(org-babel-load-in-session-maybe) org-log-done 'time org-confirm-shell-link-function 'yes-or-no-p org-finalize-agenda-hook '(org-agenda-to-appt) org-special-ctrl-a/e t org-agenda-prefix-format '((agenda . "%-6:c%?-12t%-13s") (timeline . "% s") (todo . "%-12:c") (tags . "%-12:c") (search . "%-12:c")) org-return-follows-link t org-default-notes-file "~/org/notes.org" org-capture-templates '(("w" "Capture from web browser such as Conkeror" entry (file+headline "~/org/notes.org" "Web capture") "* %^{Title}\\n\\n Source: %u, %c\\n\\n %i") ("t" "Capture a task" entry (file+headline "~/org/ToDo.org" "Incoming") "* TODO %? %^G\n SCHEDULED: %t\n Created: %U" :prepend t) ) org-agenda-include-diary t org-after-todo-state-change-hook '(org-clock-out-if-current) org-todo-repeat-to-state "ITERATION" org-from-is-user-regexp "\\" org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-tags-column -90 org-agenda-before-write-hook '(org-agenda-add-entry-text) org-babel-pre-tangle-hook '(save-buffer) org-global-properties '(("Effort_ALL" . "0 0:10 0:20 0:30 0:45 1:00 1:30 2:00 3:00 4:00 5:00 6:00 7:00 8:00") ) org-agenda-dim-blocked-tasks 'invisible org-mode-hook '(ph/diminish-buf-face ph/setup-org-keys ph/recover-from-saveplace-folded ph/enable-auto-revert-in-org-maybe ph/disable-desktop-in-org-maybe er/add-org-mode-expansions #[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5] #[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes) org-refile-targets '((nil :maxlevel . 5) ("~/org/someday.org" :maxlevel . 5) (org-agenda-files :maxlevel . 5)) org-outline-path-complete-in-steps nil org-agenda-compact-blocks t org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe) org-refile-use-outline-path 'file org-enforce-todo-dependencies t org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-hide-inline-tasks org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-agenda-tags-column -108 org-archive-location "Archive/%s_done::" org-agenda-finalize-hook '(org-agenda-to-appt) org-enforce-todo-checkbox-dependencies t org-refile-allow-creating-parent-nodes 'confirm org-todo-keywords '((sequence "MAYBE/SOMEDAY(m)" "WAITING(w@)" "TODO(t)" "STARTED(s!)" "|" "DONE(d!)" "CANCELED(c@)") (sequence "ITERATION(i)" "|" "NEXT(n)")) org-modules '(org-bbdb org-bibtex org-docview org-gnus org-info org-jsinfo org-habit org-irc org-mew org-mhe org-rmail org-vm org-wl org-w3m) org-agenda-window-setup 'current-window org-agenda-span 'day org-confirm-elisp-link-function 'yes-or-no-p org-metadown-hook '(org-babel-pop-to-session-maybe) org-mobile-post-push-hook '(ph/clean-up-org-mobile-cruft) org-blocker-hook '(org-block-todo-from-checkboxes org-block-todo-from-children-or-siblings-or-parent) org-mobile-directory "~/Dropbox/mobile" org-mobile-files-exclude-regexp "from-mobile\\.org" org-completion-use-ido t org-habit-graph-column 55 org-agenda-mode-hook '(ph/turn-off-filladapt-mode ph/diminish-org-agenda-indicator ph/setup-org-agenda-keys) org-mobile-post-pull-hook '(ph/notify-org-mobile-pull-new-items) org-agenda-files '("~/Dropbox/googlecalendar.org" "~/org/Birthdays.org" "~/org/notes.org" "~/org/ToSell.org" "~/org/Travel.org" "~/org/Leisure.org" "~/org/ToDo.org" "~/org/ToGet.org" "~/org/from-mobile.org") org-clock-out-hook '(org-clock-remove-empty-clock-drawer) org-src-fontify-natively t org-refile-target-verify-function 'ph/org-refile-target-verify-not-done-state org-tag-alist '((:startgroup "Activity location") ("@home" . 104) ("@office" . 111) ("@computer" . 99) ("@phone" . 112) ("@online" . 79) ("@garden" . 103) (:endgroup "Activity location") ("errands" . 69) ("work" . 119) ("edu" . 92) ("email" . 64) ("hands_on" . 95) ("paperwork" . 80) ("read" . 114) ("buy" . 98) ("meeting" . 35) ("coding" . 42) ("travel" . 84) ("leisure" . 76) ("family" . 70) ("pets" . 96) ("health" . 72) ("finance" . 102) ("webapps" . 87) ("mac" . 109) ("_n_x" . 117) ("Windows" . 45) ("research" . 63) ("security" . 126) ("emacs" . 101) ("screen" . 115) ("tcsh" . 116) ("lisp" . 108) ("meta-org" . 43) ("shell" . 83) ("vm" . 118) ("ux" . 85) ("bug" . 66) ("rfe" . 82) ("db" . 68) ("officialdom" . 60) ("next" . 110) ("social" . 120) ("Android" . 97) ("scm" . 47) ("testing" . 33) ("debian" . 100) ("network" . 78)) ) -- Phil Hudson http://hudson-it.no-ip.biz @UWascalWabbit PGP/GnuPG ID: 0x887DCA63