From mboxrd@z Thu Jan 1 00:00:00 1970 From: KDr2 Subject: Re: [PATCH] ob-scheme.el: Fix scheme code blocks execution error in batch mode Date: Fri, 11 Apr 2014 13:18:49 +0800 Message-ID: References: <87sipky46c.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c256e634696e04f6bd790f Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYTrw-0004xT-1Q for emacs-orgmode@gnu.org; Fri, 11 Apr 2014 01:19:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYTrq-0003o3-LC for emacs-orgmode@gnu.org; Fri, 11 Apr 2014 01:19:15 -0400 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:48411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYTrq-0003nx-D5 for emacs-orgmode@gnu.org; Fri, 11 Apr 2014 01:19:10 -0400 Received: by mail-ob0-f169.google.com with SMTP id va2so5568147obc.28 for ; Thu, 10 Apr 2014 22:19:09 -0700 (PDT) In-Reply-To: <87sipky46c.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: emacs-orgmode@gnu.org --001a11c256e634696e04f6bd790f Content-Type: multipart/alternative; boundary=001a11c256e634696904f6bd790d --001a11c256e634696904f6bd790d Content-Type: text/plain; charset=ISO-8859-1 Hi, Eric I'm sorry for that I used `flet' in the patch, It's a easy way to let function `current-message' work in batch mode, so I used it even I saw that emacs says `flet' is obsolete, I'm sorry for that. And I made a new patch(attachment) using `defadvice' for `message' to capture the message in batch mode, after the message being captured, the advice function is removed. Is this way OK? And I also sent a request email to assign@gnu.org, and now waiting the reply. Thanks. On Fri, Apr 11, 2014 at 10:45 AM, Eric Schulte wrote: > We can no longer use `flet' in the Org-mode code base, please re-work > this patch w/o flet. > > Also, I don't see your name in the list of contributors, and (I believe) > this patch is too large to apply w/o FSF assignment. See the following > page on how to contribute to Org-mode. > > http://orgmode.org/worg/org-contribute.html > > KDr2 writes: > > > The bug: > > write file ~/scheme-test.org with the content below: > > -------8<-------------- > > #+BEGIN_SRC scheme :exports results :results output raw > > (display "Hello Scheme in OrgMode") > > #+END_SRC > > -------8<-------------- > > > > and run: > > > > emacs --batch --eval='(load "~/.emacs.d/init.el")' ~/scheme-test.org -f > > org-html-export-to-html > > > > you will find the bug: > > > > `org-babel-scheme-execute-with-geiser' uses `current-message' to get the > > results of scheme code blocks, but `current-message' always returns nil > in > > batch mode, and this patch fixes this. > > > > -- > > -- > Eric Schulte > https://cs.unm.edu/~eschulte > PGP: 0x614CA05D > -- -- KDr2, http://kdr2.com --001a11c256e634696904f6bd790d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi, Eric

I'm sorry for that I used = `flet' in the patch, It's a easy way to let function `current-messa= ge' work in batch mode, so I used it even I saw that emacs says `flet&#= 39; is obsolete, I'm sorry for that.=A0

And I made a new patch(attachment) using `defadvice'= ; for `message' to capture the message in batch mode, after the message= being captured, the advice function is removed. Is this way OK?

And I also sent a request email=A0to assig= n@gnu.org, and now waiting the reply.

Tha= nks.


On Fri, Apr 11, 2014 at 10:45 AM, Eric Schulte = <schulte.eri= c@gmail.com> wrote:
We can no longer use `flet' in the Org-m= ode code base, please re-work
this patch w/o flet.

Also, I don't see your name in the list of contributors, and (I believe= )
this patch is too large to apply w/o FSF assignment. =A0See the following page on how to contribute to Org-mode.

=A0 http://orgmode.org/worg/org-contribute.html

KDr2 <killy.draw@gmail.com&g= t; writes:

> The bug:
> write file ~/sche= me-test.org with the content below:
> -------8<--------------
> #+BEGIN_SRC scheme :exports results :results output raw
> =A0 (display "Hello Scheme in OrgMode")
> #+END_SRC
> -------8<--------------
>
> and run:
>
> emacs --batch --eval=3D'(load "~/.emacs.d/init.el")'= ~/scheme-test.org= -f
> org-html-export-to-html
>
> you will find the bug:
>
> `org-babel-scheme-execute-with-geiser' uses `current-message' = to get the
> results of scheme code blocks, but `current-message' always return= s nil in
> batch mode, and this patch fixes this.
>
> --

--
Eric Schulte
https://cs.unm.e= du/~eschulte
PGP: 0x614CA05D



--
--=A0
--001a11c256e634696904f6bd790d-- --001a11c256e634696e04f6bd790f Content-Type: text/x-patch; charset=US-ASCII; name="0001-lisp-ob-scheme.el-Fix-scheme-code-blocks-execution-e.patch" Content-Disposition: attachment; filename="0001-lisp-ob-scheme.el-Fix-scheme-code-blocks-execution-e.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_htv0v7wj0 RnJvbSBmZTU1NDlmM2Y0OGFjZjliNTFhZWIzNzA2ZWI4ZGQzZDc2YWIxOGMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLRHIyIDxraWxseS5kcmF3QGdtYWlsLmNvbT4KRGF0ZTogRnJp LCAxMSBBcHIgMjAxNCAxMjo1NjoyNCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGxpc3Avb2Itc2No ZW1lLmVsOiBGaXggc2NoZW1lIGNvZGUgYmxvY2tzIGV4ZWN1dGlvbiBlcnJvciBpbgogYmF0Y2gg bW9kZQoKKiBsaXNwL29iLXNjaGVtZS5lbCAob3JnLWJhYmVsLXNjaGVtZS1jYXB0dXJlLWN1cnJl bnQtbWVzc2FnZSwgb3JnLWJhYmVsLXNjaGVtZS1leGVjdXRlLXdpdGgtZ2Vpc2VyKTogQ2FwdHVy ZSBzY2hlbWUgY29kZSByZXN1bHRzIHZpYSBjdXJyZW50LW1lc3NhZ2UgYm90aCBpbiBpbnRlcmFj dGl2ZSBtb2RlIGFuZCBub25pbnRlcmFjdGl2ZSBtb2RlLgoKYG9yZy1iYWJlbC1zY2hlbWUtZXhl Y3V0ZS13aXRoLWdlaXNlcicgdXNlcyBgY3VycmVudC1tZXNzYWdlJyB0byBnZXQgdGhlIHJlc3Vs dHMgb2Ygc2NoZW1lIGNvZGUgYmxvY2tzLCBidXQgYGN1cnJlbnQtbWVzc2FnZScgYWx3YXlzIHJl dHVybnMgbmlsIGluIGJhdGNoIG1vZGUsIGFuZCB0aGlzIHBhdGNoIGZpeGVzIHRoaXMuCgpNb2Rp ZmllZCBmcm9tIGEgcGF0Y2ggcHJvcG9zYWwgYnkgS0RyMihraWxseS5kcmF3QGdtYWlsLmNvbSkK LS0tCiBsaXNwL29iLXNjaGVtZS5lbCB8IDIwICsrKysrKysrKysrKysrKysrLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s aXNwL29iLXNjaGVtZS5lbCBiL2xpc3Avb2Itc2NoZW1lLmVsCmluZGV4IGI3MTE3ZTkuLjZiODJj NmUgMTAwNjQ0Ci0tLSBhL2xpc3Avb2Itc2NoZW1lLmVsCisrKyBiL2xpc3Avb2Itc2NoZW1lLmVs CkBAIC0xMTgsNiArMTE4LDE5IEBAIG9yZy1iYWJlbC1zY2hlbWUtZXhlY3V0ZS13aXRoLWdlaXNl ciB3aWxsIHVzZSBhIHRlbXBvcmFyeSBzZXNzaW9uLiIKIAkgICAgICAgKG5hbWUpKSkpCiAgICAg cmVzdWx0KSkKIAorKGRlZm1hY3JvIG9yZy1iYWJlbC1zY2hlbWUtY2FwdHVyZS1jdXJyZW50LW1l c3NhZ2UgKCZyZXN0IGJvZHkpCisgICJDYXB0dXJlIGN1cnJlbnQgbWVzc2FnZSBpbiBib3RoIGlu dGVyYWN0aXZlIGFuZCBub25pbnRlcmFjdGl2ZSBtb2RlIgorICBgKGlmIG5vbmludGVyYWN0aXZl CisgICAgICAgKGxldCAoKGN1cnJlbnQtbWVzc2FnZSBuaWwpKQorICAgICAgICAgKGRlZmFkdmlj ZSBtZXNzYWdlIChhZnRlciBjYXB0dXJlLWN1cnJlbnQtbWVzc2FnZSBhY3RpdmF0ZSkKKyAgICAg ICAgICAgKHNldHEgY3VycmVudC1tZXNzYWdlIGFkLXJldHVybi12YWx1ZSkpCisgICAgICAgICAs QGJvZHkKKyAgICAgICAgIChhZC11bmFkdmlzZSAjJ21lc3NhZ2UpCisgICAgICAgICBjdXJyZW50 LW1lc3NhZ2UpCisgICAgIChwcm9nbgorICAgICAgICxAYm9keQorICAgICAgIChjdXJyZW50LW1l c3NhZ2UpKSkpCisKIChkZWZ1biBvcmctYmFiZWwtc2NoZW1lLWV4ZWN1dGUtd2l0aC1nZWlzZXIg KGNvZGUgb3V0cHV0IGltcGwgcmVwbCkKICAgIkV4ZWN1dGUgY29kZSBpbiBzcGVjaWZpZWQgUkVQ TC4gSWYgdGhlIFJFUEwgZG9lc24ndCBleGlzdCwgY3JlYXRlIGl0CiB1c2luZyB0aGUgZ2l2ZW4g c2NoZW1lIGltcGxlbWVudGF0aW9uLgpAQCAtMTQyLDEwICsxNTUsMTEgQEAgaXMgdHJ1ZTsgb3Ro ZXJ3aXNlIHJldHVybnMgdGhlIGxhc3QgdmFsdWUuIgogCQkJICAgICAoY3VycmVudC1idWZmZXIp KSkpKQogCShzZXRxIGdlaXNlci1yZXBsLS1yZXBsIHJlcGwtYnVmZmVyKQogCShzZXRxIGdlaXNl ci1pbXBsLS1pbXBsZW1lbnRhdGlvbiBuaWwpCi0JKGdlaXNlci1ldmFsLXJlZ2lvbiAocG9pbnQt bWluKSAocG9pbnQtbWF4KSkKKwkoc2V0cSByZXN1bHQgKG9yZy1iYWJlbC1zY2hlbWUtY2FwdHVy ZS1jdXJyZW50LW1lc3NhZ2UKKwkJICAgICAgKGdlaXNlci1ldmFsLXJlZ2lvbiAocG9pbnQtbWlu KSAocG9pbnQtbWF4KSkpKQogCShzZXRxIHJlc3VsdAotCSAgICAgIChpZiAoZXF1YWwgKHN1YnN0 cmluZyAoY3VycmVudC1tZXNzYWdlKSAwIDMpICI9PiAiKQotCQkgIChyZXBsYWNlLXJlZ2V4cC1p bi1zdHJpbmcgIl49PiAiICIiIChjdXJyZW50LW1lc3NhZ2UpKQorCSAgICAgIChpZiAoYW5kIChz dHJpbmdwIHJlc3VsdCkgKGVxdWFsIChzdWJzdHJpbmcgcmVzdWx0IDAgMykgIj0+ICIpKQorCQkg IChyZXBsYWNlLXJlZ2V4cC1pbi1zdHJpbmcgIl49PiAiICIiIHJlc3VsdCkKIAkJIlwiQW4gZXJy b3Igb2NjdXJyZWQuXCIiKSkKIAkod2hlbiAobm90IHJlcGwpCiAJICAoc2F2ZS1jdXJyZW50LWJ1 ZmZlciAoc2V0LWJ1ZmZlciByZXBsLWJ1ZmZlcikKLS0gCjEuOS4yCgo= --001a11c256e634696e04f6bd790f--